Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp522661rdb; Tue, 19 Sep 2023 02:32:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJo5rkq8gfzq47f3MPDIcvEhQFSIrRl9fjiQQ8aOV1XLTQUvBssPAamZQ6kZNb4WBbzHkD X-Received: by 2002:a17:90b:3647:b0:269:a96:981a with SMTP id nh7-20020a17090b364700b002690a96981amr2637819pjb.5.1695115943758; Tue, 19 Sep 2023 02:32:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695115943; cv=none; d=google.com; s=arc-20160816; b=q19gpLqq9t7VelsafGf0RI5/grz450qkJFwMVMQBrGrpiJwITWYOPxH8OWgt5k+v39 IkYKELXheWfc7RNisMykSKadXh2nd5Zb+ZNjfwsXDHwDF6dLVhcyPTLcGAsIEHPfU28/ YbmU4BZ35zSdFLgOEoARBgxP1Cm4FCl+vYoL0glBHUdI1tZTDFeOLUuESbi6ByvKgZgc fXakrRH5EIrSwPgXREFA8AWT7m2vJ70LsnvzWV4vr+URgB62PfBZd+UUhY3SEk/meUvF A5weXePsVL/ntwjZDK2rHmN2ceDV9g2rn6mSlA89n80Dca7ISDoy1eH/vzKcAdKBAZb2 jPQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=aymvy/hrb0UNlUkBIEVbQwUqpKTrMQqNVV2dEokfL+U=; fh=rvfjkWKWQ7H3dxwU/Mrzlf1SBsZ3Tuo/EBElQFetDNM=; b=Bq+SUdmyijwhr7elKYRxBMCRxc+d4MjIY5W180TTdeJ/ck+GE1+bcY2t/6O6gSB0/l VPpW/ox61rrPVIJ1E4ipWGAiMQVBJChRm+7SyqsaFT+k6bS5IMsuNh2MFexZBrCYWAao a+O2DiBOzxOSAzXo1LdJnByGcLOVtLxGIVKd4Gk+WuqR1HN2+XNIbBeAXZdfUeEr14rG 7k+YT4AzdCySj+iVcdnLzBr2nQdsX94pxiTAi6p8es2rTMqJlFPgbCwW8KyXwo9ENrse fQwaRWyi2eCmSEWq7UgIF2KXtDhv/L6x7BcPtIK9LRNMAwJMuqlbMAyIo2eDBMnTdbCE 5z5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id b2-20020a17090a9bc200b002766354b7aesi3285887pjw.166.2023.09.19.02.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 02:32:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0543C8186527; Tue, 19 Sep 2023 02:28:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229449AbjISJ2D (ORCPT + 99 others); Tue, 19 Sep 2023 05:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbjISJ1q (ORCPT ); Tue, 19 Sep 2023 05:27:46 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0561133; Tue, 19 Sep 2023 02:27:35 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F406C433C7; Tue, 19 Sep 2023 09:27:31 +0000 (UTC) Message-ID: Date: Tue, 19 Sep 2023 11:27:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 22/49] media: i2c: Stop direct calls to queue num_buffers field Content-Language: en-US, nl To: Benjamin Gaignard , mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, ming.qian@nxp.com, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, nicolas.dufresne@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, kernel@collabora.com References: <20230914133323.198857-1-benjamin.gaignard@collabora.com> <20230914133323.198857-23-benjamin.gaignard@collabora.com> From: Hans Verkuil In-Reply-To: <20230914133323.198857-23-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 19 Sep 2023 02:28:11 -0700 (PDT) On 14/09/2023 15:32, Benjamin Gaignard wrote: > Use vb2_get_num_buffers() to avoid using queue num_buffer field directly. Since this affects just one driver, can you change the subject to: media: video-i2c: Stop direct calls to queue num_buffers field Thanks! Hans > > Signed-off-by: Benjamin Gaignard > --- > drivers/media/i2c/video-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c > index 537ebd9fa8d7..60d3e2f35afe 100644 > --- a/drivers/media/i2c/video-i2c.c > +++ b/drivers/media/i2c/video-i2c.c > @@ -406,7 +406,7 @@ static int queue_setup(struct vb2_queue *vq, > struct video_i2c_data *data = vb2_get_drv_priv(vq); > unsigned int size = data->chip->buffer_size; > > - if (vq->num_buffers + *nbuffers < 2) > + if (vb2_get_num_buffers(vq) + *nbuffers < 2) > *nbuffers = 2; > > if (*nplanes)