Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <4aa875a0-fb11-4ac4-aa4a-9a4a500e50db@oracle.com>
Date:   Tue, 19 Sep 2023 09:18:21 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 6/8] hugetlb: batch PMD split for bulk vmemmap dedup
To:     Muchun Song <muchun.song@linux.dev>,
        Mike Kravetz <mike.kravetz@oracle.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Oscar Salvador <osalvador@suse.de>,
        David Hildenbrand <david@redhat.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        David Rientjes <rientjes@google.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Barry Song <21cnbao@gmail.com>, Michal Hocko <mhocko@suse.com>,
        Matthew Wilcox <willy@infradead.org>,
        Xiongchun Duan <duanxiongchun@bytedance.com>,
        linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
References: <20230918230202.254631-1-mike.kravetz@oracle.com>
 <20230918230202.254631-7-mike.kravetz@oracle.com>
 <7d0129fb-551f-e37a-f6cd-8fd96c896851@linux.dev>
Content-Language: en-US
From:   Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <7d0129fb-551f-e37a-f6cd-8fd96c896851@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2ZxR1Z1RVhaNDdneGxUODFjVkw5cTVveS9jNTJSa0M5d2I0bXgxaGV1YkMw?=
 =?utf-8?B?MGhOQVFRVStxcGJETnBUanN6YjJxcFBjWnJhZ1R3Q3FxZXM0bmZGYk5ZNHpV?=
 =?utf-8?B?b0hZY094aWVobms0ajB0QzVDQVdleVZXdTEzZkdBeGpqeElBaU5PUndZbmp4?=
 =?utf-8?B?NkRsT0s1alRGTHBhb0VHSE5CZFNlTjJkaDVBYndOT2dMMHUvMCsxejQ0aG1p?=
 =?utf-8?B?V3dGUjJnZDQyOE9uNnljMVFXUXlRNGtNdkJXRnE4K1BDV3QvbW5Xd1JrbEZa?=
 =?utf-8?B?YUVoZWtYNDhWRG9sMkdTam9yTTB4UlZEOXk2Yjd1aHhhU1FwMHdqWkdTaFE2?=
 =?utf-8?B?ZlFaMXJlMUl2dTA3ZG1EMmdKV2xUMzNHdnBaUjJTZHRSb1E1dXVtaGJRQjNo?=
 =?utf-8?B?TnFQVEVsQUNrcHppZndYa3NRdjhMWUxqK2VDRVZaeHhHSjUxTkpucVBzUFZ5?=
 =?utf-8?B?VTRreUswU0Voa2kyYUZGQit0eVFpMFBuRkZKZ2hwSTB4OHlyakNYZnV5RVpm?=
 =?utf-8?B?V1lldXRkanV3WmFlT0ZGUTJXNjRWOU13ZEkxNjJ2bE5xZUxSQVhJSTAwQjR6?=
 =?utf-8?B?ZGlWNlE0YnZoTkRCb0lsSVZyZk9SNkY2Y3lvaHU5Y2ZwL1BIVXpZRnJRM2do?=
 =?utf-8?B?MmJlRlZoZHhIV0htZ01obGQ1elVIR240Y1YyOU1kaGlLNG41YmgyVTdjZEZY?=
 =?utf-8?B?alFia0MzMURaZllXV01WSlcvRjB0MENMQyt5Tnd5NFFBbk5QYWRHZU1NT3Ar?=
 =?utf-8?B?clhtRTBqT1ZWcXcxblRNckNYcWJBcGFjaDdKZEF5RnZTaWNiTGIyMlFKWWcw?=
 =?utf-8?B?cjI1eGMxME9hdUIrdzNQWXlObGFoOU4wakJnd1B5bkpkdTV2Z2ovZW0xSWpM?=
 =?utf-8?B?TTdLS1RCeUowMDI5L0NxUm0wSi9VUjhwbWFvM0ZKQXFXc2Eyb21sa0dtdEFz?=
 =?utf-8?B?RmNuVDBod0lkd05zN2hZdjgrYlQyLzRUazhrbHRJWkJRSkNGOVhiUGVCTkxw?=
 =?utf-8?B?Y0RRZzB6aEpBQTNZaFFwaExPN2lwMkpkSko4a1lTd0h6Z0V5cVRWYmh5Ukhy?=
 =?utf-8?B?YURVZk1rSy96RDNsZDdVZlRyWXcrWlVGeHlGNXFLWDJCUFVMQkxmdVdBb1Vw?=
 =?utf-8?B?RlNscVZyenczUkgrcW5EY0F2aHo4N202SERlREhDUHJlZytrU0JEZFBRSTMx?=
 =?utf-8?B?OHhHRDhrbEt2MnNwSmpWL1MzM3VMTm9lOWxlYXE3SHpOUVV6TmRkMjdqWGRB?=
 =?utf-8?B?QVhsVzZpVG42UDNaeHEvVitPdWYwMmkvZm85OStMZDJZNGVwVXRnMVF5YTEz?=
 =?utf-8?B?L0pTdm1HNjBmSWExUVF6cm9qVnFpdkMxbVBNV28xazdNaUFXZkxPYWJ3T2hL?=
 =?utf-8?B?azBpQlhCeXFYYUZuMFF1d3hPdGZSUkExanpOZ0x2SERTemt6VlJUeDEwUWZw?=
 =?utf-8?B?WDRrWG9YRyt0T2hUamVlSUV6aS9uK3lFRnMyMk1sMDFsYzlwQWR0RjFCUUkw?=
 =?utf-8?B?cmNrT256a3drN0QxMDVaa2psYU9Xd3FLOVhMeDR1NG50b0hrb0ZaTHk0WFQy?=
 =?utf-8?B?MFRORUxyYjhKSHhycHRHbnlXK2tGTGlnTDNnczAvRnlQSkZnL1lvTmxxL2pi?=
 =?utf-8?B?cVhlN1phNTVCTVJicU9KbUZ2MGhyUnVHclUwNzA5Sld3YW1JcU02clB6NHNE?=
 =?utf-8?B?QzQvdGZpWWJhWUs0L0hYQW5HdllKcW9Gb0VCaWRKRlZmZDA1SFdnTFB5c0NV?=
 =?utf-8?B?Y1ZFeUhtbmtwYlhiclcxQjRySUZUUGpob1JkK3I0MzBZdTdHM0hIcU5majcy?=
 =?utf-8?B?K3VvVW5HV1IwSnpxdTJEOU0wMExyZlovSXVXdy8yMlhYR2tIeTNMMnZUbFRU?=
 =?utf-8?B?ay9kS2FhdGRyQnYxUy9sV2dPaHJWQkF1RytjYzdwREJXdkZsL3F0NVJndUV3?=
 =?utf-8?B?VWlyTUJBMVc0WnZQQmh3NW91ODR3QWh2dGRJZHljVzNYU0dkZkVaRVl6cldI?=
 =?utf-8?B?dTVrazBoK0tyeHp1V3hDaGJQQXBmL0pIbmw3VkFleloxUkhwS290ZC9haGlK?=
 =?utf-8?B?NWNhU2R3ckt0ZUxpaTZEeGFEN2dPMTdaTmdwODZTeU1nd0lIM09FUDU0cEN0?=
 =?utf-8?B?T1ZteEt3cUlSQnBWVUFVVmZiNytBUjB0Q3VhNFEweUN2djQzM1orWnd4V1Zr?=
 =?utf-8?B?eUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?QUZqSmprUVFxbTBkbEFmK3RkQWZGUDNKQi9FMXYzeDFvTjlRaWpDN0hGMk9R?=
 =?utf-8?B?TmxNVXdZdXR6amtjYUJhMHBENXpDbm8yUWl1YnBvTVhjQ1NGSVc1b1lJMmQ0?=
 =?utf-8?B?ZWRBVFoxS2gvYXFXWEdOeFNQL3VYUXVTdXJNWjlKVlJhZjJvSDdHdzNyWDNU?=
 =?utf-8?B?QWd2NEFLT2RRbkV2YTFPSlZzNVozV09EVnp0MzFKOUVaVG5xWi8ydTZaaXZq?=
 =?utf-8?B?Wkp5ODZGWjZoK1pzQ3k2R0xwTjR5WGE1ZGxQWWxkb2NTWFNIU0R4NTJNVjhK?=
 =?utf-8?B?Y3pLTlBMc1JwQTFhTElmNFkyYW9zeW9OUjR5R2NMZXFTd3B5TnJ4cTVqU25J?=
 =?utf-8?B?NEg4Y3hlZno5OGRVK21HeHhJRW9GSGI3NWFoS3ZteTYweEllYVp1dXJFZmRE?=
 =?utf-8?B?aWRDcnBUQktBRmlKQi9IcDlTUWhkSkxGckFVVmpIS2k3QVpJcHRRQkNHZHFR?=
 =?utf-8?B?QXJRblNRSDBMQ2c1OWZ1V3JaUG0rajdHbHFVMXFFbkp3dEcvR1lrRkYzMXBN?=
 =?utf-8?B?VXJJRDc5Wjl0dXlXS1lUZGNyT2pWckNLdXpwT1BOU2oyOXZkUHYwbytQYVli?=
 =?utf-8?B?WEJtU3BaQWN6NVV4UTJuKytWVHVQdG9EZGQ4cVNmYVB4dnZ3bHc4bDhhUEdn?=
 =?utf-8?B?MC9sOE5YVS9MNzBLczEzSTAvWC9HTGJJY0hUOHRGaCttUHVMNnBnSGovdXFB?=
 =?utf-8?B?ajNYc0JzM2NIbXl4Z0dzYjlIR0QxTWNYaWdqd0xyVlZGZTg1Y0ZnRllEcFNQ?=
 =?utf-8?B?NGx4NGVKODhPbTQxRXdaMjI5VkRlTTdMZytMNUh4ZmFiNDY5OS9UamNSK3Ft?=
 =?utf-8?B?NFF5MW5zeVpKQzExNjUxaERKbHh4Ky84TXh6dTRPU2hkZTJzbDZSYm4yb3NX?=
 =?utf-8?B?Tmp0WVk0ZEpNSUk2d00ycjNVcS9PZ3d5VmUwQWpmWGMzMStjTUtMQnlBQWVL?=
 =?utf-8?B?MktWMlRRQ3hzeUpheFQzaU5VZ2pEZXJlMFl0b3FwaEdQOE9kdzRXYmkyYis4?=
 =?utf-8?B?YXhyM2FnSGFXamwvaDlJbGdwZ0wvUVdvU0JSeXpIRllhM3EyNkhmc1ZSTHdU?=
 =?utf-8?B?bC9NVCtHd0RrZlZnaDlQalA0aDB1OElOQk5sbkQ3ZUloWGpwYUZIWUNEUkgy?=
 =?utf-8?B?TmVZSHBLZFRVRHBvZzhmV2JDaVZMbFlyeDUxT01nSWhSNzdmNTMxNmtTcVFO?=
 =?utf-8?B?OGkvdFBaY2IvdGhFeDM0N1A3UXZMLzVRdE0vdVZ6Wm5MTDBnSHIvNitjanRF?=
 =?utf-8?B?VWJQMUVibTBpeXBuN05jVG05M1F6VjBRNVhLVDI0K2diczkySjY4YlJ3VU9Y?=
 =?utf-8?B?Tmk2UHJEVmNiRnFVRDlPdVBqL2VYMHZWeUVlUG9EZ0l4WWR5ODFyRlJQR0Nw?=
 =?utf-8?B?T3lseS9FbExDTjFaK3BPRXRJOS9EL1hyOXB3SnNtcDBQb0VTVFVJOUJYQzNC?=
 =?utf-8?B?cmdOMmpsbFRJZExtWmVIalFyamZMbHZNc3VuRlZzeFlpUFJzSDRvTVhrSUE4?=
 =?utf-8?Q?tIS7oHpGYc+QhN8cJfQVCClsJDf?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92817783-e4fa-4b39-b07f-08dbb8e900d0
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 08:18:28.5644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jVnfT8RdARV0i0wQJC4VjK27k3rhHhroH1ZeiwOW+CaFTASRHI1+ImbLtkran6tyNKdr7Irl8O+hy5z2Y+xi84K3B6XbNuEpAF/i1lJkeFE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6063
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-19_03,2023-09-18_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 malwarescore=0
 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000
 definitions=main-2309190069
X-Proofpoint-GUID: qqq1V5VrkD3yaydbfc6EH2ReR-2ryiTl
X-Proofpoint-ORIG-GUID: qqq1V5VrkD3yaydbfc6EH2ReR-2ryiTl
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 19 Sep 2023 01:19:46 -0700 (PDT)

On 19/09/2023 07:27, Muchun Song wrote:
> On 2023/9/19 07:01, Mike Kravetz wrote:
>> From: Joao Martins <joao.m.martins@oracle.com>
>>
>> In an effort to minimize amount of TLB flushes, batch all PMD splits
>> belonging to a range of pages in order to perform only 1 (global) TLB
>> flush.
>>
>> Add a flags field to the walker and pass whether it's a bulk allocation
>> or just a single page to decide to remap. First value
>> (VMEMMAP_SPLIT_NO_TLB_FLUSH) designates the request to not do the TLB
>> flush when we split the PMD.
>>
>> Rebased and updated by Mike Kravetz
>>
>> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>> ---
>>   mm/hugetlb_vmemmap.c | 79 +++++++++++++++++++++++++++++++++++++++++---
>>   1 file changed, 75 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
>> index 147ed15bcae4..e8bc2f7567db 100644
>> --- a/mm/hugetlb_vmemmap.c
>> +++ b/mm/hugetlb_vmemmap.c
>> @@ -27,6 +27,7 @@
>>    * @reuse_addr:        the virtual address of the @reuse_page page.
>>    * @vmemmap_pages:    the list head of the vmemmap pages that can be freed
>>    *            or is mapped from.
>> + * @flags:        used to modify behavior in bulk operations
>>    */
>>   struct vmemmap_remap_walk {
>>       void            (*remap_pte)(pte_t *pte, unsigned long addr,
>> @@ -35,9 +36,11 @@ struct vmemmap_remap_walk {
>>       struct page        *reuse_page;
>>       unsigned long        reuse_addr;
>>       struct list_head    *vmemmap_pages;
>> +#define VMEMMAP_SPLIT_NO_TLB_FLUSH    BIT(0)
> 
> Please add a brief comment following this macro to explain what's the
> behavior.
> 

/* Skip the TLB flush when we split the PMD */

And will also do it in the next patch with:

/* Skip the TLB flush when we remap the PTE */

>> +    unsigned long        flags;
>>   };
>>   -static int split_vmemmap_huge_pmd(pmd_t *pmd, unsigned long start)
>> +static int split_vmemmap_huge_pmd(pmd_t *pmd, unsigned long start, bool flush)
>>   {
>>       pmd_t __pmd;
>>       int i;
>> @@ -80,7 +83,8 @@ static int split_vmemmap_huge_pmd(pmd_t *pmd, unsigned long
>> start)
>>           /* Make pte visible before pmd. See comment in pmd_install(). */
>>           smp_wmb();
>>           pmd_populate_kernel(&init_mm, pmd, pgtable);
>> -        flush_tlb_kernel_range(start, start + PMD_SIZE);
>> +        if (flush)
>> +            flush_tlb_kernel_range(start, start + PMD_SIZE);
>>       } else {
>>           pte_free_kernel(&init_mm, pgtable);
>>       }
>> @@ -127,11 +131,20 @@ static int vmemmap_pmd_range(pud_t *pud, unsigned long
>> addr,
>>       do {
>>           int ret;
>>   -        ret = split_vmemmap_huge_pmd(pmd, addr & PMD_MASK);
>> +        ret = split_vmemmap_huge_pmd(pmd, addr & PMD_MASK,
>> +                walk->flags & VMEMMAP_SPLIT_NO_TLB_FLUSH);
> 
> !(walk->flags & VMEMMAP_SPLIT_NO_TLB_FLUSH)?
> 
Yeah -- Gah, I must be very distracted.

Thanks