Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp534592rdb; Tue, 19 Sep 2023 03:02:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4SWQNrlWoKnpS9/Tlx6F86TIrF+sNxrAVpJHxiCcBGBLNy64QYv/2gh/fGu/q5DocU2B7 X-Received: by 2002:a17:902:da91:b0:1b6:6b90:7c2f with SMTP id j17-20020a170902da9100b001b66b907c2fmr11910644plx.55.1695117737444; Tue, 19 Sep 2023 03:02:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695117737; cv=none; d=google.com; s=arc-20160816; b=j05pR0BN4DFTtAgfo5+kFxDR9RePp0pV3pVUif2yZqwgIiuEckxG4gtPQqwxxP/oAD /mPMpYAspWWFb8FTHOh+YJf8e+xAqodHGfexSnJOS56oqjB2aQZCKDHMLMbVKjG+XUOh 8vq5oO/LXXYDKL+qG+NPuzGZqG5l+0wx1LQNmzLOCzz4qS77ykn5NyYvO+UZ2p5ODefV 0KsS7quvTPrkdpXidaWyjrXEEoejYbX831mZAM6+/DVr0uk8iqvV7JyeJiSFciyYIYUa 8TjcO1raDQIPuXEYeIBS+PcSDPGBPm4WMJimYIJBBTUPp+EH4/X6ljoK8K6Y1PyCY8OE QtRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4CU44Fr3cMn484yNM+H7O0f8G1vBc/JA5Ov3WXXhhkk=; fh=RPoVfnx4tl9FmYoU+jBE1k3+5oEwvmEVGBtC8TRVY7I=; b=bN4ddXZLKEZQsoua4QFlaHl+SxLvdAj6JSrPZWc8FhMCQlwHztRonmOfqMEO9ZQmcj rB78K+L3ccITQGayB/Nf19ekrcQDbdMFzwi1Q20kPO/YJ5+St3M0ms757edc2vVrDori IT1+g5Oc6UXgR9J5lnZBeE82IvWM2lgxFui0Pvcx3ieAadHiug8LdrDsmDBg3aZ5NVNZ 1gakFk8fe5N7p8WmRJ9es8fBEi/su+6kCtscr15hz/mKx2/Gci+kNuzk0HbsEBY+YqjU suogVyfmw8M5kl25P/9fqIleiG4AbWrEGD2ssmJ9cIC11B7t/wvni4lywiDMYK8YIOB6 BOJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WMj9st1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id d1-20020a170902cec100b001b874c5f7a8si9421071plg.653.2023.09.19.03.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 03:02:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WMj9st1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id E539081C57F4; Tue, 19 Sep 2023 01:34:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231615AbjISIeg (ORCPT + 99 others); Tue, 19 Sep 2023 04:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbjISIea (ORCPT ); Tue, 19 Sep 2023 04:34:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96D0E11C; Tue, 19 Sep 2023 01:34:22 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DD7EC433BB; Tue, 19 Sep 2023 08:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695112462; bh=v6C3Kv6sJefn6hl+Ywp4TwA5HQWieFzbjla5S20Jk3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WMj9st1OEM7HmnN+05vosvwSmvE79S0TbOnXgaZRa1txEZLAh8GLVYJzBNhtRRFIM +o8hj0iuB4zgs2Fcy83+2fC824AlB0xVGy6HD2yHvhHdaGOD8j9BXYpiDfT8Cp7e/w JtepQ/HfLFWvv4DZzT5NT19hYrnqCL9H2jAWz9VY= Date: Tue, 19 Sep 2023 10:29:08 +0200 From: Greg KH To: Edward AD Cc: eadavis@sina.com, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] tty: fix memory leak in gsm_activate_mux Message-ID: <2023091922-unplug-flask-f2e5@gregkh> References: <2023091954-algebra-hastiness-3bb8@gregkh> <20230919080207.3654671-2-twuufnxlz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230919080207.3654671-2-twuufnxlz@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 19 Sep 2023 01:35:00 -0700 (PDT) On Tue, Sep 19, 2023 at 04:02:08PM +0800, Edward AD wrote: > When the call to gsm_register_devices() fails, we need to reclaim the memory > requested in gsm_dlci_alloc(). > > Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open") > Reported-and-tested-by: syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com > Signed-off-by: Edward AD Please use your company name/email address, and then just set a manual "From:" line as the first line in the changelog as the documentation asks. That's how developers work around their broken corporate email systems (but really, you should go and poke your IT group to fix it.) thanks, greg k-h