Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 18 Sep 2023 07:47:13 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Luiz Capitulino <luizcap@amazon.com>
Cc:     lizefan.x@bytedance.com, hannes@cmpxchg.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        longman@redhat.com, lcapitulino@gmail.com,
        Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Subject: Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option
Message-ID: <ZQiNIWQe7spOwjil@slm.duckdns.org>
References: <20230906005712.66461-1-luizcap@amazon.com>
 <29bdb453-c6e3-a047-1f27-e9656da92301@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <29bdb453-c6e3-a047-1f27-e9656da92301@amazon.com>
Precedence: bulk

On Mon, Sep 18, 2023 at 10:01:13AM -0400, Luiz Capitulino wrote:
> 
> 
> On 2023-09-05 20:57, Luiz Capitulino wrote:
> > We have a need of using favordynmods with cgroup v1, which doesn't support
> > changing mount flags during remount. Enabling CONFIG_FAVOR_DYNMODS at
> > build-time is not an option because we want to be able to selectively
> > enable it for certain systems.
> > 
> > This commit addresses this by introducing the cgroup_favordynmods=
> > command-line option. This option works for both cgroup v1 and v2 and
> > also allows for disabling favorynmods when the kernel built with
> > CONFIG_FAVOR_DYNMODS=y.
> > 
> > Signed-off-by: Luiz Capitulino <luizcap@amazon.com>
> 
> Ping?

Michal raised some valid concerns. I don't really mind that it's not great
on the edges tho. Michal, what do you think?

Thanks.

-- 
tejun