Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <d4635a1b-2a50-5858-62f0-c58f5b59b0a2@amd.com>
Date:   Tue, 19 Sep 2023 13:06:39 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] tools/power/x86/intel_pstate_tracer: Use pygnuplot
 package for Gnuplot
Content-Language: en-US
To:     Doug Smythies <dsmythies@telus.net>,
        'Mario Limonciello' <mario.limonciello@amd.com>
Cc:     rafael.j.wysocki@intel.com, Ray.Huang@amd.com, li.meng@amd.com,
        shuah@kernel.org, sukrut.bellary@gmail.com, gautham.shenoy@amd.com,
        wyes.karny@amd.com, Perry.Yuan@amd.com, zwisler@chromium.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        'Srinivas Pandruvada' <srinivas.pandruvada@linux.intel.com>
References: <20230915104057.132210-1-swapnil.sapkal@amd.com>
 <20230915104057.132210-3-swapnil.sapkal@amd.com>
 <00b201d9e819$b2447e80$16cd7b80$@telus.net>
 <2fd025a9-52f3-4922-99cf-82355b0e35fe@amd.com>
 <CAAYoRsUhusVzOnaGHjPoMWYy2_iPFAjFLoCrj6vSX26EHNWGiw@mail.gmail.com>
 <001c01d9e9b0$073fadf0$15bf09d0$@telus.net>
From:   Swapnil Sapkal <Swapnil.Sapkal@amd.com>
In-Reply-To: <001c01d9e9b0$073fadf0$15bf09d0$@telus.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXpGdENUYm05WXMyeDIwL2pjRW9UMkFITnQzRGM5TWVPSkFXaEdOOENVYnU0?=
 =?utf-8?B?WThvMjhoeGxyelhWNjRkalB4UVRZR0V4Mm1vN3RJaVNUdWRyZkkyaVcvUTEv?=
 =?utf-8?B?U2x2alJpRjZpbDM2MWh4ekxUQUQ4akVBRjlqWmEzZEltUmxJTTNCYldvN1pp?=
 =?utf-8?B?MWZCVzJrbU5DWTVIRGRlRFlyc3BkSnlTNkxZYmdrZVJnU2xJaGlIcE5NOG9j?=
 =?utf-8?B?S2h4dTRxZkErT0dnazB0ZHFwb3FTMGxJK0pJaDVVS2pPY0Z0YnVRWmh2eGt1?=
 =?utf-8?B?UHF0TkpzMjJ4U1hVbUZJdnZlYlJmeGRUUlM3S05La0o3ZGZIQUpDOXRZS2Z1?=
 =?utf-8?B?TGxPSmFPTkt1cENWQTI5QnRFM2ZjSTRkN25uU25MMml5SnJsV2hEdThuM3hG?=
 =?utf-8?B?YWQ3Rlh0ZlNXM3FySDVwbEpPVk94TWpUdm1oakpscVdRRlc1NzBJRFB5MEgv?=
 =?utf-8?B?OWpiQ2t2S015ZVlpVVpMY0JNQVRYY0lFL05GWnNuWXVlTzRjNjJPQXNmTXd4?=
 =?utf-8?B?UjZlRzgva1UvcmRSYnZkU2lQQ3RYcnpIeTVoRHdSTjN6eXVoaWJUVElJQzdN?=
 =?utf-8?B?QndVU1ROK01zSXFHVTE2V0kzTXFBTkFGeUxZdWdTR3F3M3BxR2FpOEF3Z09I?=
 =?utf-8?B?aGRsSmRnbW5EbVNpVWR5N29iNVl0NUhBdjBydUhzR1Z2YVVlcjJzd2RYWFY4?=
 =?utf-8?B?bnF1bks4MFptR0RDSXM0aUlQajZRQTVyNzVvblZybytUdEN4dXQyZW5PamNT?=
 =?utf-8?B?UlR3SUJoZS83R21kczByY29GbGJuc1Z2dFRYNklCL2k5eDNnNXhuUUpvaXRI?=
 =?utf-8?B?TThHSkZicmZlc0l4ZFZYVTJmdi91UVFsRVB4ZDFiTVprMGpCeXpIZ3l5aEJE?=
 =?utf-8?B?eU5OSGtJaEhON1k0b1FMaDM5NkpRcVpmaWlVL1k3czZsdklwWnlDeTVQMEsv?=
 =?utf-8?B?RXBvTGE0cmhlSlVEcUQyMFJTN2NNbHEvRXpKMTZ6OWM3WElFT3k2M3QwZVFD?=
 =?utf-8?B?V1UrYjRqY2QrZTJDQUdNWUJpKzU1Z0xDd3UxOWVBUkMvdEtiWUNpZlhvY0Uz?=
 =?utf-8?B?NnZKUHpTMXJlcGJiS2pua0lYS3pKSEtiSkpuZ3UySmFyTGxmcDd5QUhMb1Zr?=
 =?utf-8?B?cmpZSW5paFREdCtOVnlIYXRZY1hEbXZDa1pFcjhHRS9laUc1anYzRE9GUTNL?=
 =?utf-8?B?UE5xUXdkUFBWZlk3bENqUDRuSEVZYkxHVEY2bjlEVW13VHNDVC95a0RLQzVZ?=
 =?utf-8?B?TEhaVEd1L0FMd2ttYWc3c0NxYzZmMVEzbkE0U2R0bm9NNXJFTFpVZFY3ZEUz?=
 =?utf-8?B?L05uSXNFN2Q3eTJXZDhFN2F6MTJKOUhoWmFlSlcrekF0NlpjUGJSZks0L3lD?=
 =?utf-8?B?R1FxVUNJQkx5LzJEZUo3bXlaeWhya1pvQ2JXZ20vbXVGVjdmbjRNbkUwa0xI?=
 =?utf-8?B?dWdGeTdNS212RTJmeitRcVBvdnhrSDUrdGN5TXgzQnFaSjQ3dnpjMXV6ZFNT?=
 =?utf-8?B?MXNtTmwybHRGb1RHUDN0TXZkMlFodXBLTmlhaVVEQXlsaVR3ZERkVkVzb2tD?=
 =?utf-8?B?OUhMaWFETXozck14NUtmTTcrVXFLbTYvaGhNSmVwUEFQQ00raHdXb3kxd04y?=
 =?utf-8?B?V09JSTdMQW53M3JsVlYvbUpCK2xiWCtJbVl0ZTgrdU5PQ0tWd2w2Rm5PRWxl?=
 =?utf-8?B?Y2ZhR3VXbll5ditZMHFEVThTRkJGYjhVMDNaYjhOcWszQjVvTHdvWUNacHFa?=
 =?utf-8?B?K0dOa1ZjeW0wQ1VzOUFDaTNISU9aaHphK1RIZWUvdVMwTTNlS1ptZncrczVJ?=
 =?utf-8?B?MVZLc3lKVEdxU0QxYlVjTlplUmZOR2xiQi9FODFxSndMcXppMUpNQlFaS3pv?=
 =?utf-8?B?Kzg2RFlaK3hvNHM1TFRKUjg4UGsxSFQ2dzVlOG92YnpYMndoa2liSUgyR1Q4?=
 =?utf-8?B?alNZL1h1c2E2RndaRE4ydDFxUjNyMy9CKys0Q0NEdEU4b2pJZCtBd1B4ZEhF?=
 =?utf-8?B?UlpTMzJ2bk1lRk8wNGpkRkYySUlDL0RDVVJiMjNMZk50U04xWXZVL3B1eGFJ?=
 =?utf-8?B?QnQ2RE50dXJLZEpYSE9Fc2pHSVl1M1NXdndyeXRhRUlwOGR0QmhoMG1hMzBQ?=
 =?utf-8?Q?Ge9JfyEvjrmg+bz9BU77pW5By?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80d2c3c2-e896-4b21-359d-08dbb8e33122
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6165.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 07:36:52.8421
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dpw3r+763tZLqCoYwrGG43aJq/A128gXp0IYUNBI+lY7NQ8A6aRPLCMKnD66GQMR5bivcMdCHA67ryBtFYn0Nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7440
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 19 Sep 2023 00:37:15 -0700 (PDT)

Hello Doug,

Sorry for delay in response.

On 9/18/2023 3:13 AM, Doug Smythies wrote:
> On 2023.09.17 15:17 Doug wrote:
>> On Fri, Sep 15, 2023 at 2:31 PM Mario Limonciello
>>> On 9/15/2023 16:15, Doug Smythies wrote:
>>>> On 2023.09.15 03:41 Swapnil Sapkal wrote:
> ...
>>>> Not really related, but for a few years now I have been meaning to
>>>> change the minimum python version prerequisite to >= 3.0 and
>>>> to change the shebang line.
> ...
>>>   Besides the shebang, you should also
>>> use a helper like 2to3 to look for any other changes.
> 
> Hi Mario,
> 
> I was not aware of the 2to3 helper.
> Thank you mentioning it.
> The 2to3 helper only changed one line,
> which I included in the minimum python version
> patch I just submitted.
>
I tried with installing python3-gnuplot and it worked for me. Initially I
tried with other packages in prerequisites and it didn't worked for me.

I will send v2 removing this patch.

>> I already did the python 3 patch in January, 2020:
>> commit e749e09db30c38f1a275945814b0109e530a07b0
>> tools/power/x86/intel_pstate_tracer: changes for python 3 compatibility
>>
>> I haven't had any issues since, shebang aside.
> 
> ... Doug
> 
> 
--
Thanks and Regards,
Swapnil