Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp607130rdb; Tue, 19 Sep 2023 05:23:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFI4z7igWDmq12JBtaUMuJJN+77ugh9OsjjhHtPPNSwqScMBGMP/TG1+5NcjkyxKVBcw65h X-Received: by 2002:a05:6a21:4849:b0:14e:43b0:5f99 with SMTP id au9-20020a056a21484900b0014e43b05f99mr9885057pzc.52.1695126237518; Tue, 19 Sep 2023 05:23:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695126237; cv=none; d=google.com; s=arc-20160816; b=UDmAjqFz0vRZrO/c8kwNw+UZiXq9yYl+3cxlO7jT9PZqFcRMCfF2fV+kYIniJ1BeqC Aye9mAzs6bL41RgP12HROIvCYGv2BQEdRwCCRA9lYnnd6dX9l9cJzken1dPfUACd19hT 96ZY5AXpQdIRNIRSVjP1fBqAj07vP5OvWqQWtjnr1I1cd+WS69Xv62d9KxyeGck+m6H/ domVoxYj3K4qMSozhXuAtUTXI4ETTnSsAyCPeoZGysBMjIdkmhxVggsiRcU/3bfQnAJw vSCQZJ6SiYiiSFYhoRSJBPx8hA6uBHt8tW0bwb9/7mdIDcOPL1PnYQCAWkSyBeO6GzD3 V76A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tje9YLMxxkFSnmibjgX8pdwsuV260G7/yaQu3eL6n9g=; fh=7Vee66JLxxGmGenkzrmjyg0LnC8kwM2U+7GSEky39bY=; b=j4Vy2JuKeZUOZOPZ6fLmfE5wh88zk+GFM0ZdZwg7Oo5bGJB5g5deXJPkLe0ulhu44S eDm86mxD0OjGP18zK/FHfXDAwsAYIxlSnTTrxm0r2Mfj8AYmQZt9SKBa+3X36SY0zVo7 BhrfZ4J/557M5o3n/zplQGRFiwHVU8QwUCq2lfOU3qMIbSkvyC6YZUsKULsP+YsY+BCu xPEGDJXf7Otr+DN1wFu/4CKSWDPv3MvyTD/MU/+SWThH1lmaxiVoPpasrNBaCYVcBpSl u4fhiTANrbjKOaqpfr5uEsGrJQcd/3Yee0F+/ORbEgufLxD8j8kUu2278BjD2Qwn4uvB ah1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WjtUmVDn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id fb20-20020a056a002d9400b00686e01db946si9892990pfb.64.2023.09.19.05.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 05:23:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WjtUmVDn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6FAB58129AE5; Tue, 19 Sep 2023 05:14:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbjISMOJ (ORCPT + 99 others); Tue, 19 Sep 2023 08:14:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjISMOH (ORCPT ); Tue, 19 Sep 2023 08:14:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE17A118; Tue, 19 Sep 2023 05:14:01 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0504C433C8; Tue, 19 Sep 2023 12:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695125641; bh=dauXQLkstRtCzMJMb/trFr2w1LvhwGBSPPyfgMFurg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WjtUmVDnQuu+bFgm6br3V1WI5C2NapYx3u5HXEhzpdX0dfJp55l9KvXOmpoadJyAn zGl4fHyNp9Vd80LIMc/WMTRx2CFXofx4jpaAUN789waSxmED5pf9ojHKv4ZanOOmzd 3Oyt14g4l7A+5Sk9jF+6gw8DqxwC6/98G8yvIv+L4jn8MIr5WI6u+I/lanWE8AGQ5I /rOq3J9CX0ZvqIEvV4z5S3HwyZyZk5D4V0DbEbMRXccagXtc2SoX/wzNdnAA26zEjF 15GMMqTfKNqFhaO0rxFFONkXxMmlQmcFrOCRqaXHpOpQhqzCAkokz5bd7Cdodq+kB5 YZUp0M2v19Igw== Date: Tue, 19 Sep 2023 14:13:55 +0200 From: Shawn Guo To: Christophe JAILLET Cc: Daniel Baluta , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Daniel Baluta , Paul Olaru , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels() Message-ID: <20230919121354.GA11740@T480> References: <2b4bc0b22fac32ab3a7262240019486804c1691f.1673806409.git.christophe.jaillet@wanadoo.fr> <022417df-9d3b-6760-3a57-c725906561e5@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <022417df-9d3b-6760-3a57-c725906561e5@wanadoo.fr> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 19 Sep 2023 05:14:07 -0700 (PDT) On Sun, Aug 20, 2023 at 08:26:01AM +0200, Christophe JAILLET wrote: > Le 17/01/2023 ? 08:55, Daniel Baluta a ?crit?: > > On Sun, Jan 15, 2023 at 8:35 PM Christophe JAILLET > > wrote: > > > > > > If mbox_request_channel_byname() fails, the memory allocated a few lines > > > above still need to be freed before going to the error handling path. > > > > > > Fixes: 046326989a18 ("firmware: imx: Save channel name for further use") > > > Signed-off-by: Christophe JAILLET > > > > Good catch. > > > > Reviewed-by: Daniel Baluta > > > > Hi, > > polite reminder. > > This patch is still not in -next. Sorry, not sure how this fell from the crack. Applied, thanks!