Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 19 Sep 2023 13:13:02 +0100
From:   Andre Przywara <andre.przywara@arm.com>
To:     =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Peter Rosin <peda@axentia.se>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Paul Barker <paul.barker@sancloud.com>,
        Michal Simek <michal.simek@amd.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm: dts: replace Bananapi with Banana Pi
Message-ID: <20230919131302.26c30a31@donnerap.manchester.arm.com>
In-Reply-To: <20230918074122.73265-1-arinc.unal@arinc9.com>
References: <20230918074122.73265-1-arinc.unal@arinc9.com>
Organization: ARM
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, 18 Sep 2023 10:41:22 +0300
Arınç ÜNAL <arinc.unal@arinc9.com> wrote:

Hi,

> The brand name is Banana Pi. Replace any mention of Bananapi with Banana
> Pi.

So in general this looks fine, and the comment change is surely a
no-brainer. But I was wondering if changing the model name is something
that should be done, as there might be someone relying on that?
And if we go there: "git grep" finds a number of boards using "Bananapi",
and some others with "BananaPi", so I guess those should be changed then
as well?

Cheers,
Andre.

> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi | 2 +-
>  arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> index 235994a4a2eb..ef532494fc9d 100644
> --- a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> +++ b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> @@ -7,7 +7,7 @@
>  
>  / {
>  	/*
> -	 * Bananapi M2+ v1.2 uses a GPIO line to change the effective
> +	 * Banana Pi BPI-M2+ v1.2 uses a GPIO line to change the effective
>  	 * resistance on the CPU regulator's feedback pin.
>  	 */
>  	reg_vdd_cpux: vdd-cpux {
> diff --git a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> index a37f3fa223c7..7f0948074945 100644
> --- a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> @@ -10,7 +10,7 @@
>  #include "mt6323.dtsi"
>  
>  / {
> -	model = "Bananapi BPI-R2";
> +	model = "Banana Pi BPI-R2";
>  	compatible = "bananapi,bpi-r2", "mediatek,mt7623";
>  
>  	aliases {