Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp620133rdb; Tue, 19 Sep 2023 05:49:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQfTAoPpXyrRkRfiOQ+fVLwP3UQry8KkhQigY32mH81sAjHKNC/khaJAxAGY1cIL0YDyQu X-Received: by 2002:a05:6830:616:b0:6b8:6a83:2b17 with SMTP id w22-20020a056830061600b006b86a832b17mr12822579oti.33.1695127757322; Tue, 19 Sep 2023 05:49:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695127757; cv=none; d=google.com; s=arc-20160816; b=KfI9JHfkbwUVbuUdPq5esFB+Ta3LP3oJ2ivYfsGHf3JObgFeANuvS65JKbMz5JIBr1 W7uZXC27PyCIM7/PMzsI1IUzF/cHV5GEYzJtqNuyqKGqK088ZMpB1KGMxyhY/G/1zJJu WHfcQ1lNZFF2aEYLd8tjOc1BGPqrpd0LbLh/Kiw/y4V8J1FvttfE8R7PymwKIRP4dL4z RiNordA42YOpqmlCdPnqiNzW174bcxZu3bo42UqOzBbWNxoo+/Jp5l9G17GevlQ9ZPcC SLE4ft/knl0uPgluoFCxXCOS+LF9k3e7TXtkS+38LGAlxztyExBtasZu9Rm1bl3GkfsV adfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TVM2FYxk/7KeyC+fYzcQEqMIgLBNOxTRU4V/a4d2ld0=; fh=aWualqhZ1OKxVaSfTexDf/5JzxN6tiwKNL7ZrL5MHZQ=; b=Azi18kV98ECZxmoISOr6IR6ydxiqFyC/t2R9LDYQs3DX+aKJHW2QSQ/cCnC4N8yUKH A1gyHair+MyHxnwCilkKQ9zYmJRWXCJmbLKcmC6x4auacXaqKiv1kDQE7h5wLHPrp/jY iGrPbvlnCItPQkGgyAhHEqKNip5s9wBMpYlk7npNW7eSWkdhMiiivDYmIuLrKNu6pLUX xgueo8MXje9CgoEp8VrTHJwT470BiEZ5uLaosQsFBYZeKF960K1dyUJ6m5JiXgWIWu1b 5s4Us6peIkJExIwf5jj8HzEoOHMnbjk352sazTqRGkfETfjt6iug3MZUEk71HAjV9E4K eeeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ftGqKQL4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id v190-20020a6389c7000000b00565dd3ea771si9340393pgd.137.2023.09.19.05.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 05:49:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ftGqKQL4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0968180BF1D8; Tue, 19 Sep 2023 05:42:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232083AbjISMln (ORCPT + 99 others); Tue, 19 Sep 2023 08:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbjISMlm (ORCPT ); Tue, 19 Sep 2023 08:41:42 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46CF099; Tue, 19 Sep 2023 05:41:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D78A9C433C8; Tue, 19 Sep 2023 12:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695127296; bh=sdNgLMHUaM9EotsLPKRMXdZdUQrg70sPmYa/XAc0bSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ftGqKQL4Xpl9ksEbF9kVIdFF6MC45/9W9MV9ZLGrEGLN3RbD12jnPRc54rGSxjK63 GNAsWaV+cP6dWUHXZrqwbuhZpsxpPpURNCVhH1DHSKgyNpjCFjUXoI7GwmhaQUbsn5 eg3PLHExudRGbYamTZSzZ56fxe8gEIVXloT8armL49S30NLIcooICXsWKt/IJDiBdJ 6z4OSXV1TUgouaw7mq+dEZhu2uL9nuj1xRffJd7ZkbChdnqQMrHqJHCgPnsHbDUK9d 54+4zvEayOJfLjh0Kdsxv6R2OIlVHmWHHT1lk3U7wKkA0gbvSLBO5Ot8hKZyQmVI8P t8TC7i1SN/eWQ== Date: Tue, 19 Sep 2023 14:41:25 +0200 From: Christian Brauner To: Miklos Szeredi Cc: Matthew House , Miklos Szeredi , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-man@vger.kernel.org, linux-security-module@vger.kernel.org, Karel Zak , Ian Kent , David Howells , Al Viro , Christian Brauner , Amir Goldstein Subject: Re: [RFC PATCH 2/3] add statmnt(2) syscall Message-ID: <20230919-hackordnung-asketisch-331907800aa0@brauner> References: <20230918-hierbei-erhielten-ba5ef74a5b52@brauner> <20230918-stuhl-spannend-9904d4addc93@brauner> <20230918-bestialisch-brutkasten-1fb34abdc33c@brauner> <20230919003800.93141-1-mattlloydhouse@gmail.com> <20230919-abfedern-halfen-c12583ff93ac@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 19 Sep 2023 05:42:10 -0700 (PDT) > > with __u32 size for mnt_root and mnt_point > > Unnecessary if the strings are nul terminated. All ok by me so far but how does the kernel know the size of the buffer to copy into? Wouldn't it be better to allow userspace to specify that? I'm probably just missing something but I better ask.