Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp662281rdb; Tue, 19 Sep 2023 06:51:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGA2gzTKntIkpXf+dZynjASbe9HBn5q2gwPR7sff29dhifxdn4bvAwC2/Eayne/0keJ4IdC X-Received: by 2002:a17:902:dac7:b0:1bf:4582:90d with SMTP id q7-20020a170902dac700b001bf4582090dmr16827964plx.46.1695131484704; Tue, 19 Sep 2023 06:51:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695131484; cv=none; d=google.com; s=arc-20160816; b=ttyseW+6L4ea/S+1RrI4G1WpOASAUNwN7AgIzs0xTmGGnH1ypklEWUag2ZYxd3fW8b UfMdw6zHznfUE9qAnXKwfFblNgLuSp/EtFSOtKGKVssWDdiNmhQcgLTswQTRoPoHktvI /aTctprxF2jRqHvXSUoYenUakE0u6RrFOA0AU5DCDCujX8FzoXplqPtw73RFdso1tZND 1Z7kvm7Bycp+z3VWX5QxfzRqfL6DK+S7ZKks5vzlSbFwulJONATCAcqAyxKJOpP1O5WW L3fLkuqiYmvS+GNeMDLh1SiCBBZi2Nb6Z8fmV3M6wbE5p8sYjQG7BM+0Fyu924fuYOr5 k7xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=j2kEwsY0+Vzfn3VUWtkJAbzSF4wIILlsd1ibkT+QvMU=; fh=rvfjkWKWQ7H3dxwU/Mrzlf1SBsZ3Tuo/EBElQFetDNM=; b=o3xHgu1QcSFP+KLDqyuGd5IB7SKQPt1IkjAtPXvqiVwJjUPE5WZKioUfIcjUkf66t9 HWB35+T5ZqZHu4ItXxexqQMwBkQATRH223P4BDg3dliSPtZQTV+1qG0nT0rukk5uckIH QGyoiDqQi7Ziv1yJa10DP9mQM+gEwLl4UTRc59Q45OVKJ8WglzEnem6fh5aaSzyfzSpP 1fJBxn2sMLSum1xkl0wghwWdAuhHtffTKkrtmGVnVk22zpptlZW+0Y1z6+IeQzzo11dZ FX4TZ01SrkZB9aTMhbj7f6IIuDyYvvuc7k9AedUhb+hgCr/EyDb/AvZzEOPCq6qjTEu3 cFuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id b12-20020a170902e94c00b001bc553d16e0si9853178pll.507.2023.09.19.06.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 06:51:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D5328806AA28; Tue, 19 Sep 2023 06:42:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232475AbjISNmW (ORCPT + 99 others); Tue, 19 Sep 2023 09:42:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232400AbjISNmK (ORCPT ); Tue, 19 Sep 2023 09:42:10 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4919F1; Tue, 19 Sep 2023 06:42:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE1FFC433C7; Tue, 19 Sep 2023 13:42:00 +0000 (UTC) Message-ID: Date: Tue, 19 Sep 2023 15:42:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 22/49] media: i2c: Stop direct calls to queue num_buffers field Content-Language: en-US, nl To: Benjamin Gaignard , mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, ming.qian@nxp.com, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, nicolas.dufresne@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, kernel@collabora.com References: <20230914133323.198857-1-benjamin.gaignard@collabora.com> <20230914133323.198857-23-benjamin.gaignard@collabora.com> From: Hans Verkuil In-Reply-To: <20230914133323.198857-23-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 19 Sep 2023 06:42:49 -0700 (PDT) On 14/09/2023 15:32, Benjamin Gaignard wrote: > Use vb2_get_num_buffers() to avoid using queue num_buffer field directly. > > Signed-off-by: Benjamin Gaignard > --- > drivers/media/i2c/video-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c > index 537ebd9fa8d7..60d3e2f35afe 100644 > --- a/drivers/media/i2c/video-i2c.c > +++ b/drivers/media/i2c/video-i2c.c > @@ -406,7 +406,7 @@ static int queue_setup(struct vb2_queue *vq, > struct video_i2c_data *data = vb2_get_drv_priv(vq); > unsigned int size = data->chip->buffer_size; > > - if (vq->num_buffers + *nbuffers < 2) > + if (vb2_get_num_buffers(vq) + *nbuffers < 2) > *nbuffers = 2; > > if (*nplanes) This driver sets min_buffers_needed to 1, then checks for 2 here. Drop the check and instead set min_buffers_needed to 2. Update the commit log accordingly. Regards, Hans