Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <de5568cc-b710-ae56-710b-92eaa4fc09e8@kernel.org>
Date:   Tue, 19 Sep 2023 15:56:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] rtla: fix a example in rtla-timerlat-hist.rst
To:     Xie XiuQi <xiexiuqi@huaweicloud.com>, rostedt@goodmis.org,
        corbet@lwn.net, linux-trace-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     bobo.shaobowang@huawei.com
References: <20230919133028.697144-1-xiexiuqi@huaweicloud.com>
Content-Language: en-US, pt-BR, it-IT
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <20230919133028.697144-1-xiexiuqi@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/19/23 15:30, Xie XiuQi wrote:
> From: Xie XiuQi <xiexiuqi@huawei.com>
> 
> The following error message is reported when running the example in document.
> 
>   # timerlat hist -d 10m -c 0-4 -P d:100us:1ms -p 1ms --no-aa
>   Failed to set timerlat period
>   Could not apply config
> 
> The unit of the period is microsecond, '1ms' cannot be accepted.

right, but we could also parse the -p accordingly, no?

as well as the -r for osnoise and hwnoise... and other
us only parameters....

>   usage: [rtla] timerlat hist [-h] [-q] [-d s] [-D] [-n] [-a us] [-p us] [-i us] [-T us] [-s us] ...
>          ...
> 	  -p/--period us: timerlat period in us
>          ...
> 
> Also fix another minor missleading comment.
> 
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>