Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 19 Sep 2023 11:04:46 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Alexander Graf <graf@amazon.de>
Cc:     David Woodhouse <dwmw2@infradead.org>, kvm@vger.kernel.org,
        Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenz@amazon.es>,
        "Griffoul, Fred" <fgriffo@amazon.com>
Subject: Re: [RFC] KVM: x86: Allow userspace exit on HLT and MWAIT, else
 yield on MWAIT
Message-ID: <20230919090446.GC21729@noisy.programming.kicks-ass.net>
References: <1b52b557beb6606007f7ec5672eab0adf1606a34.camel@infradead.org>
 <63b382bf-d1fb-464f-ab06-4185f796a85f@amazon.de>
 <b3c1a64daa6d265b295aedd6176daa8ab95e273f.camel@infradead.org>
 <db756c13-eee5-414a-a28d-2ce08e7b77d9@amazon.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <db756c13-eee5-414a-a28d-2ce08e7b77d9@amazon.de>
Precedence: bulk

On Mon, Sep 18, 2023 at 01:59:50PM +0200, Alexander Graf wrote:
> The problem with MWAIT is that you don't really know when it's done.

This isn't really a problem. MWAIT is allowed (expected even) to return
early.

REP;NOP is a valid implementation of MWAIT.

MWAIT must not delay waking (much) after either:

 - write to monitored address
 - interrupt pending

But it doesn't say anything about not waking up sooner.

Now, obviously on real hardware you prefer if MWAIT were to also do the
whole C-state thing and safe your some actual power, but this is virt,
real hardware is not a concern and wakeup-timeliness also not much.


IIRC the ARM64 WFE thing has a 10khz timer or something it wakes from if
nothing else. So I suppose what I'm saying is that: nanosleep(100000)
might be a suitable MWAIT implementation.

It's virt, it sucks anyway :-)