Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 19 Sep 2023 11:31:57 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Edward AD <twuufnxlz@gmail.com>
Cc:     eadavis@sina.com, jirislaby@kernel.org,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com,
        syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] tty: fix memory leak in gsm_activate_mux
Message-ID: <2023091921-duke-gory-866e@gregkh>
References: <2023091922-unplug-flask-f2e5@gregkh>
 <20230919092225.3732786-2-twuufnxlz@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230919092225.3732786-2-twuufnxlz@gmail.com>
Precedence: bulk

On Tue, Sep 19, 2023 at 05:22:26PM +0800, Edward AD wrote:
> On Tue, 19 Sep 2023 10:29:08 +0200 Greg KH wrote:
> > > When the call to gsm_register_devices() fails, we need to reclaim the memory
> > > requested in gsm_dlci_alloc().
> > >
> > > Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open")
> > > Reported-and-tested-by: syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com
> > > Signed-off-by: Edward AD <twuufnxlz@gmail.com>
> > 
> > Please use your company name/email address, and then just set a manual
> > "From:" line as the first line in the changelog as the documentation
> > asks.  That's how developers work around their broken corporate email
> > systems (but really, you should go and poke your IT group to fix it.)
> This repair was completed in my personal time. Additionally, there may be a 
> possibility of the company's email being thrown away by 'lore.kernel.org'. 
> If you are not very strict with this, I will continue to use my private email.

As you previously submitted this under your company name/address, we
have to be strict for obvious reasons, sorry.

> I will only keep one line starting with 'From:' in the patch.

I don't understand what you mean by this.

greg k-h