Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp701372rdb; Tue, 19 Sep 2023 07:50:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqcNdqHayFbBi/WO3I2wUQVMFoUutVInRimpueUZJY5VUFQLNAYlsFQIn4M9Vl5BEdXsLg X-Received: by 2002:a17:903:11c8:b0:1c3:e30f:6c82 with SMTP id q8-20020a17090311c800b001c3e30f6c82mr12001381plh.53.1695135013034; Tue, 19 Sep 2023 07:50:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695135013; cv=none; d=google.com; s=arc-20160816; b=fK50vIHIL1KcfGReLhYEaOGkzsG5Kr4TBxjTnNIhIwgoje5qqcxi1CVWENHqKZcz6A heY5WFd6E7YmOjxskUOxs8xXyJ4RT69Tw7K/f6fIbbuQIp5NaW9F5GedZHuJRS1i8a+G XPnC+5ld8joQTqlIfNH2jKte5dD3sVb8Xtn5HF9MP3TO+jA1nABqFEgZt3s7IDjMp/Q1 5ptEqxloTs3AoFb6nN+cRdGzhWUPWbxebcrBqHHYwx1CuA7TH9pK0hk3xEqL4t1uxojl ASbuwSr2FCVOZxN3e6EgNr+G6wsMxZr0AEYiv0Ytu64DjVb8f6OWm+8U/rjaevsua/gH ogDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VncnnhJmc8PsU0ruYP9H8J/d7HOU/JkrH5FEC5hhYfI=; fh=aVJKnREZOg2XLhmUlQkbgscHvQVkot5ZlDSuOcAblpU=; b=J+sbF6Mh4+gbUZA8q8gsL1T+vhxFjjXsnpyqV62qVoJUUVPIEyqSAC0PWrXLB+uPA6 AD/kOKcx2rkSNaUut5NXvJ40q/h8LW4QWN8J7bVKL9zMl+5lVgwk3u4m6qS6SXPbn6kz SnCjCVrAp4HJK+AYng6FVDAJVQl349tVbN3bCJqyqfGJKU+JJv9af8OBCRnqm3GJxO/n Kfi0FmomBbeAIAzbVh0g1xy/+dfPe/gZcpl/IosMJ77VZbkz0lS8Tu9sW2AFNNw/ZiOp qjCLWSvzpavgIWBtPiu24tXt36rj4tctX/0m7njYkk1Rh0wfaqbVr5O+iNaYYxi27FeC qFug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=nY5fCyJs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id d1-20020a170903230100b001c224748a65si9970360plh.476.2023.09.19.07.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 07:50:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=nY5fCyJs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 17ACA802DD15; Tue, 19 Sep 2023 07:26:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232813AbjISO0c (ORCPT + 99 others); Tue, 19 Sep 2023 10:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232804AbjISO0a (ORCPT ); Tue, 19 Sep 2023 10:26:30 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 603EFF7; Tue, 19 Sep 2023 07:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VncnnhJmc8PsU0ruYP9H8J/d7HOU/JkrH5FEC5hhYfI=; b=nY5fCyJsDEElTaGCYnh8i/NEA5 CFMU0X1ing7uHiVoZSIDlH6e9DPZQcxX5mzviYpFmt/x1/mPgJZDxlUuX4oI+5NzqwUdK87aP9wcm zdP5V7h3lcazZ3jjEwjrmd/sxuc/McSa1luT/D06mztTkKIgU8t3kZGIZGMY08EW0IY7zM2dgUsOx D4KtFCR9S3A2QqghlqdTAGaHioDYOhuV58+G7bPj1MzzXw7sGndLoBrVCX5+2Uxb9KI2jIZHfgyGO yY+lKYS/FTao9tnpuoByRcVqaOOU0UBZbkxeb4lEkD+ZV+QqL8FZOWXs74i+O/mtOvPlYFClpIgoJ bIf+WLww==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qibg4-0005zv-Ma; Tue, 19 Sep 2023 14:26:12 +0000 Date: Tue, 19 Sep 2023 15:26:12 +0100 From: Matthew Wilcox To: David Laight Cc: Greg Ungerer , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "torvalds@linux-foundation.org" , Nicholas Piggin Subject: Re: [PATCH 09/17] m68k: Implement xor_unlock_is_negative_byte Message-ID: References: <20230915183707.2707298-1-willy@infradead.org> <20230915183707.2707298-10-willy@infradead.org> <6e409d5f-a419-07b7-c82c-4e80fe19c6ba@westnet.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 19 Sep 2023 07:26:31 -0700 (PDT) On Tue, Sep 19, 2023 at 01:23:08PM +0000, David Laight wrote: > > Well, that sucks. What do you suggest for Coldfire? > > Can you just do a 32bit xor ? > Unless you've got smp m68k I'd presume it is ok? > (And assuming you aren't falling off a page.) Patch welcome.