Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <3f79b0d4b9409a223f03c0b36b3544ce1389a500.camel@redhat.com>
Subject: Re: [PATCH 4/4] net/onsemi: Add NCN26010 driver
From:   Paolo Abeni <pabeni@redhat.com>
To:     Jay Monkman <jtm@lopingdog.com>, Andrew Lunn <andrew@lunn.ch>
Cc:     devicetree@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
        Arndt Schuebel <Arndt.Schuebel@onsemi.com>,
        Parthiban.Veerasooran@microchip.com
Date:   Tue, 19 Sep 2023 11:47:30 +0200
In-Reply-To: <ZQkNfAOYgsBIhBRW@lopingdog.com>
References: <ZQf1QwNzK5jjOWk9@lopingdog.com>
         <6e19020f-10ff-429b-8df3-cad5e5624e01@lunn.ch>
         <ZQkNfAOYgsBIhBRW@lopingdog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-09-18 at 21:54 -0500, Jay Monkman wrote:
> On Mon, Sep 18, 2023 at 06:00:37PM +0200, Andrew Lunn wrote:
> > Is this an OA TC6 device?  At a quick look it does appear to
> > be. Please make use of the framework Microchip is developing:
> >=20
> > https://lore.kernel.org/netdev/20230908142919.14849-4-Parthiban.Veeraso=
oran@microchip.com/T/
>=20
> Yes it is. I wasn't aware of Microchip's work. Thanks for pointing it out=
.

I guess this patch is going to change a lot in future revisions...

Please double check the code with checkpatch before the next
submission, there are a few things that could be improved.

Specifically, avoid c++ style comments, and avoid using multiple label
names to jump into the same location - selecting the label name as the
target action will make the code more clear.

Thanks,

Paolo