Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 19 Sep 2023 13:17:49 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/15] random tty fixes
In-Reply-To: <20230919085156.1578-1-jirislaby@kernel.org>
Message-ID: <6f7b65a8-bc9c-83d2-13c9-a56d85616b53@linux.intel.com>
References: <20230919085156.1578-1-jirislaby@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-85316023-1695118627=:1920"
Content-ID: <8751c2-6ac4-be6-4791-191036869597@linux.intel.com>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-85316023-1695118627=:1920
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID: <f1e8e3ff-69ed-b7aa-f0ac-aff5809ca27@linux.intel.com>

On Tue, 19 Sep 2023, Jiri Slaby (SUSE) wrote:

> This is a collection of random fixes for tty I did while crawling
> through the code. Mostly done for readability and understandability. No
> behavior change intended (except for Documentation fixes).
> 
> Jiri Slaby (SUSE) (15):
>   tty: n_tty: use 'retval' instead of 'c'
>   tty: n_tty: rename and retype 'retval' in n_tty_ioctl()
>   tty: n_tty: use min3() in copy_from_read_buf()
>   tty: n_tty: invert the condition in copy_from_read_buf()
>   tty: n_tty: use do-while in n_tty_check_{,un}throttle()
>   tty: switch tty_{,un}throttle_safe() to return a bool
>   tty: invert return values of tty_{,un}throttle_safe()
>   tty: fix up and plug in tty_ioctl kernel-doc
>   tty: fix kernel-doc for functions in tty.h
>   tty: stop using ndash in kernel-doc
>   tty: tty_buffer: use bool for 'restart' in
>     tty_buffer_unlock_exclusive()
>   tty: convert THROTTLE constants into enum
>   tty: early return from send_break() on TTY_DRIVER_HARDWARE_BREAK
>   tty: don't check for signal_pending() in send_break()
>   tty: use 'if' in send_break() instead of 'goto'
> 
>  Documentation/driver-api/tty/index.rst     |   1 +
>  Documentation/driver-api/tty/tty_ioctl.rst |  10 +
>  drivers/tty/n_tty.c                        |  77 ++++---
>  drivers/tty/tty.h                          |  13 +-
>  drivers/tty/tty_buffer.c                   |   5 +-
>  drivers/tty/tty_io.c                       |  36 ++--
>  drivers/tty/tty_ioctl.c                    | 234 ++++++++++-----------
>  drivers/tty/tty_port.c                     |   6 +-
>  drivers/tty/vt/consolemap.c                |   2 +-
>  drivers/tty/vt/vc_screen.c                 |   4 +-
>  drivers/tty/vt/vt.c                        |   4 +-
>  include/linux/tty.h                        |  25 +--
>  12 files changed, 209 insertions(+), 208 deletions(-)
>  create mode 100644 Documentation/driver-api/tty/tty_ioctl.rst

For this whole series except the patches I commented on:

Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>

...If you make the amendments I requested, please add the tag also to the 
patches I commented on.

-- 
 i.
--8323329-85316023-1695118627=:1920--