Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 19 Sep 2023 16:24:09 +0100
From:   Lee Jones <lee@kernel.org>
To:     Biju Das <biju.das.jz@bp.renesas.com>
Cc:     linux-kernel@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3] mfd: max77541: Simplify probe()
Message-ID: <20230919152409.GZ13143@google.com>
References: <20230831185329.70472-1-biju.das.jz@bp.renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230831185329.70472-1-biju.das.jz@bp.renesas.com>
Precedence: bulk

On Thu, 31 Aug 2023, Biju Das wrote:

> Simplify probe() by replacing device_get_match_data() and ID lookup for

There are hundreds of ways to "simplify probe()"

Please collect all of these MFD related patches and provide a better
subject line that easily identifies the changes.

For example, I just applied one of your earlier patches as:

  mfd: max8997: Simplify obtaining I2C match data and drop max8997_i2c_get_driver_data()

... but I don't have enough spare cycles to fix them all up.

Feel free to use this description or come up with something better.

Please post them all in one set - else they end up spread all over my inbox.

> retrieving match data by i2c_get_match_data().
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---


-- 
Lee Jones [李琼斯]