Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <56a4a085-6b1d-19c6-4160-4513c8c41e57@gmail.com>
Date:   Tue, 19 Sep 2023 12:46:34 +0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2 2/2] ALSA: Add new driver for Marian M2 sound card
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     perex@perex.cz, tiwai@suse.com, corbet@lwn.net,
        alsa-devel@alsa-project.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230918181044.7257-1-ivan.orlov0322@gmail.com>
 <20230918181044.7257-2-ivan.orlov0322@gmail.com>
 <2023091955-dried-popsicle-f3d8@gregkh>
From:   Ivan Orlov <ivan.orlov0322@gmail.com>
In-Reply-To: <2023091955-dried-popsicle-f3d8@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/19/23 12:04, Greg KH wrote:
> On Mon, Sep 18, 2023 at 10:10:44PM +0400, Ivan Orlov wrote:
>> +
>> +#define DEBUG
> 
> Do you mean to have DEBUG enabled at all times?  Shouldn't this be a
> runtime issue with the normal dynamic debug infrastructure?
> 
> thanks,
> 
> greg k-h

Hi Greg,

Yeah, I was experimenting with dynamic debugging and I've just forgotten 
to remove it... I'll be more attentive next time :(

By the way, is there any way to detect such issues automatically? I've 
seen that the kernel test robot detects a lot of similar stuff, perhaps 
there is any tools/linters which can be set up locally?

--
Kind regards,
Ivan Orlov