Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 19 Sep 2023 17:02:01 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-renesas-soc@vger.kernel.org,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: rcar: add FastMode+ support for Gen4
Message-ID: <ZQm36a4IhPL9kN+g@shikoro>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-renesas-soc@vger.kernel.org,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Andi Shyti <andi.shyti@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230913203242.31505-1-wsa+renesas@sang-engineering.com>
 <20230913203242.31505-3-wsa+renesas@sang-engineering.com>
 <CAMuHMdWrb2je4tgEO_OmXhHtFiRb8JfUzBJdUp4KFf574GmoVA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vVCqwtsTzpx3t2Sh"
Content-Disposition: inline
In-Reply-To: <CAMuHMdWrb2je4tgEO_OmXhHtFiRb8JfUzBJdUp4KFf574GmoVA@mail.gmail.com>
Precedence: bulk


--vVCqwtsTzpx3t2Sh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > +               /* FM+ needs lower SMD and no filters */
> > +               priv->smd /=3D 2;
> > +               cdf =3D 0;
>=20
> Is this documented somewhere in the R-Car Gen4 docs?

Sadly, there are no recommended values for FM+ in the docs. With cdf=3D6,
I got speeds around 800kHz. After seeing the BSP also uses cdf=3D0, I got
speeds close to 1MHz. There is a note in Gen3 and later docs for ICCCR2
saying that cdf=3D0 is recommended for devices with a data hold time less
than 100ns. I don't have the PMIC docs here to verify if that is the
case here.

However, I recalled there are some generic filter bindings for I2C. I
will check if we can make use of them here.


--vVCqwtsTzpx3t2Sh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmUJt+kACgkQFA3kzBSg
KbbD6xAAsU8C+txBnNyPnyuIDx6ppzSmC+V+hfzW2+2Ke7nbqQIhwOQwerj9Ysg1
xEsetQ/KNQhK6pX7ueWVsi0YcnOYdzHzcTeYy9XfL9GuHcSr8UFFu31K1U4+WI6l
DQBRPGlOEfGvJb/nICt06r0WYBbFR73HF9z6sjfJH+lCADk85qiiL4Wt5gyzPW5X
QBowLweliHUszj5g9SGTy5qBDE92fi+u05wbpuCNMXeFZNry5el6fHLrc0y/J+Ex
6Kcckld/vy9KqVZ13d7irgbU5cxPaoR3zcYHSGurCZXg2r129RII/HCwmbJIObP2
zLPVkgSCP+xaZNz7VSsU9ii5OzFDPDWaoeMtK+mYGKkgxfT4PSk42RWF9oAkHTGr
0bh47pdqo1Nfdj1QEXcPHv8Z2CRbnt4j0lqne2e3ND15JsCLOxDPRebOthkgY8c6
Mz8o5mubMEZha2uNRGrMKy+NdkC1i59ibY7CV0PyYmAA+eYwa+ww+gmV2BOnrMB8
EL++7DT1sgT8niFss4sd1J+B8LYYwUj4aYTRTU0gAdNTghZk4KaNAgfozo8PHoIR
6i5I/8bRMnRT0QIgwAxvRPOiyrfpBRhYK0rPF3lwpYOnM8ckAagUQTxDVwKr0UYp
fHJRA82b7wc4bJWs7xjRCOuLqgx/2eJbiNVlYQ1av4wtyA2FI4A=
=J32p
-----END PGP SIGNATURE-----

--vVCqwtsTzpx3t2Sh--