Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp798099rdb; Tue, 19 Sep 2023 10:23:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtBUCFPEEUiSSbtYuIuqGZ/pVFpnKnYlxm0wZDhV1kfdoRJxCVF9C/omjLXrrBpwHixets X-Received: by 2002:a05:6a21:a588:b0:153:a00b:dca0 with SMTP id gd8-20020a056a21a58800b00153a00bdca0mr252109pzc.11.1695144183668; Tue, 19 Sep 2023 10:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695144183; cv=none; d=google.com; s=arc-20160816; b=FL724IQblAf/RG3vjMK9hnebgpXbSCaFyNu3rciWwOhojOadD0ZvkQcg3k0adLSlCk S9ByCxmw0H+qgvVieKG2v6A3J1zCITHDyWNx/RlD20kPjmb/bLFYtcWNLksfnImJDDud SAXqJlG1YYQICkJDx+LpgzkBWiTo49uILHSJkOBNWPqU5vAyyGPJ1gpdvYF6RD40Nyy6 ENRSJtux6bYqTW+xbJYcK2aeYlZpu59dB+xM35BoVkn3Lcu547eVdQPQ8cvKcYZbr20c bvWxQhPLAZV5tAl/n5V/BQ0vxd6wGQP1tddsOYZICHUuYUiyRdhELdTAB7Q9An2XG7jd 0NJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:organization:in-reply-to:subject:cc:to :from:dkim-signature; bh=uELnytT+CuvLOJY3ZLfkVdcq80klKvGzS1iwGb1zs7A=; fh=GMbKJv29bUcojp3Y8uVxCLCFM4Ycx0LfyuEhUBRRQzo=; b=Vv85bfYywmJqIbeKuvFC6hMNej+LFOkZsZ6RAdO1T8DzhcSPlxuDEa7xTWvPWqSdsv fm6SYjDyVv/QTvCWotKvFtzyxXQu0GgRoEt4UTM1ph3jn0+tL02FzQQ/W8wqVaoXqO1t v7zJONAoeaUrUVaUUGYPzrDv/2EcPNEHXWBxJ0rDpniTutNTw2rH42Tk/zKWsOqwnBpF wdY4gjAF3wrKidE1W2xDC2yg3/oOgrX1ML4h5HCbjt2f3quAQZGUxIyhb8C2I+OwI5pJ FJT1R/Q9sJmSIeGYWdUzRN9S1YVz6tDPxs1lCrpSj6IGnz8sbbfeHcKRkbEtZR5NAdBj 9bFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=i6P4oO+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id be10-20020a056a001f0a00b0068a692b67b0si10061124pfb.104.2023.09.19.10.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 10:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=i6P4oO+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2E0AE818F676; Tue, 19 Sep 2023 04:02:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231812AbjISLCj (ORCPT + 99 others); Tue, 19 Sep 2023 07:02:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbjISLCi (ORCPT ); Tue, 19 Sep 2023 07:02:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2163E3; Tue, 19 Sep 2023 04:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695121352; x=1726657352; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=uELnytT+CuvLOJY3ZLfkVdcq80klKvGzS1iwGb1zs7A=; b=i6P4oO+rfr4V3iRxa0OAAHKAiTmYDi/hRpijKgl9rmnyPZr14pJ0ybeK 6jF+a/wswwiJT+h9wUCWB8msagty08WAdua2WwMX0Rio+YI+F90c8SDjw 4UTchxUFLCs+vdWB9JFsDGL2GNzB3uVLHMS7dpPhHEL1EFuNbmwwvlxy5 jUr2SfVhUT9et06QQT6rH08sxIIxkaee2XYxay0MJ8SREooMnAgWqGRT7 jtk0Fslez2EcBAn/iSPNyKHCGW34N8UIU+EJG3KeUQ9OSIUQ8gCZQir6I 0CTGvaAWG2QCywM0HqbKRhsYfLKfjWsdFVKdR9MHX2IZ8uc8+H36w4aLK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="370229175" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="370229175" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 04:02:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="919830091" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="919830091" Received: from tjquresh-mobl.ger.corp.intel.com (HELO localhost) ([10.252.37.227]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 04:02:20 -0700 From: Jani Nikula To: Chen-Yu Tsai Cc: dri-devel@lists.freedesktop.org, Chun-Kuang Hu , Guillaume Ranquet , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Markus Schneider-Pargmann , Bo-Chen Chen , linux-mediatek@lists.infradead.org, Dmitry Osipenko , Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Subject: Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230914131058.2472260-1-jani.nikula@intel.com> <20230914155317.2511876-1-jani.nikula@intel.com> Date: Tue, 19 Sep 2023 14:02:18 +0300 Message-ID: <87cyyetohx.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 19 Sep 2023 04:02:41 -0700 (PDT) On Fri, 15 Sep 2023, Chen-Yu Tsai wrote: > On Thu, Sep 14, 2023 at 11:53=E2=80=AFPM Jani Nikula wrote: >> >> The sads returned by drm_edid_to_sad() needs to be freed. >> >> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195") >> Cc: Guillaume Ranquet >> Cc: Bo-Chen Chen >> Cc: AngeloGioacchino Del Regno >> Cc: Dmitry Osipenko >> Cc: Chun-Kuang Hu >> Cc: Philipp Zabel >> Cc: Matthias Brugger >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-mediatek@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: # v6.1+ >> Signed-off-by: Jani Nikula > > Looks correct to me. > > Reviewed-by: Chen-Yu Tsai Thanks for the reviews Chen-Yu and Guillaume. Will you push this to drm-misc-next or shall I? BR, Jani. --=20 Jani Nikula, Intel