Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <c7870702-dc6c-4673-ac5c-04c81c463bbf@cornelisnetworks.com>
Date:   Tue, 19 Sep 2023 08:11:27 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/8] RDMA/hfi1: Use FIELD_GET() to extract Link Width
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230919125648.1920-1-ilpo.jarvinen@linux.intel.com>
 <20230919125648.1920-2-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From:   Dean Luick <dean.luick@cornelisnetworks.com>
In-Reply-To: <20230919125648.1920-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXc5dTBxMXlYNjBtTVJpRnlJYTkxa0d4djdWeFQ1VWI2S3JBb2hheWJlSkQ1?=
 =?utf-8?B?Q2xsMkFJcWdrZkRKQ3c2dm16Y2QwTlgrVXJMclBzTjFad1FtMXFwQ2JVQ1h1?=
 =?utf-8?B?UXdvYzJic0kxdEhVTWtyZW40OFVDRzF0QkRhZ3NZZ2FZNVdkVGtqNllOU1BR?=
 =?utf-8?B?Y0I2d21hZnEyV3ZXaFh5YnNIUCtJdU16QVNhY08wbmFkTm5TOFR1M1dUZ1RK?=
 =?utf-8?B?dXgrOHdXYzhENzhQZVc2c2YxL2l2ckpTVHhGOWJtZ1ZtV2hNV1VDci9GUUJQ?=
 =?utf-8?B?anhRWVNzV0NJRHZnRmZ1dHd3L1F0cEhXOEx3ZVd2ME8wL2xaZCs5U2RGMGFP?=
 =?utf-8?B?Z29ORTE4ckpPUi9HaHQwaHI1QnJDRWlUdmtsaFVtMzZuakNoVEhRSWo2K0ZL?=
 =?utf-8?B?ME5JMDhuRE54cytvQ2R5eVBrNkQ3cWVFNHoyVkdOVG1vc3kzNC9SWDVIa1pI?=
 =?utf-8?B?MDkralVuSHY0MHVMNUZreHdhb2VKUnZPZ3AxdVViNmdXTmV1cEJzc2h1K0ti?=
 =?utf-8?B?ejdRczVPc2FKVTdvNktZR3RoWVhudTNpNVQybjh4MTI2NFNxSXBoa1kyazdh?=
 =?utf-8?B?SGUwa1VwbzJjbWlObmNMUUNidVlPdFBOZlo3NlFlR21lQ1hoajJST0dvczNq?=
 =?utf-8?B?N01Sc20xODY5ajVWMGd2ZjdRWUFTT3lCbGpIQ0ViaC9Wc2JxRjdGY09Vbmli?=
 =?utf-8?B?d1JLL01yTWZTRUx1T3d0dVc3UGU4RGVVOTNuQ0pxVzU3WWU4ckV5RHJTYTNN?=
 =?utf-8?B?Vm1CR3Rra0VSdnloQlppbW9OelFyWWdlcjRJV0xDR2VKVm0xYzZaRC9LSzQx?=
 =?utf-8?B?cFVVajhmTnpzdEVMd21mSGVRbEVUNkJCNG5rZndBa1NnR3dMOTJHa0M0QkFK?=
 =?utf-8?B?VjdJaGVvV0YwRmFyQUQ0NWduc2xaRDRnZ2NrcWVoUVgxS2xaMzFTRUJxMExH?=
 =?utf-8?B?bGh6VjZxZUZhdjI4MzV2a2FvMDI2czRsWmZvME8zQUtLU21OTU1kT3hIZTZW?=
 =?utf-8?B?TElZdWV6ZDRpMlVHLyt0bmFJdTd5OHBrN254a3N4Sk1GRzVEd2s3cDNHc0lO?=
 =?utf-8?B?QzhaQ1FlWm14TElJMFFNSDhiTTkxOEhySER6L0NJRjhQSmV3ZUNXaVdHM2VD?=
 =?utf-8?B?WWRFbnJrT1FBMUlUUUdhMjZ1WFZNT0IyOGlVVmN3M0xxNTVmcktMTXdsR3Q0?=
 =?utf-8?B?WVNrdGM5NVdLa29MVzg0cWsvYmVwVDRTbXlNTlNhcVdlaVVqSENyVEJnQ2Ex?=
 =?utf-8?B?bkQ1ZWlSUmN4STE3MlZwYWgyNWx5T1o2c2dkdDdxMG80NE5tWTRMbG5UMm1D?=
 =?utf-8?B?RWNVWk9EZUcrUW90WTU1dHZwK1ZETlMxNDhBL2VjUWtJMEc0VFZWNzFJMktM?=
 =?utf-8?B?V3luZ2VUK0xNNnBuSnAzS0R6djhXQllNN2ZkeWpGbTdvSkR0L0R1N0h1MDlw?=
 =?utf-8?B?REFhTURnZk9oemxNVCtRemRqVC9IWDFvZHRIZ0ZhU05iWjNBOTN3bExBTVVy?=
 =?utf-8?B?NDRpOUFQUG03MHMvVEY0aXVaMitFVGxJN2EyU2RWQlM5cndoR2E4ems2dVZX?=
 =?utf-8?B?TktMOXp4akkxekp2V3M4ajloNkRMMEhCL0p3MkM3dlRNeHhiclhWNGZWaGV6?=
 =?utf-8?B?UGFIUWlIUmhJRUVyY0NwRkY0bVJZdjhYbnBIbzRORHdxdmdKT2pTczdsbUIz?=
 =?utf-8?B?SXRUVHlhQkFOWWcvN0xldDM3WTFYUFhTTVhGbGdEeFRqZUN4YTNxbkZvWHAr?=
 =?utf-8?B?V1JvQlk0T1VpM0drZUFYem5abEZkRXliSFlqZ082ZUF2VEU5ZnlHdk9JMjMy?=
 =?utf-8?B?NVlxTytkNzluMlQ2MmRKNk1sR09TbTFQTSsyMFh6dlRNKy9SWEtsT0twZGRE?=
 =?utf-8?B?U0tiYWw3ajFPdndhV2FrSHc0RlJhbDZ4UGQ2dnZsbFRESFR5ZmhiZFg3OGd4?=
 =?utf-8?B?Y3FQR0pUVFBEQ2NmenFwNnBlc2xjWDN6OThQZTBFSUJXNmNuOWRDU1hNdkhp?=
 =?utf-8?B?UFFvSmJNaWxzdWp2eDBrVVpMMjgwa2l4TnIveDVIQ1oreGp2dGxMekNyb2g3?=
 =?utf-8?B?NWxkMTltcHFIdHhNdFFtcVV3RUVLVG9zbTZ2U05RR1hkc2VmQWpGZnVNWGZm?=
 =?utf-8?B?bFJjYTJnLzVRVXVXSWhmcTg1cWRkYkpoNGovVXBjVE9vaGdMZ3NtQUw4cEY2?=
 =?utf-8?B?VkE9PQ==?=
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97bf9bfd-724a-4b52-24a4-08dbb911f083
X-MS-Exchange-CrossTenant-AuthSource: BL0PR01MB4131.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 13:11:30.5144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L9nJ37vFKZvuc5n479djOItpSNBU3ywgRAoOvMq21M7C/Z3CoZpcrxGxjhQ315JYhEDy/yPirNWfG1pGgslRtQLb6YQFFlJWmDaDmfqZvrA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB7495
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 19 Sep 2023 06:11:48 -0700 (PDT)

On 9/19/2023 7:56 AM, Ilpo J=C3=A4rvinen wrote:
> Use FIELD_GET() to extract PCIe Negotiated Link Width field instead of
> custom masking and shifting, and remove extract_width() which only
> wraps that FIELD_GET().
>
> Signed-off-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/infiniband/hw/hfi1/pcie.c | 9 ++-------

Reviewed-by: Dean Luick <dean.luick@cornelisnetworks.com>


External recipient