Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp845760rdb; Tue, 19 Sep 2023 11:53:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/o+YxFG3FpW75HyAsW43fg8sJ9yRy/WYCtuscgTBCsAuFIW+KJvN3TuzeSOt9Xzt6Clij X-Received: by 2002:a17:902:bc41:b0:1bf:22b7:86d with SMTP id t1-20020a170902bc4100b001bf22b7086dmr246679plz.3.1695149635396; Tue, 19 Sep 2023 11:53:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695149635; cv=none; d=google.com; s=arc-20160816; b=Y0+DG43J1ouqToZj+dEnXCdRqRQybxdQhW1meskjTRD5odUqL/MMtWFa/osZfxgdBq HOB1Ax1OK/yELZgD8dhYcru1FD9N5dF+2VkTN6utjFC7fI+YCIGD9oMPz7DZhSh8gc5T UMyWCTvntLTzblTkqUZ/Xm+3tazcpLBhqjwupndjHHghN8moWGP4zOCj0ATzLXoDn6wC cxvjcz4ystYnwPr/9arYpCGscUkP2nF/k+R/zmP3ovghLDm9JVfl81sG26TaOHPXtYwF MiuWpTthAkAbtML8GXNKv+7lvkydoqOW6HuFJbVW4PKFD1HZKmsSQgTRKmv9a2my35wk 03ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=bzYopflC5Ycg8A2mJPw24w/sj5t1CGgoOnaSWed8JPs=; fh=wQqRfZhZRw5j9T5Wd4dWvki+pUYWVsh0GS6k/sIUqgA=; b=nsYHmiK98Lx0irEEBYF5rppQcVVkwt8Q5+HvgzFvzfNPWQAjGOzZDZo2/PT/AKPMQR wSSG+K/lVuqIKp6OWF6/RtsHJM5wfcrzIX7RxSkN2MeCezhIp1juQTfCQhCrBRQCuvO7 uSdPAcfy4Hdy3gojCMj0L59lriW37EjS1IyW9djJXrUTbj9QHHUbaUkyoLeWhKtNcwnt U+9HAskxh3K47zazcvXH0dszIc56E8MscXqTBlIWmaA3GOk8ymK8YutZ2O92QRD/dT02 QAfKKtrBOctZP6DRQDGx/NV0Jo+dZBiV2px5RamxXaTEdMZVz4DE4Scg40OzQNJGXn+X 2PwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm2 header.b=Gxkvsvm1; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=cJ40j89M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=svenpeter.dev Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id j3-20020a170903028300b001b887c89a8dsi10684218plr.521.2023.09.19.11.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 11:53:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm2 header.b=Gxkvsvm1; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=cJ40j89M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=svenpeter.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1296C81A7D0E; Tue, 19 Sep 2023 06:35:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232364AbjISNfe (ORCPT + 99 others); Tue, 19 Sep 2023 09:35:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231960AbjISNfd (ORCPT ); Tue, 19 Sep 2023 09:35:33 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB1C102 for ; Tue, 19 Sep 2023 06:35:25 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CFB7D5C01A1; Tue, 19 Sep 2023 09:35:24 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute5.internal (MEProxy); Tue, 19 Sep 2023 09:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1695130524; x= 1695216924; bh=bzYopflC5Ycg8A2mJPw24w/sj5t1CGgoOnaSWed8JPs=; b=G xkvsvm1Lv3PVPu/1d0UOhoBRpcl6vGaXwglXl7zL/K2X4XwXEcu26QIVR96ZqJ9D ve09wgF21jfWJmXoRdEVt4GRq+wP8NEDQhF+bnIBsehFnzxw1gDCoxOeXNfsEctx dsDNbVOkNYx93GJzeQJLRdOI1t5vszmAOJnXyILewQu/uD2AiEqSii94BQd4l97M bFlGX6j0M1nit11hzi2d52OMqb2LU7a+1HhvpyvwYmsfxwbkLpzqs7B6VtPFqNzn P+cM6CdSyPmT5RFV8aAuhSW0fZ3WZqfVQwqqEjYERFarlYudYxv6vyRj3Yvv477d 0ZXUhUYSwKh+niWI9+Kow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695130524; x=1695216924; bh=bzYopflC5Ycg8 A2mJPw24w/sj5t1CGgoOnaSWed8JPs=; b=cJ40j89MtlxPv1P76qx03WptbAU0Y N1XDGCPeqOJ+a+vXaaujdtlx2+ahVGHk1BuhjHklocmR6jgySY+AtophrMYRUTaZ 1l48dPYYaHWmH+0dKwI6+toRv1FwmMDchseSCaqqavhEAt14mrhsWoOpocM16XN0 +yhL3h2SDsGVt4lZ496YIi6UcOKCeRg1PHd1F31zKPHbLO1Vc9XQel+QPZqvExZm EQwN00GMvYFHicAGxbYTNEU2Bz5nopZ44sPybpkcZQmk0rXPbkbEoJ9eQ9BtlAxq 2GXV5V5yAE4roHzux5EVGepdzDWWZuKfmdNGvKdIAPy9wNvMrI54cAkAA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekuddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfufhv vghnucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrf grthhtvghrnhepleevgfegffehvedtieevhfekheeftedtjeetudevieehveevieelgffh ieevieeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshhvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 93789A60077; Tue, 19 Sep 2023 09:35:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-761-gece9e40c48-fm-20230913.001-gece9e40c MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20230912-simpledrm-multiple-power-domains-v2-1-01b66bfb1980@jannau.net> Date: Tue, 19 Sep 2023 15:34:56 +0200 From: "Sven Peter" To: "Thomas Zimmermann" , "Janne Grunau" , "Javier Martinez Canillas" , "David Airlie" , "Daniel Vetter" Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH v2] drm/simpledrm: Add support for multiple "power-domains" Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 19 Sep 2023 06:35:44 -0700 (PDT) Hi, On Mon, Sep 18, 2023, at 09:11, Thomas Zimmermann wrote: > Hi > > Am 12.09.23 um 22:22 schrieb Janne Grunau via B4 Relay: >> From: Janne Grunau >> >> Multiple power domains need to be handled explicitly in each driver. The >> driver core can not handle it automatically since it is not aware of >> power sequencing requirements the hardware might have. This is not a >> problem for simpledrm since everything is expected to be powered on by >> the bootloader. simpledrm has just ensure it remains powered on during >> its lifetime. >> This is required on Apple silicon M2 and M2 Pro/Max/Ultra desktop >> systems. The HDMI output initialized by the bootloader requires keeping >> the display controller and a DP phy power domain on. >> >> Signed-off-by: Janne Grunau > > As a simpledrm patch: > > Reviewed-by: Thomas Zimmermann > > Do you want to wait for another review from someone with > power-management expertise? I can't claim to have a lot of genpd experience but we use very similar code in a few other M1/M2 drivers that also require multiple power domains to be up without any sequencing constraints. So for whatever it's worth: Reviewed-by: Sven Peter Best, Sven