Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp866071rdb; Tue, 19 Sep 2023 12:28:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwrk+yzPPD6yl6eMGsHdFrkc+HJD/RqU420oSXB1wYJfk6hU8l8fcXsgEIWnphRIYfbvr1 X-Received: by 2002:a05:6358:93a7:b0:139:d24c:ed28 with SMTP id h39-20020a05635893a700b00139d24ced28mr999004rwb.12.1695151715770; Tue, 19 Sep 2023 12:28:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695151715; cv=none; d=google.com; s=arc-20160816; b=E93XkJBPPa+0ACuv2fINHe5/SFg4LJDzQzJdpTAuca8QyeYVZnJ7Wvi6+z9Un88Vo2 yJfMbRvF+Mi+g4BY4Nrrxpq6KbMbk6zLRq93Hd9CXlQv22dwTQstIC2AjBVvivrB9dGa ukW2qOlMCv2AwDOkqwVm6WVL1udr3WQVNk1FCa+b/zD5RnBE3SOxiTryGtIAQgHpRzUU z1zY6awg/7lm3wBHBx4LtiSnRIGhtPWmAWsCrTHO8iWVPEGUpVZjT+FO1I3iZIP4WnCJ iZr0jRpr+fpZnlfcq5CmvTTtWdnv3RsDy7Wgq+z3LCZz6ibHQfSTqfwDwZj/uwun4l3R IBdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=prnVODPDbbCKrcsnVH7zcO+m5sChTSruorXvjDZ86pg=; fh=Dec8UrNyk7zKZQPMCCzTzVJmHdqd/nCZf4sDe/sK9Ts=; b=THVgn62DBT9/BNJGXp0dSEaXPc7UxNvSuGHDtc6v0WUQFsDhYZkXpvq21ej7QbB6C/ +ATUEinLpBIPZYgSHnKo08j4k4vaWfC/5wBAkptGl3Yq3BuHfl4y7JOrSmcoEmLna9H6 ynm4LQyDATAURJoqRmHQcOInbDLONV28PL1OqlteUFUjFBfPUDuc/mOO2IgVOV1CPOvg 3+PPatFFmYdmkgQARcj+ALrT7y29WRbXyS6VQj+mARt5NkkqUoCxM2EGsfADW6AAJgsm UEhf2lVrJ6kiba4rS1T/7ayUO24Pt+0ZrKmLu1A9TEKehjlHSTk83dxUiLTrJ4TBD3Pc raLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hiayCZa5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id o25-20020a635a19000000b00573fd9be4bdsi10045711pgb.493.2023.09.19.12.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 12:28:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hiayCZa5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 71AE481890A4; Tue, 19 Sep 2023 12:14:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232572AbjISTOv (ORCPT + 99 others); Tue, 19 Sep 2023 15:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232411AbjISTOt (ORCPT ); Tue, 19 Sep 2023 15:14:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C6A3B3; Tue, 19 Sep 2023 12:14:44 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C17DCC433C8; Tue, 19 Sep 2023 19:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695150884; bh=O/2PHkyHfngUGOAxEJ3i8HsxP6TKXlPoENgLMx+44Ak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hiayCZa5yefhuEjzC8nvlJhQAC5oXtcrzpnnAkMpevqdx9KHw5Y+bbQZonoxOl848 KA8GwTHIsSedxxJ3qenKmZ7c/G4us5d3rhfWr3fuBxS/tfg74dU46Bgzz4aaqNhnan rYOAQtj8jwYmiIPo7UA8iarG7cm3lAlH4buESkFxDec0fRuObKMi763Vq1L2kwPphf qTw6XmhKb9e7a54OTs2r+aWPBLHOmsEdIvXockbxOrVR54/Bkrz0le3MCkNN4vpWR/ gEzrzI2WQjTZqSfW6ZqFgOliGLpestKr3NTYNG9VqOhVfPDp4h0cI4SHOZtnDJUaxF q8KdQrK/77iHw== Date: Tue, 19 Sep 2023 12:18:53 -0700 From: Bjorn Andersson To: Manivannan Sadhasivam Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: rpmh: Include resource name in the trace event Message-ID: References: <20230707122713.37487-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230707122713.37487-1-manivannan.sadhasivam@linaro.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 19 Sep 2023 12:14:48 -0700 (PDT) On Fri, Jul 07, 2023 at 05:57:13PM +0530, Manivannan Sadhasivam wrote: > The client drivers of RPMh like rpmhpd and bcm-voter has the name of the > resource they are dealing with along with the address. So let's include > the resource name in the RPMh trace event as it avoids doing a post > processing of the trace event to resolve the resource name its address. > Instead of extending the generic client API to pass the strings in (not all clients are captured in this patch either), can't we do something like dumping cmd-db into a trace_print_flags array during initialization and use __print_symbolic() in TP_printk? Although...for VRMs we probably want sym+ in the output, so __print_symbolic() isn't a perfect match... Regards, Bjorn