Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
Date:   Tue, 19 Sep 2023 18:02:26 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   "Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>
Message-ID: <16e1b7632d840c1cc9efa09f0710683039514d83@linux.dev>
TLS-Required: No
Subject: Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C
To:     "=?utf-8?B?VGhvbWFzIFdlacOfc2NodWg=?=" <linux@weissschuh.net>,
        "Guenter Roeck" <linux@roeck-us.net>
Cc:     "Jean Delvare" <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "Douglas Gilbert" <dgilbert@interlog.com>
In-Reply-To: <5fb278c7-df91-4f02-ab5f-baa47d27507f@t-8ch.de>
References: <5fb278c7-df91-4f02-ab5f-baa47d27507f@t-8ch.de>
 <20230911-powerz-km002c-v1-1-898bd79b9bae@weissschuh.net>
 <6e5eff10-949c-4f17-a3f3-347b85b89e11@roeck-us.net>
Precedence: bulk

September 19, 2023 at 1:15 PM, "Thomas Wei=C3=9Fschuh" <linux@weissschuh.=
net> wrote:
> On 2023-09-18 12:05:19-0700, Guenter Roeck wrote:
>=20
>=20>=20
>=20> On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Wei=C3=9Fschuh wro=
te:
> >  The KM002C is similar to the KM003C and seems to use the same
> >  protocol and firmware.
> >=20=20
>=20>  Reported-by: Douglas Gilbert <dgilbert@interlog.com>
> >  Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d=
80d64@interlog.com/
> >  Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> >  ---
> >=20=20
>=20>  This patch is based on hwmon-next,
> >  commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit r=
egisters").
> >=20=20
>=20>  Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> >=20=20
>=20>  Applied, but please be more careful with your comments and Signed-=
off-by:
> >  tags. There should only be one '---', and one signature.
> >=20
>=20
> Thanks,
>=20
>=20the duplicate Signed-off-by is indeed an oversight which I'll
> try to avoid in the future.
>=20
>=20As for the '---':
>=20
>=20Two of them are generated by the 'b4' tool and I added one manually w=
ith
> the hwmon-next information.
> For other subsystems this wasn't an issue so far.
>=20
>=20Are these duplicate sections a problem for your personal tooling or i=
s
> it affecting something more widespread?

There should be no impact on any tooling, to my knowledge. Only the first=
 --- matters for git, any additional ones are ignored.

-K