Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Tue, 19 Sep 2023 13:00:15 +0200
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Tejun Heo <tj@kernel.org>
Cc:     Luiz Capitulino <luizcap@amazon.com>, lizefan.x@bytedance.com,
        hannes@cmpxchg.org, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org, longman@redhat.com,
        lcapitulino@gmail.com
Subject: Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option
Message-ID: <7zv7lqkondaacjhmc7oscyqzwugguxvjw2yhdhkv4axhhkts7a@upoxgl3qpunt>
References: <20230906005712.66461-1-luizcap@amazon.com>
 <29bdb453-c6e3-a047-1f27-e9656da92301@amazon.com>
 <ZQiNIWQe7spOwjil@slm.duckdns.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fq5yevqc27dto7fu"
Content-Disposition: inline
In-Reply-To: <ZQiNIWQe7spOwjil@slm.duckdns.org>
Precedence: bulk


--fq5yevqc27dto7fu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 18, 2023 at 07:47:13AM -1000, Tejun Heo <tj@kernel.org> wrote:
> Michal raised some valid concerns. I don't really mind that it's not great
> on the edges tho. Michal, what do you think?

I'd have a few suggestions:
- reset to have_dynmods value instead of false in cgroup_destroy_root()
  (to the benefing of the users of this option, not the common default
  users) or not touch the value in cgroup_destroy_root() at all
- s/CONFIG_FAVOR_DYNMODS/CONFIG_CGROUP_FAVOR_DYNMODS/ in commit message

Those should be minor tweaks,
Michal

--fq5yevqc27dto7fu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZQl/PQAKCRAGvrMr/1gc
jrkrAP0Tym353enXva+j6+YL+Gm0V3UvU+Jj6RKzfoMExDArZwEAwZ8CC+0DQZW1
1VW13GrliCR0DXybstlYxSDVzLFvcAk=
=OD1D
-----END PGP SIGNATURE-----

--fq5yevqc27dto7fu--