Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763203AbXKHU13 (ORCPT ); Thu, 8 Nov 2007 15:27:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761407AbXKHU1T (ORCPT ); Thu, 8 Nov 2007 15:27:19 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:43856 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761348AbXKHU1S (ORCPT ); Thu, 8 Nov 2007 15:27:18 -0500 Date: Thu, 8 Nov 2007 22:27:16 +0200 (EET) From: "=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=" X-X-Sender: ijjarvin@kivilampi-30.cs.helsinki.fi To: Rainer Jochem cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org, kaber@trash.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pcernko@mpi-sws.mpg.de Subject: Re: [PATCH] ipconfig.c : implement DHCP Class-identifier In-Reply-To: <20071108143205.GA22490@mpi-sb.mpg.de> Message-ID: References: <20071108143205.GA22490@mpi-sb.mpg.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 32 On Thu, 8 Nov 2007, Rainer Jochem wrote: > @@ -620,6 +622,17 @@ ic_dhcp_init_options(u8 *options) > *e++ = sizeof(ic_req_params); > memcpy(e, ic_req_params, sizeof(ic_req_params)); > e += sizeof(ic_req_params); > + > + // Send it only if the according kernel parameter was set No C99 comments please. Though I'm not sure if this comment is that necessary anyway... > + if (*vendor_class_identifier) { > + printk(KERN_INFO "Sending class identifier \"%s\"\n", > + vendor_class_identifier); > + *e++ = 60; /* Class-identifier */ > + *e++ = strlen(vendor_class_identifier); > + memcpy(e, vendor_class_identifier, > + strlen(vendor_class_identifier)); > + e += strlen(vendor_class_identifier); > + } > } > > *e++ = 255; /* End of the list */ -- i. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/