Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp895789rdb; Tue, 19 Sep 2023 13:33:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYIYL9ZBpcb8L4FU+nSYq5/BiJiZknwZU758A06UCPwoEgjzN27wus+UC/IHb+SfHUvbYb X-Received: by 2002:a92:c5a7:0:b0:348:fe3b:c8b with SMTP id r7-20020a92c5a7000000b00348fe3b0c8bmr919878ilt.1.1695155595871; Tue, 19 Sep 2023 13:33:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695155595; cv=none; d=google.com; s=arc-20160816; b=zGe9HybQZwZ7EpOw0B2gHty0fDKlUEggmgB9o39Na+ssl2KWQP9dHyS8O9ef5W6yfH r8/DbEpRk9ED/mmy59NrATT6dDWhPOG/uqqjS9riuJVG6qwdCUlmXFaFHrddlJl5ZKnh UC1vpY34SjhRM+UAz/RETskBBAksJzpYOJflBO7UJzF7EaXYrTDyHGszhUdZRSX30hZL AcYAqJXJpGjof5ju/jVEHRNou13yu9saiMnjdc403FUMtYM6RKxOy1Dp2LR6ukGSzDAz JJ5soZiU46/KaEEYRZnLm39bT09CRfWPivWFpOIpw/qn/hTvpMtXVw7xV59QBAHXzExE Xzzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B3iOXkvpIH0SnZRlnTCYyUanwrhHpUP8eMKNMHt5tQE=; fh=u/NEvw+QSS+ecqzTIHyh7eAMpUy8tPKugns3smii0cg=; b=XRjrhUETXCvMKb+s0+LjZqK5mP9ANxhgL+HGuyh4bzT3OsAy7romFc5GUqOluAwPaQ 51JGrT8bGL1kH5p5XR5LrOvGu4WeU4aDc28TaiFjlZrQx30t9PLg7sXX+CNn4TsPOXyu cDvTYpvU68KTBcMD0BQS1MZax6zWZwSYTPfei0IYutVdvHRwp04XRqsmJRphtCvj6jIp WrxiLyV+ADpcWDx/J7PptQV9S2w1YMickRPDJorSpOCOH/eNdv1AurJsORwgmaDbQ9Y7 mXputcwphB4Tl2JNFh7udJtI5jYrLZf7tVNF/jQKaNis/t/3t/wRbMpHYR7JfuuV/SlD +CNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=fxBxJ7Gx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id 76-20020a63004f000000b0057777451a73si10393595pga.703.2023.09.19.13.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 13:33:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=fxBxJ7Gx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id BDBFF80E761D; Tue, 19 Sep 2023 08:24:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233142AbjISPY0 (ORCPT + 99 others); Tue, 19 Sep 2023 11:24:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232823AbjISPYZ (ORCPT ); Tue, 19 Sep 2023 11:24:25 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE1AEE60; Tue, 19 Sep 2023 08:24:17 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7479B53; Tue, 19 Sep 2023 17:22:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1695136959; bh=9vIyKWF61Oki0ViP0MM9OtlYNdPRel3PPjwYgBK9PgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fxBxJ7GxeYlxsv1O+e8OcB0xbaq3uqYvHMy6CJ+TAxNH9W/dGWlrG+m/XoCY3m6z6 QH/kgnB92SDfVDlD79tXdPCTTTNCgerQ8jVda95uBOVKtQVkPsKmtQuPAwhTeAbQXP BBt/QdZG/1mxqJrUUV1gCD1fW4Gj21NPLG2qfhvI= Date: Tue, 19 Sep 2023 18:24:28 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: David Airlie , Daniel Vetter , Kieran Bingham , Thomas Zimmermann , Magnus Damm , DRI Development , Linux-Renesas , Linux Kernel Mailing List , Geert Uytterhoeven , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mauro Carvalho Chehab , Hans Verkuil , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Media Mailing List , Linux Fbdev development list , Linux-sh list Subject: Re: [GIT PULL] drm: renesas: shmobile: Atomic conversion + DT support (was: Re: [PATCH v4 00/41] drm: renesas: shmobile: Atomic conversion + DT support) Message-ID: <20230919152428.GB18426@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 19 Sep 2023 08:24:44 -0700 (PDT) On Tue, Sep 19, 2023 at 04:28:40PM +0200, Geert Uytterhoeven wrote: > Hi David, Daniel, > > The following changes since commit 0663e1da5ba8e6459e3555ac12c62741668c0d30: > > drm/dp_mst: Tune down error message during payload addition > (2023-09-18 16:38:21 +0300) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git > tags/shmob-drm-atomic-dt-tag1 > > for you to fetch changes up to bfea0fa9052aa8d235b24957eb84d9ff20cb87b7: > > drm: renesas: shmobile: Add DT support (2023-09-19 15:58:04 +0200) > > ---------------------------------------------------------------- > drm: renesas: shmobile: Atomic conversion + DT support > > Currently, there are two drivers for the LCD controller on Renesas > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: > 1. sh_mobile_lcdcfb, using the fbdev framework, > 2. shmob_drm, using the DRM framework. > However, only the former driver is used, as all platform support > integrates the former. None of these drivers support DT-based systems. > > Convert the SH-Mobile DRM driver to atomic modesetting, and add DT > support, complemented by the customary set of fixes and improvements. > > Link: https://lore.kernel.org/r/cover.1694767208.git.geert+renesas@glider.be/ > > This PR is based on today's drm-misc/for-linux-next, to avoid a > conflict with commit 775b0669e19f2e4a ("drm/shmobile: Convert to > platform remove callback returning void") in drm-misc/for-linux-next > . > Thanks for pulling! > ---------------------------------------------------------------- > Geert Uytterhoeven (36): > MAINTAINER: Create entry for Renesas SH-Mobile DRM drivers I'm technically listed as the maintainer for this driver until Geert takes over, so for this pull request, Acked-by: Laurent Pinchart And after that, shmobile won't need my ack to merge further changes :-) This is very nice work Geert. I'm looking forward to dropping the sh_mobile_lcdcfb driver. > dt-bindings: display: Add Renesas SH-Mobile LCDC bindings > media: uapi: Add MEDIA_BUS_FMT_RGB666_2X9_BE format > drm: renesas: shmobile: Fix overlay plane disable > drm: renesas: shmobile: Fix ARGB32 overlay format typo > drm: renesas: shmobile: Correct encoder/connector types > drm: renesas: shmobile: Add support for Runtime PM > drm: renesas: shmobile: Restore indentation of shmob_drm_setup_clocks() > drm: renesas: shmobile: Use %p4cc to print fourcc code > drm: renesas: shmobile: Add missing YCbCr formats > drm: renesas: shmobile: Improve shmob_drm_format_info table > drm: renesas: shmobile: Improve error handling > drm: renesas: shmobile: Convert to use devm_request_irq() > drm: renesas: shmobile: Remove custom plane destroy callback > drm: renesas: shmobile: Use drmm_universal_plane_alloc() > drm: renesas: shmobile: Embed drm_device in shmob_drm_device > drm: renesas: shmobile: Convert container helpers to static inline functions > drm: renesas: shmobile: Replace .dev_private with container_of() > drm: renesas: shmobile: Use media bus formats in platform data > drm: renesas: shmobile: Move interface handling to connector setup > drm: renesas: shmobile: Unify plane allocation > drm: renesas: shmobile: Rename shmob_drm_crtc.crtc > drm: renesas: shmobile: Rename shmob_drm_connector.connector > drm: renesas: shmobile: Rename shmob_drm_plane.plane > drm: renesas: shmobile: Use drm_crtc_handle_vblank() > drm: renesas: shmobile: Move shmob_drm_crtc_finish_page_flip() > drm: renesas: shmobile: Wait for page flip when turning CRTC off > drm: renesas: shmobile: Turn vblank on/off when enabling/disabling CRTC > drm: renesas: shmobile: Shutdown the display on remove > drm: renesas: shmobile: Cleanup encoder > drm: renesas: shmobile: Atomic conversion part 1 > drm: renesas: shmobile: Atomic conversion part 2 > drm: renesas: shmobile: Use suspend/resume helpers > drm: renesas: shmobile: Remove internal CRTC state tracking > drm: renesas: shmobile: Atomic conversion part 3 > drm: renesas: shmobile: Add DT support > > Laurent Pinchart (5): > drm: renesas: shmobile: Remove backlight support > drm: renesas: shmobile: Don't set display info width and height twice > drm: renesas: shmobile: Rename input clocks > drm: renesas: shmobile: Remove support for SYS panels > drm: renesas: shmobile: Use struct videomode in platform data > > .../bindings/display/renesas,shmobile-lcdc.yaml | 130 +++++ > .../userspace-api/media/v4l/subdev-formats.rst | 72 +++ > MAINTAINERS | 13 +- > drivers/gpu/drm/renesas/shmobile/Kconfig | 3 +- > drivers/gpu/drm/renesas/shmobile/Makefile | 3 +- > .../gpu/drm/renesas/shmobile/shmob_drm_backlight.c | 82 --- > .../gpu/drm/renesas/shmobile/shmob_drm_backlight.h | 19 - > drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 650 +++++++++------------ > drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.h | 27 +- > drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 179 +++--- > drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.h | 18 +- > drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 77 ++- > drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.h | 9 +- > drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 326 ++++++----- > drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.h | 5 +- > include/linux/platform_data/shmob_drm.h | 57 +- > include/uapi/linux/media-bus-format.h | 3 +- > 17 files changed, 860 insertions(+), 813 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/renesas,shmobile-lcdc.yaml > delete mode 100644 drivers/gpu/drm/renesas/shmobile/shmob_drm_backlight.c > delete mode 100644 drivers/gpu/drm/renesas/shmobile/shmob_drm_backlight.h -- Regards, Laurent Pinchart