Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp920173rdb; Tue, 19 Sep 2023 14:31:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLdLDZSvAj8lGMf7Awru3vuE5zhFXFC7otrdzIvbvi31bi/in5y4UXO7FAG53R6AbsxJ0x X-Received: by 2002:a17:902:8217:b0:1c3:90c7:b99d with SMTP id x23-20020a170902821700b001c390c7b99dmr536957pln.41.1695159110941; Tue, 19 Sep 2023 14:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695159110; cv=none; d=google.com; s=arc-20160816; b=qGjLFXrceSthVg9TQNUIjV6fP0sZ8JDUeHBfkC+tUcJ8Kyw+3g+5DL3keXmD5oCJHr fpfhcG3QzCPMzcUwFkV/QqYBXaoKju22IW7TIPSqrM/It4MtO1ZEMm28hBcjGDWD8sab BRzMy1Pv8aMw2esXrd05egj5BjnfTppa/1O6Uv7KzvdmqmeXZSIpSbxtrHpC9piwTogZ T9gWuT8cyHLbwSdPaAJ9NTke4F2936ayulLOQiGDfIwTPfCGjNJ3sYin/fnc4ncim61V lgomJ2HcSR7n1AgmBwXLiGnjxMVl2L8VemjhTPDag5kZ6TbolWDpXjj2Whk7cahqLyf5 PKfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yPXw5msWBa7gpoTMlarfa1JynmH72wdGK8K5th/5R3U=; fh=8aZI9pUuWAdzqD2K5HWgzVN7FOpIULyeDB61z2QYfBc=; b=vLW09Zr5LouCxeKJBRWrmQ58oKnddouR6y8EaFTes2sAXFN9+61UUiZfdaDN0cCUia V0BkomVaix/XQKmlQOnYjFrJhZhH89EbbVZmhYt56Zm7jh0TaAahCByGABn+qqmM83Qr EhLaKUCJKNy68Nqa1uMINSYekW5jBZ8d2ACragUBhzGeSFkqXOKUw54vIKS3GsOqkOXs ttOQRHBwJgbotM3gdk9JWSGzaPghRuGt4NzBvbOrUNjq8CwQlGuFB1zCT4sD5i9/aipj WG0jVBzdjL/FNAU8J+issTTc70mr/qHs20oAJ0L92S+Qa0olUWWPdLCNL/o8dqtxbhuf 37mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bt8IMNCW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id s4-20020a170902ea0400b001bc650255b6si10822571plg.390.2023.09.19.14.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 14:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=bt8IMNCW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id E584F822B749; Tue, 19 Sep 2023 05:08:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbjISMIi (ORCPT + 99 others); Tue, 19 Sep 2023 08:08:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231501AbjISMIf (ORCPT ); Tue, 19 Sep 2023 08:08:35 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E1CF7; Tue, 19 Sep 2023 05:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yPXw5msWBa7gpoTMlarfa1JynmH72wdGK8K5th/5R3U=; b=bt8IMNCWIoMPhCUaKCSuJa5xCE 55Y7MUY7M0PFq4nl56NsGy1MY3WvNRyRRFvOTpV/Y1zvxoaOH7ktZavRUWTm7EFNAfenm3UVi2iPr c5l5zGC3lWP5PCZ3GrlLVYC+BvylVqrSjQqfSDngq2d73+IlXbZQeb8qXlax9s95NQ64=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qiZWS-006uCd-Ap; Tue, 19 Sep 2023 14:08:08 +0200 Date: Tue, 19 Sep 2023 14:08:08 +0200 From: Andrew Lunn To: Hayes Wang Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, edumazet@google.com, bjorn@mork.no, pabeni@redhat.com Subject: Re: [PATCH net-next v2 1/2] r8152: remove queuing rx packets in driver Message-ID: <369f3139-4e63-4327-8745-2d72d7dfea8f@lunn.ch> References: <20230919031351.7334-429-nic_swsd@realtek.com> <20230919031351.7334-430-nic_swsd@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230919031351.7334-430-nic_swsd@realtek.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 19 Sep 2023 05:08:39 -0700 (PDT) > - return work_done; > + if (work_done > budget) > + return budget; > + else > + return work_done; > } I don't know NAPI too well. Are there implications of not telling it the truth? Andrew