Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <9c3d1857-5053-cd8f-75d5-d2691139dfc9@quicinc.com>
Date:   Tue, 19 Sep 2023 21:56:12 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH V2 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018
 compatible
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <srinivas.kandagatla@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <thara.gopinath@gmail.com>,
        <rafael@kernel.org>, <daniel.lezcano@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <dmitry.baryshkov@linaro.org>
References: <20230915121504.806672-1-quic_srichara@quicinc.com>
 <20230915121504.806672-2-quic_srichara@quicinc.com>
 <03b0cafa-49c7-8838-b116-927c9649cbd3@linaro.org>
 <f5aee51d-0345-1294-a85b-ea96ed937685@linaro.org>
 <1f09339e-b3b5-874c-4874-199e8c7ae890@quicinc.com>
 <ee19e076-8f9c-c5b2-3e25-2832dbdab25b@linaro.org>
 <affb1f63-c1ed-f0cc-ea79-887ae61b9b90@quicinc.com>
 <156f4705-ca1a-f82e-9282-534a22183f37@linaro.org>
From:   Sricharan Ramabadhran <quic_srichara@quicinc.com>
In-Reply-To: <156f4705-ca1a-f82e-9282-534a22183f37@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/19/2023 6:26 PM, Krzysztof Kozlowski wrote:
> On 19/09/2023 14:48, Sricharan Ramabadhran wrote:
>>
>>
>> On 9/19/2023 6:02 PM, Krzysztof Kozlowski wrote:
>>> On 19/09/2023 09:22, Sricharan Ramabadhran wrote:
>>>>
>>>>
>>>> On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote:
>>>>> On 15/09/2023 14:43, Krzysztof Kozlowski wrote:
>>>>>> On 15/09/2023 14:15, Sricharan Ramabadhran wrote:
>>>>>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
>>>>>>>
>>>>>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>>>>>>> ---
>>>>>>>     [v2] Sorted the compatible and removed example
>>>>>>>
>>>>>>
>>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>
>>>>> No, unreviewed. Your driver says it is not compatible with
>>>>> qcom,tsens-v1. This does not look right :/
>>>>>
>>>>
>>>>     Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS
>>>>     have to do those steps after calling init_common. Similar reason
>>>>     added a new feat as well in patch #2 as well. Hence for this,
>>>>     new compatible was required.
>>>
>>> I dud not write about new or old compatible ("compatible" as noun). I
>>> wrote that it is not compatible ("compatible" as adjective) with v1.
>>>
>>
>>    Ho, in that case, yes it is not compatible with V1 init and features
>>    because of 'no rpm'. So in that case, should this be documented
>>    as a separate version of 'V1 without rpm' ?
> 
> It should not be mixed with regular v1, just as new entry there. I don't
> think fallback is needed - just use SoC specific compatible.
> 
  ok, sure, will add in V3.

Regards,
  Sricharan