Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp935834rdb; Tue, 19 Sep 2023 15:07:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTXhHblJKM1COHvbjaX7l/gsZHYoKC0t8DEKPd1xeA5D2W1nA8DhttqX9HaFwTYMy7+Y+o X-Received: by 2002:a05:6358:341c:b0:143:36f:95ec with SMTP id h28-20020a056358341c00b00143036f95ecmr1183802rwd.14.1695161238216; Tue, 19 Sep 2023 15:07:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695161238; cv=none; d=google.com; s=arc-20160816; b=gZd2sVDnbmgV3jTjn65+5gFjQHzLCO2UNTDaFdcc0mps/G0bL6rqCYDLPHSgUm6H/U Le3N2Tyy+kbrDKp0Eo98ODVS1Ww2qBjCDPGdIC9iVOZnW0wqVfyKueeA7xFNRx+19gMl /TXRfiZjDL1cE8mRgWHnLLBB4QPRwiyWpasj95UgGHvJo+DXXsUpbSyV1xjO1Tkteq34 W1DlCCWm5EQCVSvbyqFHJNJHuZ7XX+WKDo4Vo9KKja0+slAn71m1K8qlW/ivgPDcnEi3 0lpAl1J+m3peq30Z9IcPsW1pywGT5vdEmZ+UGMzPRtntZPckZ1n0R8YHRgeOeoRzTCKA kXyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=KQ9SnVQR0ev2rRpFFyXcwg3OT+7mPuajRg1/AFqHDzE=; fh=fRuR+/gm8V+x1nQIVLeRASC4SFwiTwxO6XIKL483rBU=; b=FBLrPFwWdIIflBUwWw2SO4whXT6SPRMyTNyP1kpJWN2ozxCR+KPAXVJgtJ7UhsoNAW Y3YAqOhvV6lnvL/51tIqvqdHR3xlmPdJzNvmUKsmLhv6DMMZIcFtvLUx1d5XyAwY3Mgz aEcUq1/K8nXnnZePrWivt8CKuxjGo/Ze9cyOlq09StY7C9lKkStyzQGLfHwt5OvAB8i4 iWWG3YBlzrjV68AR5hrRwGVGlebeyJWlhV1qhAL8MspkgWVL8rKi21MkxzWz8xoWtyzB DSHnNafd6p14K+kfvU0xqYBSMGE4GGfN8xx4jbSn66VgFq74OJkUdvLguucaPseWARM/ j8OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="rW8Qh/dj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id m9-20020a654389000000b0056535e2b751si9895555pgp.782.2023.09.19.15.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 15:07:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="rW8Qh/dj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id DF34780ECAD5; Tue, 19 Sep 2023 13:54:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbjISUyD (ORCPT + 99 others); Tue, 19 Sep 2023 16:54:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233133AbjISUyC (ORCPT ); Tue, 19 Sep 2023 16:54:02 -0400 Received: from out-220.mta1.migadu.com (out-220.mta1.migadu.com [IPv6:2001:41d0:203:375::dc]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A386AC0 for ; Tue, 19 Sep 2023 13:53:51 -0700 (PDT) Date: Tue, 19 Sep 2023 16:53:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695156829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KQ9SnVQR0ev2rRpFFyXcwg3OT+7mPuajRg1/AFqHDzE=; b=rW8Qh/dj/Kdb0RdB34BMKvHEQUKyWwxEEGeAOrIG16Tyi6NBCYeGDrJYnhhjuQejbCMCd2 FOCbOwc/UoeJ1CogiUEw73ECBpEecqhEEGFr5TbN3K9T82WTKsdLUrLcyqX3aapC55qWag NqNdM3+mCPAfvLWQosoqhwmwgTAXevk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Nick Desaulniers Cc: Brian Foster , linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor Subject: Re: [PATCH] bcachefs: Fix -Wself-assign Message-ID: <20230919205347.qfof2omdw6tyedfe@moria.home.lan> References: <20230919-bcachefs_self_assign-v1-1-830936792fc9@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230919-bcachefs_self_assign-v1-1-830936792fc9@google.com> X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 19 Sep 2023 13:54:05 -0700 (PDT) On Tue, Sep 19, 2023 at 01:38:31PM -0700, Nick Desaulniers wrote: > Fixes the following observed error reported by Nathan on IRC. > > fs/bcachefs/io_misc.c:467:6: error: explicitly assigning value of > variable of type 'int' to itself [-Werror,-Wself-assign] > 467 | ret = ret; > | ~~~ ^ ~~~ > > Reported-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Applied, thanks!