Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Cc:     Nikita Travkin <nikita@trvn.ru>,
        Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org
In-Reply-To: <20230918205825.25864-1-rdunlap@infradead.org>
References: <20230918205825.25864-1-rdunlap@infradead.org>
Subject: Re: [PATCH] power: supply: pm8916_lbc: observe EXTCON config
 setting
Message-Id: <169507713770.1098783.11759491213013567471.b4-ty@collabora.com>
Date:   Tue, 19 Sep 2023 00:45:37 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Mon, 18 Sep 2023 13:58:25 -0700, Randy Dunlap wrote:
> When CONFIG_EXTCON=m and CONFIG_CHARGER_PM8916_LBC=y, there are
> build errors. Fix them by having CHARGER_PM8916_LBC depend on the
> setting of EXTCON.
> 
> aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_state_changed_irq':
> pm8916_lbc.c:(.text+0xe8): undefined reference to `extcon_set_state_sync'
> aarch64-linux-ld: drivers/power/supply/pm8916_lbc.o: in function `pm8916_lbc_charger_probe':
> pm8916_lbc.c:(.text+0x638): undefined reference to `devm_extcon_dev_allocate'
> aarch64-linux-ld: pm8916_lbc.c:(.text+0x650): undefined reference to `devm_extcon_dev_register'
> aarch64-linux-ld: pm8916_lbc.c:(.text+0x688): undefined reference to `extcon_set_state_sync'
> 
> [...]

Applied, thanks!

[1/1] power: supply: pm8916_lbc: observe EXTCON config setting
      commit: a6c6a5fe2a08172c2e045588531f0e05a6c296cf

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>