Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762662AbXKHVc4 (ORCPT ); Thu, 8 Nov 2007 16:32:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761283AbXKHVci (ORCPT ); Thu, 8 Nov 2007 16:32:38 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:37432 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761253AbXKHVch (ORCPT ); Thu, 8 Nov 2007 16:32:37 -0500 Message-Id: <200711082131.lA8LVhnk015137@imap1.linux-foundation.org> Subject: [patch 2/2] clone: prepare to recycle CLONE_DETACHED and CLONE_STOPPED To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, drepper@redhat.com, mingo@elte.hu, roland@redhat.com From: akpm@linux-foundation.org Date: Thu, 08 Nov 2007 13:31:43 -0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 50 From: Andrew Morton Ulrich says that we never used these clone flags and that nothing should be using them. As we're down to only a single bit left in clone's flags argument, let's add a warning to check that no userspace is actually using these. Hopefully we will be able to recycle them. Cc: Ulrich Drepper Cc: Ingo Molnar Cc: Roland McGrath Signed-off-by: Andrew Morton --- kernel/fork.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff -puN kernel/fork.c~clone-prepare-to-recycle-clone_detached-and-clone_stopped kernel/fork.c --- a/kernel/fork.c~clone-prepare-to-recycle-clone_detached-and-clone_stopped +++ a/kernel/fork.c @@ -1420,10 +1420,18 @@ long do_fork(unsigned long clone_flags, int trace = 0; long nr; - if (unlikely(current->ptrace)) { - trace = fork_traceflag (clone_flags); - if (trace) - clone_flags |= CLONE_PTRACE; + /* + * We hope to recycle these flags after 2.6.26 + */ + if (unlikely(clone_flags & (CLONE_DETACHED|CLONE_STOPPED))) { + if (printk_ratelimit()) { + char comm[TASK_COMM_LEN]; + + printk(KERN_INFO "fork(): process `%s' used deprecated " + "clone flags 0x%lx\n", + get_task_comm(comm, current), + clone_flags & (CLONE_DETACHED|CLONE_STOPPED)); + } } p = copy_process(clone_flags, stack_start, regs, stack_size, _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/