Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp960518rdb; Tue, 19 Sep 2023 16:05:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFa8sz5qcRHa5jkT8bDhNYA+11RUUAWIBp7HChdxhlgSl35fq87ZQ6E6DgGQYfPcJipgQVG X-Received: by 2002:a17:90b:1207:b0:268:14a0:f8a with SMTP id gl7-20020a17090b120700b0026814a00f8amr1074259pjb.39.1695164751700; Tue, 19 Sep 2023 16:05:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695164751; cv=none; d=google.com; s=arc-20160816; b=WFL1Ch4z0xZcDJPyJFu8WqWy22JCHUqtwJSkkD8SBLOmr4U8ufDHRuL2pnXHm6ajzc nH4hBuJ881liPzaYO6TJ+azMNkALJlLaaxaOcDnExmSrKUMFdNiurG+v14a9AmSlTZIk EvHsF3+xWi/BQbjyrkJy7+qbJzY9xd1yRlpJGGg8u2UqtVseo/uB/CKddU4Nt+Ycl+Sz V8T/ArC2tYudNYQsoa6MFyzzAmpxcTYrMA3uMHJrGbrFztjPNLrsp+Gl5NE7apRyauft EjyBFqRAF4fnfQWm64r70LoZhFDybzhcULHiav11+OzddYcaZv20xZmxmwO8X0bN+Td7 T5Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vRuXgy6SMVkmzTpxIDL9OtUeypEQpjOawgNTdcvxqeI=; fh=3dhuSEMRfPIYQfBTzdAkRTrcPO/VV4HindK7XbN7Y4Q=; b=dmRWkeZ8lzz9D8TsCg5CcxvbNGL3SxbLC4laAtIihURK8Y2lxdnG3uUIQKgHy2Fhr4 oY0HNZuTvEcpVpi/8UrZcg8jysNtzfsf9fGKPV2wrqny0Vys78npUmZWqFbkQHSXb9by dH/KvT8u4TB0PDTfm50ouYdVRZvttNA+okkjsdmU2KW/3iy++PR2KVpzyg3wyxgcL4S3 l11LuGf2cTcxcXeVHrIWmTfX5AkM06n7aVbTTAehgLoHkhx3g6RxigK0Q8sXU5D0qnGz v5HU6WVwjL6ou689u/XbaJBMoe4bVtuIcp9aW6lA0d0w9YpDLPol4gwghMLeezFIiEFf AXng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D4QmMc9S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b7-20020a17090aa58700b0025de453ee4csi199258pjq.168.2023.09.19.16.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 16:05:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D4QmMc9S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 49F3281410D2; Tue, 19 Sep 2023 16:04:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233527AbjISXER (ORCPT + 99 others); Tue, 19 Sep 2023 19:04:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233490AbjISXD5 (ORCPT ); Tue, 19 Sep 2023 19:03:57 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 475CB122; Tue, 19 Sep 2023 16:03:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 921E5C4339A; Tue, 19 Sep 2023 23:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695164630; bh=Fkuj2wWZmMnPShQV/ULhqGln8Ca5xiurzcw3wVvpsGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D4QmMc9SBynpqOTarnupu5xaA4eHNG/4uPm/vu2d7GbqG1uqiJkF4FcsCMScJLhME dJynJvO7J5fCGyRF1u5WbvVsfUxhCla1FOhJuS0RNf4utFMbh4z5HVNYFRou+tGAHJ A6F2bRa7eF0VT2N29mxpPmby2KXp0WwGXwCy8MXCLRfznf2rTkhOTUV8KdmVTetF/y 6SRgoinWnf6QNSYOh8Y48tEfkfUJ/gApVFIcwetQqNrxqMQl5TJuIITXFCqDdX2OPK vgkyxlmM65zvt5BMkoA2Gtdei4Ys5XEE1PA/n86TADR8TzX61oZ5fbEp8+HcqyAymN IpJiZRIyfG4xw== From: Bjorn Andersson To: Andy Gross , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Lu Hongfei Cc: opensource.kernel@vivo.com Subject: Re: [PATCH v3] soc: qcom: pmic: Fix resource leaks in a device_for_each_child_node() loop Date: Tue, 19 Sep 2023 16:07:39 -0700 Message-ID: <169516485977.787935.14775411918002556697.b4-ty@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230612133452.47315-1-luhongfei@vivo.com> References: <20230612133452.47315-1-luhongfei@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 19 Sep 2023 16:04:17 -0700 (PDT) On Mon, 12 Jun 2023 21:34:52 +0800, Lu Hongfei wrote: > The device_for_each_child_node loop should call fwnode_handle_put() > before return in some error cases, which could avoid resource leaks. > > Let's fix this bug in pmic_glink_altmode_probe. > > Applied, thanks! [1/1] soc: qcom: pmic: Fix resource leaks in a device_for_each_child_node() loop commit: 5692aeea5bcb9331e956628c3bc8fc9afcc9765d Best regards, -- Bjorn Andersson