Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762533AbXKHVxV (ORCPT ); Thu, 8 Nov 2007 16:53:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759407AbXKHVxN (ORCPT ); Thu, 8 Nov 2007 16:53:13 -0500 Received: from pasmtpb.tele.dk ([80.160.77.98]:43372 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754516AbXKHVxM (ORCPT ); Thu, 8 Nov 2007 16:53:12 -0500 Date: Thu, 8 Nov 2007 22:54:49 +0100 From: Sam Ravnborg To: Jan Altenberg Cc: miltonm@bga.com, linux-kernel@vger.kernel.org, linux-kbuild , tglx@linutronix.de Subject: Re: kbuild: possible regression? Message-ID: <20071108215449.GA28242@uranus.ravnborg.org> References: <1193821430.3839.88.camel@bender.lan> <20071031094306.GB24100@uranus.ravnborg.org> <1194551101.6014.156.camel@bender.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1194551101.6014.156.camel@bender.lan> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2214 Lines: 49 On Thu, Nov 08, 2007 at 08:45:01PM +0100, Jan Altenberg wrote: > Hi Sam, > > > > commit 0b35786d77ba4037f181982cc8ca20a7a3bf0fd2 > > > Author: Milton Miller > > > Date: Fri Sep 21 18:09:02 2007 -0500 > > > > > > kbuild: call make once for all targets when O=.. is used > > > > > > Change the invocations of make in the output directory Makefile and the > > > main Makefile for separate object trees to pass all goals to one $(MAKE) > > > via a new phony target "sub-make" and the existing target _all. > > > > > > When compiling with separate object directories, a separate make is called > > > in the context of another directory (from the output directory the main > > > Makefile is called, the Makefile is then restarted with current directory > > > set to the object tree). Before this patch, when multiple make command > > > goals are specified, each target results in a separate make invocation. > > > With make -j, these invocations may run in parallel, resulting in multiple > > > commands running in the same directory clobbering each others results. > > > > > > I did not try to address make -j for mixed dot-config and no-dot-config > > > targets. Because the order does matter, a solution was not obvious. > > > Perhaps a simple check for MAKEFLAGS having -j and refusing to run would > > > be appropriate. > > > > > > Signed-off-by: Milton Miller > > > Signed-off-by: Sam Ravnborg > > > > > > So, am I facing a kbuild regression? > > > > Yes - I will try to fix it during the weekend (if Milton does not beat me). > > Thanks for reporting and bisecting! > > Have you made any progress on this? Let me know, if I can assist with > testing. Hi Jan. Not at all. My limited linux time goes into some x86 unification that I have given higher priority. But your report is saved and I will return to it. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/