Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp986659rdb; Tue, 19 Sep 2023 17:09:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGtH3Axy+dicWEB5kobx6vHrMVzK+knp0WrI/Y83T9t/u2i9OVpHrfP+v4AZzJlm+T+zk7 X-Received: by 2002:a17:903:22c9:b0:1c1:d4f4:cd3c with SMTP id y9-20020a17090322c900b001c1d4f4cd3cmr1136306plg.31.1695168589023; Tue, 19 Sep 2023 17:09:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695168589; cv=none; d=google.com; s=arc-20160816; b=dlB1HwV3+qZQTYB0whJ9qZp+4d6a+8Omlu9o6o7Kkrypb+ERM74MS5IVNiX5ZrV/ur xNKC+Sj1I1QaU83rnr6DIs+dGXFolobozsGkeFSr+rhwhymopAeMBSSZJeF+vA9V8Vv4 D5cwrE9LkhwdstGU3QAzAnw1B2gE+tVi18Xnws5dQge5UVS8YAuxIg62wLhd5qKwRfzl 3mai2PAQxpTUvdKmGYhJLQCWVUKCgxj1PBqqEGBfQobyhxtTGiDAw3AyeZz3mEXyv31Y vu09aYAORXJiHA9pCf2l+iORBTvmiTZf+nbJAlUVYRCNNikQ/J1pgHFA5WXvTHv3mT6k H1Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=jbv6kYF5LAnBAKfQVCXWbWgoEDd6+dn0k6YSe4iFkVc=; fh=AK8AHMMTVqg4pUGhemDC8DCj8ddU+ilqtbZUxVzhwHw=; b=wlUsDymLwmBbiGqvz+f31IJGV0wMy1K/ANCtemFjVyK0yY23TwPQZrL4aHKfwhHfCe wJI76wo38RLOiraBaVmxHx2DlDhNDPrY/r+/fsE7uisnyxrmSouM8Nk4oxa9hsngNDBu Exf8qZwZhjuiDY4zqS+FGwG/K4t845z/4uDBfn23SNxwcBBemx+VxSTpJqKPfl3f/1r/ vzZ1TCxZ3E/w9Oae1ppQtWWsWCzHFfgghxEF0aLzfhN0pZcz78PevcON3QlZ42TsOXVQ oyyhhOn+2D/sFgnoofj17ILgY6S3V2XXqOsxMd0Pr5ivfFyDfi4I7oGEZ39CcPKKu8+X HAWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Di/0d3bU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i17-20020a170902e49100b001c3a2e70278si10528924ple.437.2023.09.19.17.09.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 17:09:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="Di/0d3bU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3A20A842AD11; Mon, 18 Sep 2023 11:45:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229718AbjIRSpi (ORCPT + 99 others); Mon, 18 Sep 2023 14:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjIRSpg (ORCPT ); Mon, 18 Sep 2023 14:45:36 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2B26F7 for ; Mon, 18 Sep 2023 11:45:30 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c1e3a4a06fso37661955ad.3 for ; Mon, 18 Sep 2023 11:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695062730; x=1695667530; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=jbv6kYF5LAnBAKfQVCXWbWgoEDd6+dn0k6YSe4iFkVc=; b=Di/0d3bU9RLhwtZcLEupgy/Zc4xtQ9gYQnS+evvdrJgdlyg37iWcD0rG+esF2bEAeQ f6NwPPQHBaQQq6pru2CCC6g4O+GnnRmNgLFinBFlaVdmNkAGWHZjQRMyhy/i/HBh9eWt EagbsOOSOGbsdeOTD+mc1AVooT7z5G+poyrU7nEUiGDYebkdxXrGi/lodAsJFQ8W+VbH DeZF29SkKHT0Tk0gMj72tNBaRDAz7hBp0NZLrtMyhqc59Fb9wcLbJXIb/phz1baX13iT A/HvsNYpCS2RP7O32y2ytvcF7gcQ+tCukWTIbPTXPSFusBu5TG/noX8Lw9a4opitkwig N7Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695062730; x=1695667530; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbv6kYF5LAnBAKfQVCXWbWgoEDd6+dn0k6YSe4iFkVc=; b=lfmfHPhIB2m9SE+qd9O3MTMrMIkZcY9IPAZo/eF6fbKhLrX8AZB6f4k+s/zDaTwT9s yRqukREFu66l+Ax2hQs8NtA8UFg+3W68Lkwpq+THHxyguN6809znZDMnze2NOqB54hB3 +AfN4vq/d2f3nkUtnTukwyWX+ukJ0U+5nvag6JwrJ6L1nYIgO33dKBvwtogMPQYPcSSl 7i0giMqKbPd4G53rsWdx+X4DJWZM09GBX1Ka/1ARQtC0v7B/2poQeMRAOE3a3AAudyzS an7jVhc+nt1EAZoZClK79sjhtFLfHl2lJdLEAX8zAfWitlzacLkWxzykl8+lM1rdA3mx wTeQ== X-Gm-Message-State: AOJu0YwVVEgUjKk+flxqY6496XyV20WFoWUVayUnMZ/xJrcjQiWzhOjh wrz40RBnHbuiiQl4gVbN77s= X-Received: by 2002:a17:903:11c8:b0:1c3:e30f:6c82 with SMTP id q8-20020a17090311c800b001c3e30f6c82mr9408861plh.53.1695062730362; Mon, 18 Sep 2023 11:45:30 -0700 (PDT) Received: from localhost (dhcp-72-235-13-41.hawaiiantel.net. [72.235.13.41]) by smtp.gmail.com with ESMTPSA id f15-20020a170902ce8f00b001bf6ea340a9sm8598702plg.159.2023.09.18.11.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 11:45:29 -0700 (PDT) Sender: Tejun Heo Date: Mon, 18 Sep 2023 08:45:28 -1000 From: Tejun Heo To: Catalin Marinas Cc: linux-kernel@vger.kernel.org, dhavale@google.com Subject: Re: [PATCH] workqueue: Remove duplicate worqueue attributes allocation Message-ID: References: <20230906173904.475722-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906173904.475722-1-catalin.marinas@arm.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 18 Sep 2023 11:45:37 -0700 (PDT) On Wed, Sep 06, 2023 at 06:39:04PM +0100, Catalin Marinas wrote: > Commit 84193c07105c ("workqueue: Generalize unbound CPU pods") > inadvertently introduced another call to alloc_workqueue_attrs() > overriding the pointer returned by a previous alloc_workqueue_attrs() a > few lines up in workqueue_init_early(). This leads to a kmemleak report: > > unreferenced object 0xffff000040015000 (size 96): > comm "swapper/0", pid 0, jiffies 4294892296 (age 163.956s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 03 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<000000004cec0d50>] __kmem_cache_alloc_node+0x1c4/0x288 > [<0000000083361c2a>] kmalloc_trace+0x20/0x2c > [<000000005ca61f11>] workqueue_init_early+0xe4/0x538 > [<000000004e6ea358>] start_kernel+0x23c/0x5ec > [<00000000aea9761e>] __primary_switched+0xbc/0xc4 > > Remove the first allocation. > > Fixes: 84193c07105c ("workqueue: Generalize unbound CPU pods") > Signed-off-by: Catalin Marinas > Cc: Tejun Heo Another version of this patch has been applied to wq/for-6.6-fixes. Thanks. -- tejun