Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
From:   Huan Yang <link@vivo.com>
To:     SeongJae Park <sj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        damon@lists.linux.dev, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Huan Yang <link@vivo.com>
Subject: [PATCH v3] mm/damon/core: remove unnecessary si_meminfo invoke.
Date:   Wed, 20 Sep 2023 09:57:27 +0800
Message-Id: <20230920015727.4482-1-link@vivo.com>
In-Reply-To: <7b38eb40-1d74-4308-ae9a-b6aa91a46833@vivo.com>
References: <7b38eb40-1d74-4308-ae9a-b6aa91a46833@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uGiiGr5Slk+c71/58ubIdJ2e6n29/EqsyTpDubSFRT79+nvvvTANGgXa05jB?=
 =?us-ascii?Q?ka8FaZ5MTZy1cGQ7DlrHQmbAXZGeaw4pH4BUkWg+lZvJEx1KDS3WqqVfO+vO?=
 =?us-ascii?Q?bODV/aP64ZCygZJWQinGHMV6eS/400PVzIF7srDwvS2iwJpGUj2+Fzni7GdJ?=
 =?us-ascii?Q?8xJBZINOwnMv3BaXYvjYe0rKkGKVPcS5o1V/f9iFpAhLO/itpXe2fqKv/PHH?=
 =?us-ascii?Q?DW8tL3KcIkNybQuFNWSAh05bz+e9MvXdJimtiwIwndlJDsRPG68o1bO5WlZy?=
 =?us-ascii?Q?PiRngHJYnAGGQOgIsQEkU2AfRtNjy3B1o2SsoyIwXTejj91Nvm1B7jH04kbV?=
 =?us-ascii?Q?Q6vQZTA4Rg4OTtgSKoLk5WaYwPAb7Httbcod2IIHmsPMLcb4Jfpw3sVX6eB3?=
 =?us-ascii?Q?FVqefq5wGK1I5K/6AJC1liVlHgH63CXPLrYa5vK7ogOBwbqq+mBLsiQhoMzW?=
 =?us-ascii?Q?Ez9NK4vA+dbnhFvN+A+i6j9R58E9VZw2B7KGgslCDmBogq/UsTfkrNZcqz1d?=
 =?us-ascii?Q?NHPP9LkouzJleA9zuYEAYi5K/vLd2ZAIDvzuaHhhAx/IRH9zG8D0c+s6CPB6?=
 =?us-ascii?Q?3mvg9SPn4qBNjggJ47yydHFCoSdxkZqyZGFHjCEMnOdkmnsHUsyEBVEkQ2kO?=
 =?us-ascii?Q?F4ZWzoMwoXvQUUgF+7GQG41eKpfpp0qXzH/KxcVx1yNYwUtrw5nBWOLqVZ3x?=
 =?us-ascii?Q?6fze/J+gPZEyKfUyIvegeKT5iqJhll0/xILpBcEm51ZyRDOeIK4KdAEqPuiX?=
 =?us-ascii?Q?SbrGCH5NgcLiAXUn2/wsj1SZw5qQEBxskKSCwdbYWTV/knvuVTVKDTvUGMtW?=
 =?us-ascii?Q?tRVlcHcgyE0dFGkezba9McVl0R7N15PUzitisWZFOny0kFb/3gq2kxrrG6V7?=
 =?us-ascii?Q?2Kicn3jAJylAOQoIOoSbFE4JD6H24VRDqC/RL6FpCz+N9tnEQm8R8Ssmaf+M?=
 =?us-ascii?Q?Z4ukZEerREyWQb+uVrY+T2EZIYoSkWxNexfkhmtyJGNJ8n/9anhvo1Ebl6LT?=
 =?us-ascii?Q?tRMf/x7nDKda9AqKpCTxMXiMCljw0ytDk2JndjlapMkcj/DVVpAVAAZYwajr?=
 =?us-ascii?Q?cMZkns1pUiAIeygbXGoLUMHaH4uHV0i6Z2AZOULUGH+xbcJQfe9zxqjQ2BEx?=
 =?us-ascii?Q?sN3hNTrwKZu+4jxkgr5uj/xQNzmsLfs215/Yo7Aj2xNwCyLMt/niIM37icZo?=
 =?us-ascii?Q?j1CR9Gm39PG73+GUGlKOX9FW3G2lo/O4IuSRj20doxoaTx2B9es2jquh+m1U?=
 =?us-ascii?Q?clcAxM7/1/56QKfyiE5pnrACNyEXJZpbvp16tI5hD9YhPCOUhy+h6JwM7eh0?=
 =?us-ascii?Q?WxK1vDIMvRdbRgGJt7Imc4FbglhLSOlXML0ckVSpGoW7vhDhoLFh0YdIgoNZ?=
 =?us-ascii?Q?xfgQk8f8Tj4OmsSACVD/XGWz2WyeFn4StALOF5vdOYuvzVzwqOq6twnDLb8c?=
 =?us-ascii?Q?jhCXH5O8+uZ20jD9VaShvh3Ub/6k120AMcn3CCrRaTHOyWl4jAW7bRr+6lge?=
 =?us-ascii?Q?lmFqELabhT1TYCVPX5E2m/7NdK+WgFDLZTZpsvO5CXl6o5+rAHmGb8o0kXsM?=
 =?us-ascii?Q?Si6veQ8fX8YEWFy1vPdz32rXiTX67h9CS9uEvlzN?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4df8955f-c3c3-4611-e571-08dbb97d17e4
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 01:58:32.8529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JmtY0Cz8HzitpF8N+RNy0TXqk79KD/ijUx4huF+/s6s+sLBRdbyCY007Of2dfD8gEF4xeIcwqFJac2DktvsBSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6954
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 19 Sep 2023 18:58:44 -0700 (PDT)

si_meminfo() will read and assign more info not just free/ram pages.
For just DAMOS_WMARK_FREE_MEM_RATE use, only get free and ram pages
is ok to save cpu.

Signed-off-by: Huan Yang <link@vivo.com>
---
Change from v1:
v1 fold free mem rate logic into __damos_get_wmark_free_mem_rate and not
invoke si_meminfo, just get free/ram_pages in global.
v2 cancel this __damos_get_wmark_free_mem_rate and just calculate rate
in damos_wmark_metric_value to keep it simple.
v3 fix changelog format, fix code style.


 mm/damon/core.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index bcd2bd9d6c10..6ceb52298904 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1280,12 +1280,10 @@ static bool kdamond_need_stop(struct damon_ctx *ctx)
 
 static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric)
 {
-	struct sysinfo i;
-
 	switch (metric) {
 	case DAMOS_WMARK_FREE_MEM_RATE:
-		si_meminfo(&i);
-		return i.freeram * 1000 / i.totalram;
+		return global_zone_page_state(NR_FREE_PAGES) * 1000 /
+		       totalram_pages();
 	default:
 		break;
 	}
-- 
2.34.1