Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1044376rdb; Tue, 19 Sep 2023 19:45:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgsMvlK/JzjRTILdFQ2frOmR0lWZ/SZyiRMCjiS+kI7kwoGc0zPD74V5FTWMqyChEIwWTF X-Received: by 2002:a17:902:bd43:b0:1b3:9d13:34b3 with SMTP id b3-20020a170902bd4300b001b39d1334b3mr963780plx.37.1695177943433; Tue, 19 Sep 2023 19:45:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695177943; cv=none; d=google.com; s=arc-20160816; b=bIzUq/Val38HlFdo6kjmy5owoE7M4m7zdqgn9pbkahOWt+X7ESHUEzN79drSNH61nJ p/yOKP2x+o5iNMbVPewqgx0cBsdpwIwR4YkKdkUrigGNT8DTpIlDoMD4KRFd8N3QJ9lk 3DZFkdaMeyqN+v/FPl8QbUoPg4bra2/n6h4xVYXWVaxBI673KP0B+/Tfy3Mb3xD7RJaR o6UMZ4JlImvOm3fGn2a2XRJ+QVLNiUpitewucxUXwj0IZhXxSrs6XI+k+bfXdDLDvor+ QiZ6GHcSkQQL8zG2TExDSOE51Xpsa7YH14ZY7CVKXF+DbxW3zNYdFznq2Q1ba5GT0BIK KzWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=MSD6lpVbHBqAtzSxV7kIH7qFpEjKvTmQlWLkLF1u4Ms=; fh=X89GPmbtIE4psg3wkYEzmZ6H+GwCUe6QsZlNtix1yi0=; b=GnER2nvyvZowB2X7uFEVjwTQczH9aAnztB+o+yvgP9zhhns7XNekYCHD3BuUE5mru+ mh/ONw6TZ4e2MSulOoYJ63f6YBaO8gewoBPiJLVZkpWIMPcJVI8SjZ19F6/Fjv2GSrIV 4JSf+lmdOjlykl0uGpa/g1l5vUul1h9V5CXrMLzcUFB/JotNcQLhDkgyKo4QY98C/Wj9 XIsf+YTJlX5AbOZ/nDpPeC37mNhpqIUhky09nEOPyge5c2HdE4h5imVkvrSoH9O6u5er BJq4ObvgPTny0RdvWNJL8rx00LfV1Y7lvNC/JKq7JCpH4B9B2FuG2hjduI9BS4uyU1Qv MjhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=bto8GwMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id j3-20020a17090276c300b001c34abf9f2esi10800324plt.110.2023.09.19.19.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 19:45:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=bto8GwMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8CB8883B6BF4; Tue, 19 Sep 2023 12:03:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233186AbjISTDX (ORCPT + 99 others); Tue, 19 Sep 2023 15:03:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233193AbjISTDI (ORCPT ); Tue, 19 Sep 2023 15:03:08 -0400 Received: from out-223.mta0.migadu.com (out-223.mta0.migadu.com [IPv6:2001:41d0:1004:224b::df]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAD48E42 for ; Tue, 19 Sep 2023 12:02:42 -0700 (PDT) Date: Tue, 19 Sep 2023 15:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695150158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MSD6lpVbHBqAtzSxV7kIH7qFpEjKvTmQlWLkLF1u4Ms=; b=bto8GwMS4ZTGGH/Mwp3my/ZOHXdRpU/xssFyvCL/f5UtNmlfivvStIOJk7cCa/0RnOXdzz lsvbQOoov7JH2QJc3I7pqop/1EeDaHKwBW1FuNrNPb+EYmG7a9MDcftcjoRDogfN332Piz BVrGq0jZ60/miy5kkCd7pJEEpk5W/ko= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Brian Foster Cc: Christophe JAILLET , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-bcachefs@vger.kernel.org Subject: Re: [PATCH] bcachefs: Use snprintf() instead of scnprintf() when appropriate Message-ID: <20230919190234.2k7v75htqlbfqofh@moria.home.lan> References: <9a998be3e2dbedcd3a9eae5f81ae6dcc6c0f98c4.1694849375.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 19 Sep 2023 12:03:38 -0700 (PDT) On Tue, Sep 19, 2023 at 09:17:27AM -0400, Brian Foster wrote: > On Sat, Sep 16, 2023 at 09:30:19AM +0200, Christophe JAILLET wrote: > > snprintf() and scnprintf() are the same, except for the returned value. > > When this value is not used, it is more logical to use snprintf() which is > > slightly simpler. > > > > Signed-off-by: Christophe JAILLET > > --- > > Seems reasonable: > > Reviewed-by: Brian Foster No, let's stay with scnprintf as the default - snprintf should be deprecated except for when its return value is actually needed, using it incorrectly has been a source of buffer overruns in the past.