Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <048e48bb-24da-f23d-50e0-477430d58bac@intel.com>
Date:   Mon, 18 Sep 2023 10:45:31 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 03/10] platform/x86/intel/ifs: Image loading for new
 generations
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        "Luck, Tony" <tony.luck@intel.com>
CC:     Hans de Goede <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Xu, Pengfei" <pengfei.xu@intel.com>
References: <20230913183348.1349409-1-jithu.joseph@intel.com>
 <20230913183348.1349409-4-jithu.joseph@intel.com>
 <ba753b39-1819-35ff-1248-6ce2c2824ae9@linux.intel.com>
 <e084652a-91a0-0c16-7acb-d51a3d2f7ed5@intel.com>
 <10fe57c-c926-9de4-be84-21a0f8abab6d@linux.intel.com>
 <SJ1PR11MB6083A4237D928F180B6DB1E1FCFBA@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <56b486ce-2a6e-c4c7-8bc5-ceeb7119ba1@linux.intel.com>
 <SJ1PR11MB608304A84A2B662C78FDB677FCFBA@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <a02d2957-3ec4-f89c-ebe-474c3987b237@linux.intel.com>
 <826a2b32-bd6a-900a-19fa-e169fcf0d29d@intel.com>
 <789bc8e6-882a-3dfb-7381-fd9b5aca3c77@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <789bc8e6-882a-3dfb-7381-fd9b5aca3c77@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vm1NU1dPbDIxSEtVcEtSQlVyMWJJb3FXWkZpWnlaNlphd2JxNjFNbFowUDZS?=
 =?utf-8?B?NVRvYW03R2lBVXJEdUV5Tk95aFRMcGNlUXF4TlVJaHVOTDA1bHI4aFEvRWJk?=
 =?utf-8?B?ZmFsaHh1eWUxWjZvdlpHWHdyS1dtU0tNS0E2eWhhMTU1K0YxVEtvcWxBV0N4?=
 =?utf-8?B?eXIvS293RG5PUVpuSmZYRlNNMlFmQnovTW5tRmFJVmM0TWRnbk5pU2dKanFj?=
 =?utf-8?B?dmNCbExJSjdvdXAwWGJpTzdib3ZINmpHUGFta241N1V2bGxSSENWTkVVZWo2?=
 =?utf-8?B?dFJ2K2FSUFA3NmxVN2I3VWltUzNmd0FQS1pxRTlxRnFCcWYxR0l5THYwWExC?=
 =?utf-8?B?R2t4UktobUxIVHZET2Y4ckw0bFFFV3Z6a3RLRlJPb1c5OVlKR0NVOU9xVUdi?=
 =?utf-8?B?aUNFdlVGSzRpclQ1cGRZVUtteHRHWFhtMEFudjQzT0o2MDU3S0VlRTFxUDJr?=
 =?utf-8?B?V2FHNkVSd3p3MjR2aTV5QXQ4YS9rdzcvQTh4R0JRME9LYWlpUEYzbCtIZk1V?=
 =?utf-8?B?bGhCRWRvTFpWWHBydjExSWlsdVlNYTNNZW0zY2l0aVlvOXNWSlF1Y3dvNlVx?=
 =?utf-8?B?cGJVdnJGbVlsVWxyU1dsVkx2cUlRaFVuVEQ0ekFqcHhoa0VNVXdTYnpRcWdj?=
 =?utf-8?B?di9uNm5oaGdIUjhSZmQ2MHROQ3FOTWhjbnBBOXVTeWV2aTh4Z2c1WGRHQys3?=
 =?utf-8?B?OUk4TUpybjRlb0kvb3ZGNk5ReHlLY1k1Kzh4NGtzL0htOUkwUmM2cEtEY202?=
 =?utf-8?B?ODBVQ3hqd0hYaFRUT1diU1Z0MldybGRyK3c1NmcvbG5PZFJxbVJ4ek05MHlE?=
 =?utf-8?B?bjBKMW03NDgyTTJOb0FoRjMwSG1pUHJXZTFyNEZsVy9IanVqMWJ1VXhqbG9S?=
 =?utf-8?B?aURQS0JMZGxtT2FYRWpUcnpNdWtmMFNJMFp3d2h5ZElOaWdPVzBXMjNTZkhG?=
 =?utf-8?B?anFKZXZ1YU5aN3RQSmRFdWw5NG5JUHV2ZVhPTXh3TnlSWEpyRlpKUjNLVnMz?=
 =?utf-8?B?Slo1K3l6aXQrZWhlYnpQR2ZleFZhOVhneUNpQjhCZjBGUEJwSnljbTFXWmJt?=
 =?utf-8?B?YXBURVEvSXNnU1NHZ0Y5U3ZwUy8rWC9mVDd0cHQwcFBGTXBtcVBmNm5TenN5?=
 =?utf-8?B?Wlh4SU9hK095K2J4K1Zpem9aQ0t5bUQ3TEp4b01DYnUzR3dpRTlLTDhVZ0wr?=
 =?utf-8?B?V0thVXcrcmpXOUdrYlR1bDVkM25YaWhCdy9ucm5lV3VNL0hwMkZHd0FmeCs3?=
 =?utf-8?B?ZktQd2gzb0dBUlZwbmZHU2ZIMXVhNHZkQ2RJVkJ5K09SYll6bU03SHp6L0V3?=
 =?utf-8?B?djc0ZFdBaklUT0tJQzlhQ3FCYmwrQjZ3eER2Rk1qQmk2bVhsazQ1dWdzOXZv?=
 =?utf-8?B?TVVkanVVaCtWUkRMQUV1MDRpOXYzdFh2QVY5MGU5RUhFRUErRksxekVoTFlp?=
 =?utf-8?B?ZFY1YmYzcUR5eGV6UlFkNldaazZzKzZOOTV6dGxBVVNTTHA2S014U0ltQVNa?=
 =?utf-8?B?cXl1RGY4ZFQxeVh2SkJKZkJMZU9EL1FDWG9ZK2pEdVdwQ0xLMHJvdnZYenJm?=
 =?utf-8?B?TEpNTm0xdFFjM2lyZ2RYdnhRcWhDOHE5cXB1eUpoL0Y2N2Z4MUM0ZHJtT1hI?=
 =?utf-8?B?RTFXUHk1STJyUmc4OVIwOFhqK3N4NUtUSkJKTGplV25iazBkTFd2ZG52Q2d3?=
 =?utf-8?B?NTI0TFBJdzR0K0hGeG5uaWhycUVkVGwzVTZ5a2lQRTB6Q3hvcU82L3BBWWpK?=
 =?utf-8?B?VnVrZFZzVUZrU3BScGJMTnpkRGZiUlVZbWFqSGxVdnhBNUEwT0pOaGZQU3NB?=
 =?utf-8?B?QlVoMUl6dnA4R3gyWllIaklVaGQwSElnMGw4NkxETytiU1QxQ3czYmhrSXhw?=
 =?utf-8?B?K2kvOUJkWVEzaFhDQW9nMk9Sa1lkRXhnOTArT2VCb1kxVjJ4aXhHTkorSWZM?=
 =?utf-8?B?cVhtQkN5UFVqUzdtVzNPdXJkYkVwUTdkRkMxTTEzb0lvMU1oaEY3WTFSYU9F?=
 =?utf-8?B?bHZnNXd5ZC91Mjc5Y254dmV1NDUzNEVmWVR6U2s3NnVYc0dWTW1LNC8wTE9Q?=
 =?utf-8?B?cml2ODlBS2pKeWdMR0Noa3E1N3A1MThISzc1Y29zTGRxZ1VrWXIrWFRROGhW?=
 =?utf-8?B?M1VNWnpkblVUSXc2RE5vS2VhMzRlN2Y5dE9EaXpDY3B0N0t6dW1OVFJkdkRR?=
 =?utf-8?B?OWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 38d48eb9-b348-498e-0242-08dbb86f104e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 17:45:35.9413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BfMe07Yvu4He0WmjxFGWfNSgwUiMA8h3MAEYHJS9J2j3eV1gvQL8WzNvwfqyhwX4vH+6Lse65k4brKIdtAzz/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5067
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 18 Sep 2023 10:46:49 -0700 (PDT)


On 9/18/2023 9:58 AM, Dave Hansen wrote:
> On 9/18/23 09:51, Joseph, Jithu wrote:
>>
>> On 9/18/2023 9:29 AM, Ilpo Järvinen wrote:
>>
>>> In this case it is not just about the bitfield itself nor the bit 
>>> allocation order but sharing the storage unit with another member, and to 
>>> further complicate things, members have different alignment requirement 
>>> too (32-bit aligned u8 followed by u32 bitfield).
>>>
>> I too verified that the size of the whole structure matches that of MSR  64 bits (8 bytes). 
>>
>> Initially when IFS scan was added the  all MSR structure members were  bit-fields, later there was a suggestion to
>> use basic C types if applicable during subsequent Array BIST patch series. I followed this approach with the  current patch series . 
>>
>> I will change the current series to use all bit-field MSR structures in v2, given mixing basic types and bitfields is a a source of confusion
> 
> That's the wrong direction. :)
> 
> What is more obviously correct.  This:
> 
> 	struct {
> 		u16	valid_chunks;
> 		u16	total_chunks;
> 		u8	error_code;
> 		u8	rsvd1;
> 		u8	rsvd2;
> 		u8	rsvd3;
> 	};
> 
> or this:
> 
> 	struct {
> 		u16	valid_chunks;
> 		u16	total_chunks;
> 		u32	error_code	:8;
> 		u32	rsvd		:24;
> 	};

I will go with the second pattern above, given that pattern can be followed for other MSR structures too, where fields doesn't split as evenly

Jithu