Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <1695114428-20308-1-git-send-email-yangtiezhu@loongson.cn> <7aa1e5a0-c161-08d6-a2fc-0d4f65148b01@loongson.cn>
In-Reply-To: <7aa1e5a0-c161-08d6-a2fc-0d4f65148b01@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Wed, 20 Sep 2023 14:28:08 +0800
Message-ID: <CAAhV-H74iDp3Sv8CaJAoS1yEUYsQFkNRVABSNYz23zXAqnCrfw@mail.gmail.com>
Subject: Re: [PATCH v1] LoongArch: Remove dead code in relocate_new_kernel
To:     Jinyang He <hejinyang@loongson.cn>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Queued for loongarch-next, thanks.

Huacai

On Tue, Sep 19, 2023 at 5:24=E2=80=AFPM Jinyang He <hejinyang@loongson.cn> =
wrote:
>
> Not need my tag. Youling found that before, and simply talked about it
> to me.
>
> Thanks.
>
>
> On 2023-09-19 17:07, Tiezhu Yang wrote:
> > The initial aim is to silence the following objtool warning:
> >
> > arch/loongarch/kernel/relocate_kernel.o: warning: objtool: relocate_new=
_kernel+0x74: unreachable instruction
> >
> > There are two adjacent "b" instructions, the second one is unreachable,
> > it is dead code, just remove it.
> >
> > Co-developed-by: Jinyang He <hejinyang@loongson.cn>
> > Signed-off-by: Jinyang He <hejinyang@loongson.cn>
> > Co-developed-by: Youling Tang <tangyouling@loongson.cn>
> > Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > ---
> >   arch/loongarch/kernel/relocate_kernel.S | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/loongarch/kernel/relocate_kernel.S b/arch/loongarch/k=
ernel/relocate_kernel.S
> > index d132525..f49f6b0 100644
> > --- a/arch/loongarch/kernel/relocate_kernel.S
> > +++ b/arch/loongarch/kernel/relocate_kernel.S
> > @@ -72,7 +72,6 @@ copy_word:
> >       LONG_ADDI       s5, s5, -1
> >       beqz            s5, process_entry
> >       b               copy_word
> > -     b               process_entry
> >
> >   done:
> >       ibar            0
>
>