Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <d5d98e74-97cf-62fc-c72c-9081073708d2@ti.com>
Date:   Wed, 20 Sep 2023 09:47:27 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander
Content-Language: en-US
To:     Andrew Davis <afd@ti.com>, <nm@ti.com>, <vigneshr@ti.com>
CC:     <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230919050340.16156-1-r-gunasekaran@ti.com>
 <3e4fb573-3439-5d5c-866d-75bc20732d92@ti.com>
From:   Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <3e4fb573-3439-5d5c-866d-75bc20732d92@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9/19/23 5:51 PM, Andrew Davis wrote:
> On 9/19/23 12:03 AM, Ravi Gunasekaran wrote:
>> AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
>> The expander at address 0x38 is used to detect daughter cards.
>> Add a node for this I/O expander.
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> index f5c26e9fba98..035b20386ef3 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> @@ -381,6 +381,13 @@
>>           interrupt-controller;
>>           #interrupt-cells = <2>;
>>       };
>> +
>> +    pca9554_1: gpio@38 {
> 
> As this is at a lower address than the other expander(39), why
> not put it before that one to keep these in order?

Sure. I will reorder the placement of nodes.

> 
> Also, do you need the label(pca9554_1:) for anything, if not
> drop it for now.

The label is not needed at the moment. I will drop the label.

Thanks for reviewing the patch. I will make the changes and post v2.

> 
> Andrew
> 
>> +        compatible = "nxp,pca9554";
>> +        reg = <0x38>;
>> +        gpio-controller;
>> +        #gpio-cells = <2>;
>> +    };
>>   };
>>     &mcu_i2c0 {
>>
>> base-commit: dfa449a58323de195773cf928d99db4130702bf7

-- 
Regards,
Ravi