Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
IronPort-Data: A9a23:XOu7eKvTXW8iBOuehyK7C8uvTufnVHxfMUV32f8akzHdYApBsoF/q
 tZmKVkyQEty1hlBgm0KGI+zxf6LyZfVzubXKHJtqTc3CSgiRfPtXbyxNl33Mz6ZMvrNRUdm6
 9R2QtTbJajYdFeFzvuWGuan9SMUOZ2gHOKmU7aVYHgpHGeIdQ964f5ds79h6mJXqYXha++9k
 Yuai9HSPlajxwl1Pgo8g05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKEpfNatI88thW5
 gr05OrREmvxp3/BA/v5yeyjKhVirrT6ZWBigVIOM0SuqkQZ/HRqis7XOdJEAXq7hQllkPgh4
 +ROkaWPZzt4Ba/jmrowCzpDTgNHaPguFL/veRBTsOSglhycNSKyk7M2ShtsCOX0+M4qUScQs
 6ZCdnZXNkDra+GemdpXTsFjnMksMc/kMZkSoFl/wCrFC/s6B5vERuPD+Le02R9s2JwRQa6BP
 ZNxhTxHc0nJXgVsOlMtB7kbruSEgGm4ImIBgQfAzUYwyy2JpOBr65DBOcTUdpquTMRanlqwr
 2nb+23zRBodMbS31juB9mOEh+nBhyr3VYseUrqi+ZZChFyV23xWCxAMU1a/iee2h1T4WN9FL
 UEQvC00osAa8E2tU8m4UQa0rWCJujYCVNdKVe438geAzuzT+QnxLmwFSCNRLdU8v88eWzMnz
 BmKksnvCDgpt6eaIVqB8a2KpDe+IgARLGkfdWoKShYD79D/oYY1yBXVQb5LFra0gdL0Hxn/x
 jmLqG41gLB7sCIQ//jruA6C2Wjy48KRHkgp/grWGGmi60VweeZJerCV1LQS1t4YRK7xc7VLl
 CFV8yRCxIji1a2wqRE=
IronPort-HdrOrdr: A9a23:EEVSbKwHnZStNrEIjHS/KrPxceskLtp133Aq2lEZdPU1SL3kqy
 nKppkmPHDP6Ar5NEtOpTnCAtjnfZqkz+8X3WBJB8bBYOCEghrNEGgB1/qZ/9SIIUSXnYQw6U
 4HSdkYNDSaNzlHZKjBjjVQXOxQueWvweSDgaP3yH9pXRtrcchbnnlEIzfeOEkzaA5YCZ8+DZ
 b03Ls3m9MMQwVuUu2LQnEZW+DCotfPko7qJQUBGwMqgTP+/Q+A2frzDhyR3hIVVjVSzPM56G
 DA1wTy+6WktJiAu2Ph/l6W54lTkNvlwN5EGMHJkNEcLnH2hh+vf5kJYcz8gBkl5MuUwBIBlt
 3UphcpOM5+r0nWYnq+rXLWqmzdOXIVmgTf9WM=
Message-ID: <1b677562-929c-62f7-353d-80af3c30c7c4@westnet.com.au>
Date:   Wed, 20 Sep 2023 17:15:56 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH 09/17] m68k: Implement xor_unlock_is_negative_byte
Content-Language: en-US
To:     David Laight <David.Laight@ACULAB.COM>,
        'Matthew Wilcox' <willy@infradead.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        Nicholas Piggin <npiggin@gmail.com>
References: <20230915183707.2707298-1-willy@infradead.org>
 <20230915183707.2707298-10-willy@infradead.org>
 <6e409d5f-a419-07b7-c82c-4e80fe19c6ba@westnet.com.au>
 <ZQW849TfSCK6u2f8@casper.infradead.org>
 <e1fb697714ac408e85c4e3dc573cd7d5@AcuMS.aculab.com>
 <ZQmvhC+pGWNs9R23@casper.infradead.org>
 <cffc2a427ae74f62b07345ec9348e43e@AcuMS.aculab.com>
 <ZQm67lGOBBdC2Dl9@casper.infradead.org>
 <c61a58a1f5a34f2b96c6043840635197@AcuMS.aculab.com>
 <ZQnCiZuMbFnwbEUt@casper.infradead.org>
 <bfbf4d9ae5674d5dbe8c509abf5b0f84@AcuMS.aculab.com>
From:   Greg Ungerer <gregungerer@westnet.com.au>
In-Reply-To: <bfbf4d9ae5674d5dbe8c509abf5b0f84@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 20/9/23 01:57, David Laight wrote:
> From: Matthew Wilcox
>> Sent: 19 September 2023 16:47
>>
>> On Tue, Sep 19, 2023 at 03:22:25PM +0000, David Laight wrote:
>>>> Anyway, that's not the brief.  We're looking to (eg) clear bit 0
>>>> and test whether bit 7 was set.  So it's the sign bit of the byte,
>>>> not the sign bit of the int.
>>>
>>> Use the address of the byte as an int and xor with 1u<<24.
>>> The xor will do a rmw on the three bytes following, but I
>>> doubt that matters.
>>
>> Bet you a shiny penny that Coldfire takes an unaligned access trap ...
> 
> and then the 'firmware' silently fixed it up for you a few 1000
> clocks later...
> 
>> and besides, this is done on _every_ call to unlock_page().  That might
>> cross not only a cacheline boundary but also a page boundary.  I cannot
>> believe that would be a high-performing solution.  It might be just fine
>> on m68000 but I bet even by the 030 it's lower performing.
> 
> I do remember managing to use 'cas2' to add an item to a linked list.
> But it is so painful so setup it was better just to disable interrupts.
> For non-smp that is almost certainly ok.
> (Unless the instructions are slow because of synchronisation.)
> Otherwise you need to use 'cas' on the aligned word.
> Assuming coldfire even has cas.

It doesn't. See CONFIG_CPU_HAS_NO_CAS in arch/m68k/Kconfig.cpu for how
m68k deals with ColdFire and early 68000 parts not having it.

Regards
Greg


> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>