Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1166109rdb; Wed, 20 Sep 2023 01:11:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLHqNudqbQdi+aUixw7sRyZv8N7S1cz3IvyPe8x5J22hQnVkKcV18DynKsnJbHGdGYU3UJ X-Received: by 2002:a17:902:e5cd:b0:1b0:f8:9b2d with SMTP id u13-20020a170902e5cd00b001b000f89b2dmr1932125plf.29.1695197506053; Wed, 20 Sep 2023 01:11:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695197506; cv=none; d=google.com; s=arc-20160816; b=D9o8RloGcAoI7Q0cvubsXW1M9aIbC6wdyUfAT3ZDjhNRANeBNEkSMY5VRIecxGzPDI mkCPeRL2tV3as87FqfUCMJ/HiP8Ulxra8hp2Ku6bRpoOngO1nS0rnCy9hTP9AaEqOQkP 9SKehlJicJVYUfct2Q6jiklJfMinUXg4ixdS686aFyzKaM7gFBF3EOkakoVhZ8iSCgRt 0au74CheqcM+TOC8oukOcysUsfVHZpwBYxQu7GZnbydaL5hwW0ERDRXgL8pBVQi6KyHW UVlkTgPIRARkdxRhVy3hiftbnQhInbtmtCK5vS2Xm3SwzlJ6ZESoAerhikBO+87zzpkw XbUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=blooHdKDifbZ706AT0MzMnuVVluHjayuNCuCCrTxxLU=; fh=RM9Wqn0/OAyI9oE97v4AVC//eNAVsLZDJyMiKsxiC7E=; b=YqMGUHsD3sd0vAB5tKoW+ao1NnArPdYnLDMCroK87FDA+ifW+MxHPTMAXw44gS+6XG xWb6YF75xG4EJzxhzLF5WVBDhs5cijW4n2Orpp54LZD+2XJljJJTZaoPFLYKQWuuns2J dKzpCTq/gIvB2uSnGQrEgFbJGJz1+vtqIMAx/2j4R/mU4t3bsr9E9m/3dTt8S6fwmMmZ 1TECF2AMyATnxl5O2244aib6p/sGXREZuhUS3HcKv/wqAUO208tV0g+Qp6bDb3KVsiQg F4nEPBBT7fIUjXbv3+rKv5J7h59C5BNQkaMBLL5+7244gxuetV6lWEH8P6Fz9wnG8EWG ygmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fzz+vHPm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id u5-20020a170902e80500b001c59c73c937si2930894plg.598.2023.09.20.01.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 01:11:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fzz+vHPm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8389880AD096; Wed, 20 Sep 2023 00:32:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233764AbjITHcX (ORCPT + 99 others); Wed, 20 Sep 2023 03:32:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233743AbjITHcT (ORCPT ); Wed, 20 Sep 2023 03:32:19 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45CC8C9; Wed, 20 Sep 2023 00:32:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B513C433C7; Wed, 20 Sep 2023 07:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695195133; bh=u4vRJ0fWq09I70IbE8AlVp8IxBCPKi9zruFPuhoW71I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fzz+vHPmATbFrOQfMThFtGdHivljc/gBNrI4IvIM/humx6Cahew02s28qb9rd8/Pa Qicu9H6EThaCTLLlO6LSEuBlakUaj1+KPJ1kQX9OIoT2RDTsNxSLZG3cSFaJo5U2Gc /04IX4AI/oRwIKx+yzRQ+RAzMELckv9BAlq8u9jI6/7zqugirHxv3RF6f98LxkI8I8 Bc1bllvrlJzmC8+fNFCnukrUhDsk5AwtVSaEDO6CKM6h23Xr3PZ4RnXBSkiNUctfQB NcS6QL/Q6Ax7OsDqB0n2DJgKPu2DZG2mN35VPJXBL0UVAyz8cLEMoKzWhBnz9dMzD1 oCXjIw9CFe8ZQ== Date: Wed, 20 Sep 2023 10:32:10 +0300 From: Leon Romanovsky To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Jonathan Cameron , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/8] PCI/treewide: PCIe capability access cleanups Message-ID: <20230920073210.GI4494@unreal> References: <20230919125648.1920-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230919125648.1920-1-ilpo.jarvinen@linux.intel.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 20 Sep 2023 00:32:34 -0700 (PDT) On Tue, Sep 19, 2023 at 03:56:40PM +0300, Ilpo J?rvinen wrote: > Instead of custom code to extract the PCIe capabilities, make the code > more obvious using FIELD_GET/PREP(). > > Also cleanup some duplicated defines in e1000e. > > This is just a step into the right direction, there's plenty of places > still to cleanup which will have to wait for another patch series. > > v3: > - Remove applied patches (scsi) > - Use pci_pcie_cap() and tweak local variable (e1000e) > - Use the correct prefix for RDMA/hfi1 > > v2: > - Remove extract_width() and use FIELD_GET() directly (IB/hfi1) > - Convert other fields beside Link Width ones > - Remove useless u8 casts (scsi: esas2r) > - e1000e: > - Remove defines that duplicate pci_regs.h ones > - Convert to pcie_capability_read_word() > > > Ilpo J?rvinen (8): > RDMA/hfi1: Use FIELD_GET() to extract Link Width Applied this patch to RDMA tree. Thanks