Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 20 Sep 2023 11:12:29 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Linux PM <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v1] thermal: core: Drop trips_disabled bitmask
Message-ID: <ZQqpbSYsUdAZrcrT@shredder>
References: <12296181.O9o76ZdvQC@kreacher>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12296181.O9o76ZdvQC@kreacher>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/0mXbhcA9aHQP6jhFF68hRs+nlD7TqSyTW3yFmfyT/GuTLayuaqqb2t5ftxX?=
 =?us-ascii?Q?2IvlTYHBLTNuhmwaCgnYZ+fdTONLdXoCuy/kUI7INyibPwSNPMa48fBdTL0D?=
 =?us-ascii?Q?R7JXN/hu+xZKOgaCH7X4OOH3MBnQNGLk7DhqkrRC3clJhhnbYV5gWvZsRw/1?=
 =?us-ascii?Q?gn0tsyooA2JUz02i1yPWSDbRIt2JLgL3rwM0eQS27VY68If5c6sUsE8Rr0KH?=
 =?us-ascii?Q?mbYMwJKVjzvZqY+2FVGTYhx2My2pj3lqeT3RdI++WJC0NVpr89Czyt+V+jeL?=
 =?us-ascii?Q?OFdY6W4Ngwh8+uf8rbuyuAevZFPaEWobroJ2RNoo0+ICMogx9z7I9L0lP218?=
 =?us-ascii?Q?w5ukm9MCZUtnYLAgOouL+zfa0+Ab7ilCxMhEPq8Fg6W/UmeX+GOJw+PfLsce?=
 =?us-ascii?Q?bUQj/FwvwoJKEjwyCtoYWz7KgiOkC3mPS/mbruOR7IqNqhi/3lwXjPGcjerf?=
 =?us-ascii?Q?RIxzb4rri5NMr9Bqj+LVWUwT22o5F1Spx2NnSxdWIn00jTNH4DLSiKi5t44R?=
 =?us-ascii?Q?3jubFRut7nV2hqOpPO+2ewrz3N3oZG+irTdA9UwdSdbUasyox/WMIC/tLCsl?=
 =?us-ascii?Q?fw0pfhwjklyn3XA328DTDsve8/xtuJOlSCYYY+PPvKT3NOxPu6xfmu/xu/nh?=
 =?us-ascii?Q?03wdEo1snK6QA7qtNPXIV2QjmfWKc8Leh5r5vDB3HOVG7p9pHLFFcxMpRHAD?=
 =?us-ascii?Q?DQ+2JpiXLpS/JKPrb7sDvHhRzRefHtDXj17Qhiv6CaJlLhedRRIhBloxtUYp?=
 =?us-ascii?Q?ftTsw6yGbLcqEa+AgKGOB9xA5eNJsz/jbB/BGgTedlov2bbuF2xAn2jNDt/i?=
 =?us-ascii?Q?JLl4miXIAUWgRyZELy5pavf2cKY/cq2yRd3oe7rD7gDxHEQDCV/Vqz3GWSzf?=
 =?us-ascii?Q?lYdMPclaJd34lGKEwZXKYg61t2jZ6YpdxVB/zm2Qnhl47iZzuMVr/plB1urx?=
 =?us-ascii?Q?7m+W90erfQlETeFTDS+E9ecHdJIVCLrQdDlM4UGCYnGwGScpUDuhWSlvHZch?=
 =?us-ascii?Q?moUGjUlhqvaJCreLKQNv+MYwNtwFbFdySqEgWCO2+wHEIovLd0OUsNLCnF3n?=
 =?us-ascii?Q?IACkQqKLcgYItXLIspDzIooVzlMwebmfFXsVBdFNuDNpCgUHN/d/UrQqqN7A?=
 =?us-ascii?Q?SRsZbqe4mmK/EW99TtKa8+RlTM4n7whTVcGJwPQTkMRylEyQmU1GOVeKr/cT?=
 =?us-ascii?Q?rJLC9mwgjRt9pohmx6oUtswUg97usGSy1OvVTgG//CYHAcV5fOGxoMfI5W0y?=
 =?us-ascii?Q?ZQqggRRe5ZpuwtIRlYzSCRDBGZMda4Tt9Ez2rc32QA+1W47QhOtFr+AG+1j/?=
 =?us-ascii?Q?3j+pPXcVYJqpFIxds4WWPTbHKSvCRJDHihhQadfnmQiU9oJJ5/OhI2dUTnFz?=
 =?us-ascii?Q?hcYrf0jPJiI06vjf6fCGQr5YDArn6dRzuqS0X9PJT3w0eVRF5V36VaONlp0i?=
 =?us-ascii?Q?o+BOOxeG3c7LNppQNw6Klwqc1gk85kaLU23PFqYlZTfjJYvW2sHU//14yEJN?=
 =?us-ascii?Q?cP6G2SHE1SzzzIW/cGTXSLJnt7iImLmvICw2QXQkr2NjBaExbK4xycorhBcl?=
 =?us-ascii?Q?ypTQ6hU4D5CIdQh3SpxRt52mNGsGsjwImZmglF0W?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d1be4be-3ca5-47a8-5132-08dbb9b15a5c
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 08:12:38.1316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X5kc9bhAXnrE3ASz/fs2z5mu40lDZJo8EkQYvUsb204lFgrjdv/uBG0r8bMMiJlLCETMpbao4X80Dg5YVXveTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6122
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 20 Sep 2023 01:12:56 -0700 (PDT)

On Tue, Sep 19, 2023 at 08:54:37PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> After recent changes, thermal_zone_get_trip() cannot fail, as invoked
> from thermal_zone_device_register_with_trips(), so the only role of
> the trips_disabled bitmask is struct thermal_zone_device is to make
> handle_thermal_trip() skip trip points whose temperature was initially
> zero.  However, since the unit of temperature in the thermal core is
> millicelsius, zero may very well be a valid temperature value at least
> in some usage scenarios and the trip temperature may as well change
> later.  Thus there is no reason to permanently disable trip points
> with initial temperature equal to zero.
> 
> Accordingly, drop the trips_disabled bitmask along with the code
> related to it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

I guess I was copied because of commit f1b80a3878b2 ("thermal: core:
Restore behavior regarding invalid trip points"). Since then we stopped
relying on this behavior with commit 5601ef91fba8 ("mlxsw: core_thermal:
Use static trip points for transceiver modules").

Tested your patch and didn't see any regressions:

Tested-by: Ido Schimmel <idosch@nvidia.com>

Thanks