Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   "Usyskin, Alexander" <alexander.usyskin@intel.com>
To:     "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "De Marchi, Lucas" <lucas.demarchi@intel.com>,
        "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Winkler, Tomas" <tomas.winkler@intel.com>,
        "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: RE: [Intel-xe] [PATCH v2 0/4] drm/xe/gsc: add initial gsc support
Thread-Topic: [Intel-xe] [PATCH v2 0/4] drm/xe/gsc: add initial gsc support
Thread-Index: AQHZ5uJU4dZB8UAZnUqHEr+T0h+hArAgxnUAgAJ/HKA=
Date:   Wed, 20 Sep 2023 06:15:51 +0000
Message-ID: <CY5PR11MB6366B29757BAD32AC21C0B8AEDF9A@CY5PR11MB6366.namprd11.prod.outlook.com>
References: <20230914080138.4178295-1-alexander.usyskin@intel.com>
 <ZQh1klXZSf9/qqf5@intel.com>
In-Reply-To: <ZQh1klXZSf9/qqf5@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HeqaQ/6Tk352bofLCRBpflxxe0a90Awe7pbAEgGAnoe5nWpMQrbD/bTltvMk?=
 =?us-ascii?Q?dJr2iRJ4FBy7WYGGxzEQ8jpZmiT/ea18Nj+LARLNroJJA+/5Hy76ndMmGFDg?=
 =?us-ascii?Q?xXalIgDCtRS+EGE2J5zGCibCncK0YaCh4qBBb5Lb7xZBf0Iz1CFZ3Q316t7E?=
 =?us-ascii?Q?z0uJzl35lQfG7R02Ut6F2SUA/6RoLuxrVF62ffW3P5p9z5L0zom6vV8RRCBi?=
 =?us-ascii?Q?ZmFnag8ajO58a1j/a1rRoYNomumEUF61KlZU0ltMONXa8D9CdIf5jtol59PY?=
 =?us-ascii?Q?08InkgJ3ZCz2K1SMnEvYctpdXlcY4TF7HTor1SUq3B/UMG3780M+dhF9OSHv?=
 =?us-ascii?Q?Ksq5Ep0lnZZCBVWar2ec8LDGocZosHEt9+ss3Ue2vZX1K8frkHEeN0lQqHYP?=
 =?us-ascii?Q?lzmkbSFgF2Z6OnJcPQo3ETBYGdamInSS9m4k0LyReic0aXGMpY26q0dAq0bS?=
 =?us-ascii?Q?NqXxk1qzmAvKwKGSDAAEnKi7meiJTz4T9QmdYyCAQOtGHR02cTwayGE4jy6l?=
 =?us-ascii?Q?6sHo2ZRYgDewKP5iHadUi3dKJohyBRGXtO0PtcqkiQSdNkGcBaRtsrdeAPkV?=
 =?us-ascii?Q?ntQlUyQj0B456BkQ9Iz/SOMJVy4Fv6gmDaV4PuI+Rq1seTbxmJPh4LzFhPfz?=
 =?us-ascii?Q?XLkZZxurWOC8DjqYV14YSrh9AW3rX/Q3ubOZ/NhWELZ6eMAFoW7ad5Txnoog?=
 =?us-ascii?Q?zoI5+6B5S40tmMBAwoF61Iudhb59J/iVSPFvM68Oj4q1gJC4r8PeSDmafYU/?=
 =?us-ascii?Q?l5Y2t6m3pXkKogq/YLqTKDlM+Abbl26aEfuc4EY4ponL72RvkXfatFUn2rwv?=
 =?us-ascii?Q?L6s7/p7CzLDOT7burWN+Zj0AMhi9g2ihVESgDhTQ/D9kchVRh090WrHuR/ZA?=
 =?us-ascii?Q?5g4qsZF4npw6uJaBiO3nHCIOJyegEy4NXHqbo5oSuBk2/o7EHdNh6u9XPwS3?=
 =?us-ascii?Q?k8r7mnjBUKbvyoa4qJidnSSJ7ArzWyyyxyPAobbpIgjEG96pMo+MpcNPlb7n?=
 =?us-ascii?Q?cmaKcs7WVZDwhNqaqT35mJpcYFaJe7PZLsSX5TRD22DZ8+gqAsiz1U9bRHqH?=
 =?us-ascii?Q?v/qFCfGN7jb9cJQ2HrgVvrj7IczIJLHQzEPkHbkcJDTX+uCA6bMlhsbDJ5oo?=
 =?us-ascii?Q?RE/6AS8FfAw2FwB0amJUaOmIXjWWKV9jzWyzVIHbI/7X+Lr+FYfqkFg2rWwN?=
 =?us-ascii?Q?nn+Vdmc2NGjMuj6fsWahDgXrLQBtFO71Hc3XazVc112uIzOQ6v6EZG5YhSlG?=
 =?us-ascii?Q?q9M4qeNP9RLbTZIUKsXSl9KEmc4tWvV/A71eCQ3A9ewa8dU0Oy+kcuDCk6dQ?=
 =?us-ascii?Q?xUcpd9QHnq9NLZSkFZCKpyK2m+ifIe5Po8YAZwLBwomoXsw/z9nG7rO2Hfqg?=
 =?us-ascii?Q?mEq0o5vjaraFmGsxqXsYjAp+ZSjNeqS+mbYhJ9SigNa63DjK/pn9venstfIC?=
 =?us-ascii?Q?kDzvxGBKRykATtneLMyCvypBIcLyNZ/GsE1odWSEp8jNT0M93uivSAyBwCXK?=
 =?us-ascii?Q?NTq2hc8fDEbMWpAcUwe8AgiH/0PXJeOxFGN/JXXnnSIAh2Wv6dYXDeUXUdzj?=
 =?us-ascii?Q?taDkEo4l+BJc3vyjLLSe8r0ByWQHl6z1ieB4c3gMQzDYwBIObTJr/VdUb3E3?=
 =?us-ascii?Q?Mg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7a4b600-0f6b-4a28-ae83-08dbb9a109f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2023 06:15:51.0649
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x3PhNevONjs1rQyuA9ZsVxd0CGCA8iP73PIsAmqWO80H7q/zqnaU+vkqU8pa6ir1KX9LG7ws/KPaWJ3LQ1nS+MnjUeLBRyvecMhovkhs8J4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8051
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 19 Sep 2023 23:16:16 -0700 (PDT)


> -----Original Message-----
> From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Sent: Monday, September 18, 2023 19:07
> To: Usyskin, Alexander <alexander.usyskin@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; De Marchi, Lucas
> <lucas.demarchi@intel.com>; Ceraolo Spurio, Daniele
> <daniele.ceraolospurio@intel.com>; linux-kernel@vger.kernel.org; Winkler,
> Tomas <tomas.winkler@intel.com>; intel-xe@lists.freedesktop.org
> Subject: Re: [Intel-xe] [PATCH v2 0/4] drm/xe/gsc: add initial gsc suppor=
t
>=20
> On Thu, Sep 14, 2023 at 11:01:34AM +0300, Alexander Usyskin wrote:
> > Add initial GSC support for DG1 and DG2.
> > Create mei-gscfi auxiliary device and add
> > support for device created by Xe to the mei-gsc driver.
>=20
> why are we not adding the GSC already? because dependency on the GSC
> engine or something like that?
>=20

The DG1 and DG2 have only HECI-GSC routed via mei.
The pure GSC without mei is for later projects.

--=20
Thanks,
Sasha


> >
> > This series intended to be merged intto Xe tree,
> > the only patch that touches char-misc is addition
> > of id and alias in mei-gsc.
> >
> > V2: Added heci_ to struct and APIs
> >     heci_gsc moved under xe_device as GSC is not under GT
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > Vitaly Lubart (4):
> >   drm/xe/gsc: add HECI2 register offsets
> >   drm/xe/gsc: add has_heci_gscfi indication to device
> >   drm/xe/gsc: add gsc device support
> >   mei: gsc: add support for auxiliary device created by Xe driver
> >
> >  drivers/gpu/drm/xe/Kconfig           |   1 +
> >  drivers/gpu/drm/xe/Makefile          |   1 +
> >  drivers/gpu/drm/xe/regs/xe_regs.h    |   4 +
> >  drivers/gpu/drm/xe/xe_device.c       |   4 +
> >  drivers/gpu/drm/xe/xe_device_types.h |   7 +
> >  drivers/gpu/drm/xe/xe_heci_gsc.c     | 205
> +++++++++++++++++++++++++++
> >  drivers/gpu/drm/xe/xe_heci_gsc.h     |  35 +++++
> >  drivers/gpu/drm/xe/xe_irq.c          |  14 +-
> >  drivers/gpu/drm/xe/xe_pci.c          |   9 +-
> >  drivers/misc/mei/gsc-me.c            |   5 +
> >  10 files changed, 281 insertions(+), 4 deletions(-)
> >  create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.c
> >  create mode 100644 drivers/gpu/drm/xe/xe_heci_gsc.h
> >
> > --
> > 2.34.1
> >