Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <12296181.O9o76ZdvQC@kreacher> <ZQqpbSYsUdAZrcrT@shredder>
In-Reply-To: <ZQqpbSYsUdAZrcrT@shredder>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 20 Sep 2023 11:54:48 +0200
Message-ID: <CAJZ5v0i2Fjq8V=fy4TODbQxC5dtFc+rwJ1fuE3PMZeMn0=ttGQ@mail.gmail.com>
Subject: Re: [PATCH v1] thermal: core: Drop trips_disabled bitmask
To:     Ido Schimmel <idosch@nvidia.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Sep 20, 2023 at 10:12 AM Ido Schimmel <idosch@nvidia.com> wrote:
>
> On Tue, Sep 19, 2023 at 08:54:37PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > After recent changes, thermal_zone_get_trip() cannot fail, as invoked
> > from thermal_zone_device_register_with_trips(), so the only role of
> > the trips_disabled bitmask is struct thermal_zone_device is to make
> > handle_thermal_trip() skip trip points whose temperature was initially
> > zero.  However, since the unit of temperature in the thermal core is
> > millicelsius, zero may very well be a valid temperature value at least
> > in some usage scenarios and the trip temperature may as well change
> > later.  Thus there is no reason to permanently disable trip points
> > with initial temperature equal to zero.
> >
> > Accordingly, drop the trips_disabled bitmask along with the code
> > related to it.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> I guess I was copied because of commit f1b80a3878b2 ("thermal: core:
> Restore behavior regarding invalid trip points").

That's correct.

> Since then we stopped
> relying on this behavior with commit 5601ef91fba8 ("mlxsw: core_thermal:
> Use static trip points for transceiver modules").
>
> Tested your patch and didn't see any regressions:
>
> Tested-by: Ido Schimmel <idosch@nvidia.com>

Thank you!