Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 20 Sep 2023 10:51:27 +0100
Message-ID: <86v8c5cgv4.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Chris Zankel <chris@zankel.net>,
        Max Filippov <jcmvbkbc@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 09/16] irqchip: irq-xtensa-mx: include header for missing prototype
In-Reply-To: <20230920052139.10570-10-rdunlap@infradead.org>
References: <20230920052139.10570-1-rdunlap@infradead.org>
        <20230920052139.10570-10-rdunlap@infradead.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 20 Sep 2023 06:21:32 +0100,
Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> Add <linux/irqchips/xtensa-mx.h> to provide the function prototype to
> prevent a build warning:
> 
> drivers/irqchip/irq-xtensa-mx.c:166:12: warning: no previous prototype for 'xtensa_mx_init_legacy' [-Wmissing-prototypes]
>   166 | int __init xtensa_mx_init_legacy(struct device_node *interrupt_parent)
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
>  drivers/irqchip/irq-xtensa-mx.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/drivers/irqchip/irq-xtensa-mx.c b/drivers/irqchip/irq-xtensa-mx.c
> --- a/drivers/irqchip/irq-xtensa-mx.c
> +++ b/drivers/irqchip/irq-xtensa-mx.c
> @@ -12,6 +12,7 @@
>  #include <linux/irqdomain.h>
>  #include <linux/irq.h>
>  #include <linux/irqchip.h>
> +#include <linux/irqchip/xtensa-mx.h>
>  #include <linux/of.h>
>  
>  #include <asm/mxregs.h>
> 

Acked-by: Marc Zyngier <maz@kernel.org>

It also begs the question of the continuing support for non-DT driven
systems.

Max, Chris: are we any closer to being DT-only on the xtensa front?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.