Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <114145FFA8546AF1+24aac21b-3748-3d50-4154-a25ab59be1be@tinylab.org>
Date:   Wed, 20 Sep 2023 18:04:10 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH -fixes] riscv: Remove duplicate objcopy flag
To:     Palmer Dabbelt <palmer@dabbelt.com>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu,
        anup@brainfault.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <mhng-8cabcad9-a181-4db8-904b-3f7daa7621f1@palmer-ri-x1c9a>
From:   Song Shuai <songshuaishuai@tinylab.org>
In-Reply-To: <mhng-8cabcad9-a181-4db8-904b-3f7daa7621f1@palmer-ri-x1c9a>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrsz:qybglogicsvrsz4a-0
Precedence: bulk


在 2023/9/20 17:52, Palmer Dabbelt 写道:
> On Thu, 14 Sep 2023 02:13:34 PDT (-0700), songshuaishuai@tinylab.org wrote:
>> There are two duplicate `-O binary` flags when objcopying from vmlinux
>> to Image/xipImage.
>>
>> RISC-V set `-O binary` flag in both OBJCOPYFLAGS in the top-level riscv
>> Makefile and OBJCOPYFLAGS_* in the boot/Makefile, and the objcopy cmd
>> in Kbuild would join them together.
>>
>> The `-O binary` flag is only needed for objcopying Image, so remove the
>> OBJCOPYFLAGS in the top-level riscv Makefile.
>>
>> Fixes: c0fbcd991860 ("RISC-V: Build flat and compressed kernel images")
>> Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
>> ---
>>  arch/riscv/Makefile | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
>> index 1329e060c548..b43a6bb7e4dc 100644
>> --- a/arch/riscv/Makefile
>> +++ b/arch/riscv/Makefile
>> @@ -6,7 +6,6 @@
>>  # for more details.
>>  #
>>
>> -OBJCOPYFLAGS    := -O binary
>>  LDFLAGS_vmlinux := -z norelro
>>  ifeq ($(CONFIG_RELOCATABLE),y)
>>      LDFLAGS_vmlinux += -shared -Bsymbolic -z notext --emit-relocs
> 
> Does this result in any incorrect behavior?  It looks fine to me, but if
Nop, objcopy works as it's expected. You can put this patch on -next.

> there's no regression I'll put in on -next instead of -fixes.
> 
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> 

-- 
Thanks
Song Shuai