Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <1caff361-3680-3e65-f66e-f61938242de5@arm.com>
Date:   Wed, 20 Sep 2023 16:11:02 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH V5 - RESEND 3/3] Documentation: coresight: Add
 cc_threshold tunable
Content-Language: en-US
To:     Suzuki K Poulose <suzuki.poulose@arm.com>,
        linux-arm-kernel@lists.infradead.org
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Mike Leach <mike.leach@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        coresight@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20230915093649.435163-1-anshuman.khandual@arm.com>
 <20230915093649.435163-4-anshuman.khandual@arm.com>
 <cd4e78fb-7385-6db4-b558-4599b0cdcbff@arm.com>
From:   Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <cd4e78fb-7385-6db4-b558-4599b0cdcbff@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9/20/23 14:55, Suzuki K Poulose wrote:
> On 15/09/2023 10:36, Anshuman Khandual wrote:
>> This updates config option to include 'cc_threshold' tunable value.
>>
>> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
>> Cc: Mike Leach <mike.leach@linaro.org>
>> Cc: James Clark <james.clark@arm.com>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: coresight@lists.linaro.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-doc@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Reviewed by: Mike Leach <mike.leach@linaro.org>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>>   Documentation/trace/coresight/coresight.rst | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/trace/coresight/coresight.rst b/Documentation/trace/coresight/coresight.rst
>> index 4a71ea6cb390..ce55adb80b82 100644
>> --- a/Documentation/trace/coresight/coresight.rst
>> +++ b/Documentation/trace/coresight/coresight.rst
>> @@ -624,6 +624,10 @@ They are also listed in the folder /sys/bus/event_source/devices/cs_etm/format/
>>      * - timestamp
>>        - Session local version of the system wide setting: :ref:`ETMv4_MODE_TIMESTAMP
>>          <coresight-timestamp>`
>> +   * - cc_threshold
>> +     - Cycle count threshold value. If nothing is provided here or the provided value is 0, then the
>> +       default value i.e 0x100 will be used. If provided value is less than minimum cycles threshold
>> +       value, as indicated via TRCIDR3.CCITMIN, then the minimum value will be used instead.
>>     How to use the STM module
>>   -------------------------
> 
> The patch as such looks good to me. If possible, could you fold this into the previous patch ?

Being a documentation update, may be it's better to have this in a separate patch.