Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1248973rdb; Wed, 20 Sep 2023 04:10:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXHVRUBQpWaJ0wb0qVivNWhRGXxxLmc4fIYNFUYdQG7PQU631muLJp82UItG3WAxckIHcn X-Received: by 2002:a17:902:d2cd:b0:1c5:6f43:9502 with SMTP id n13-20020a170902d2cd00b001c56f439502mr3436299plc.14.1695208241634; Wed, 20 Sep 2023 04:10:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695208241; cv=none; d=google.com; s=arc-20160816; b=buT+tbybBA3QLivUFT2FOvdARTgUkt19jjiiBUuxYgiUek1HkzhLEoLo0Tix+xn6xL 31stIJMVpNBoja7EEci5LALnUNd3i3lZyyV8s13ycrxkONtkpLvV2hWeAHaeyvTFbE8m OYf+pnae4IxX0Ae8pqvj/J4FBlGs4Mgqgy2YFHXwdZqi9fQwc1bhT43pIJ5Db4iYMaDf tqL4zdYD6k3Oh27Fe5PcB290r3U/GaGciw4/XfzU/AoLKeGYsfwZ6JVHI1PR0WFpY0q1 brRl72FaaWGdu9ageoPQs7BmwldkYKtRnkh93IUMvF6zHKJP9EksGTZISsUNKTIZP7fA EFWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=wJcOco1B/UMJt1c7ozHkaIobXRFKnvaIHtZU2LoNpyg=; fh=G+5L1fACim1Tf0rbpuPbTku1YB/Lxo4mDPElvS1kQDE=; b=0Ws3SU8av/uT7T7ijejG/93U9vHD8ygOuA6lX3XEn8ykJU7mn6xL/SXRLRNCP/Pf+W l7ChhKXncF+CoJiJf8NWVfxYr9umeefmN61x1N4X1u8yz+haAPMBL3LXodgEBF2588Od IWm78OgNYVIAHx01n1mRqqQ5dozyn7pkij/P+gn8bMwME3tHa698/WWMesHpVYjTAaox oYH/fqUq7UmRUtHGQ2Fm667V2gm411u4232Aa85ibvC5FP98ZCSPe+3itOYCIDRlaR6r hA16jtuseA1hebU9+wDQKU3OYG8el6xFX/Y0HUaLISXx85MKkKRbP6pnDdVrfK58/AZv 3SVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id y11-20020a170903010b00b001c470e70cf7si6372459plc.273.2023.09.20.04.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 04:10:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 2C84E807792C; Wed, 20 Sep 2023 04:05:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234382AbjITLFW (ORCPT + 99 others); Wed, 20 Sep 2023 07:05:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234335AbjITLFV (ORCPT ); Wed, 20 Sep 2023 07:05:21 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4801CA; Wed, 20 Sep 2023 04:05:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9C93C433C8; Wed, 20 Sep 2023 11:05:11 +0000 (UTC) Date: Wed, 20 Sep 2023 12:05:09 +0100 From: Catalin Marinas To: Jan Bottorff Cc: Yann Sionneau , Wolfram Sang , Serge Semin , Yann Sionneau , Will Deacon , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: designware: Fix corrupted memory seen in the ISR Message-ID: References: <37e10c3d-b5ab-75ec-3c96-76e15eb9bef8@sionneau.net> <9de89e14-35bd-415d-97f1-4b6db1258997@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 20 Sep 2023 04:05:30 -0700 (PDT) On Wed, Sep 20, 2023 at 11:44:58AM +0100, Catalin Marinas wrote: > On Tue, Sep 19, 2023 at 11:54:10AM -0700, Jan Bottorff wrote: > > The ARM docs do have a specific example case where the device write triggers > > an interrupt, and that example specifically says a DSB barrier is needed. > > Yeah, the Arm ARM is not very precise here on what the mailbox is, > whether it's a local or shared peripheral and they went for the > stronger DMB. Will added a good explanation on why a DMB is sufficient ^^^ DSB (fixing typo in my reply) -- Catalin