Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Wed, 20 Sep 2023 11:21:13 +0200
From:   "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To:     Ricky WU <ricky_wu@realtek.com>
Cc:     "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "paul.grandperrin@gmail.com" <paul.grandperrin@gmail.com>,
        Jade Lovelace <lists@jade.fyi>
Subject: Re: [PATCH] misc: rtsx: Fix some platforms can not boot and move the
 l1ss  judgment to probe
Message-ID: <2023092032-blurred-upload-30bd@gregkh>
References: <37b1afb997f14946a8784c73d1f9a4f5@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <37b1afb997f14946a8784c73d1f9a4f5@realtek.com>
Precedence: bulk

On Wed, Sep 20, 2023 at 09:11:19AM +0000, Ricky WU wrote:
> commit 101bd907b424 ("misc: rtsx: judge ASPM Mode to set PETXCFG Reg")
> some readers no longer force #CLKREQ to low
> when the system need to enter ASPM.
> But some platform maybe not implement complete ASPM?
> it causes some platforms can not boot
> 
> Like in the past only the platform support L1ss we release the #CLKREQ.
> Move the judgment (L1ss) to probe,
> we think read config space one time when the driver start is enough
> 
> Fixes: 101bd907b424 ("misc: rtsx: judge ASPM Mode to set PETXCFG Reg")
> Signed-off-by: Ricky Wu <ricky_wu@realtek.com>

What about all of the people that reported this issue?  Have they been
able to test it?  At least a reported-by line should be added, right?

And I'd like someone to test it to verify it fixes the issue before
applying it...

thanks,

greg k-h