Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Wed, 20 Sep 2023 14:47:15 +0200
From:   Paul Grandperrin <paul.grandperrin@gmail.com>
Subject: Re: [PATCH] misc: rtsx: Fix some platforms can not boot and move the
 l1ss  judgment to probe
To:     gregkh@linuxfoundation.org
Cc:     Ricky WU <ricky_wu@realtek.com>, arnd@arndb.de,
        linux-kernel@vger.kernel.org, Jade Lovelace <lists@jade.fyi>
Message-Id: <RIBA1S.HYP1X2RG9UAF3@gmail.com>
In-Reply-To: <2023092032-blurred-upload-30bd@gregkh>
References: <37b1afb997f14946a8784c73d1f9a4f5@realtek.com>
        <2023092032-blurred-upload-30bd@gregkh>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk

Hi Greg and Ricky,
I just finished testing the patch (on top of 6.1.53) and AFAICT it's 
working perfectly:
- system boots and all hardware devices seems to work fine
- nothing weird in kernel and system logs
- suspend-to-ram (S3) works
- the SD card reader works

If there's anything more you want me to test, don't hesitate.

Paul

On Wed, Sep 20 2023 at 11:21:13 +02:00:00, gregkh@linuxfoundation.org 
wrote:
> On Wed, Sep 20, 2023 at 09:11:19AM +0000, Ricky WU wrote:
>>  commit 101bd907b424 ("misc: rtsx: judge ASPM Mode to set PETXCFG 
>> Reg")
>>  some readers no longer force #CLKREQ to low
>>  when the system need to enter ASPM.
>>  But some platform maybe not implement complete ASPM?
>>  it causes some platforms can not boot
>> 
>>  Like in the past only the platform support L1ss we release the 
>> #CLKREQ.
>>  Move the judgment (L1ss) to probe,
>>  we think read config space one time when the driver start is enough
>> 
>>  Fixes: 101bd907b424 ("misc: rtsx: judge ASPM Mode to set PETXCFG 
>> Reg")
>>  Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
> 
> What about all of the people that reported this issue?  Have they been
> able to test it?  At least a reported-by line should be added, right?
> 
> And I'd like someone to test it to verify it fixes the issue before
> applying it...
> 
> thanks,
> 
> greg k-h